mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-28 11:18:45 +07:00
0252f73334
The following error occurs in a debug build when running MPI PSM: [ 307.415911] WARNING: CPU: 4 PID: 23867 at lib/dma-debug.c:1158 check_unmap+0x4ee/0xa20 [ 307.455661] ib_qib 0000:05:00.0: DMA-API: device driver failed to check map error[device address=0x00000000df82b000] [size=4096 bytes] [mapped as page] [ 307.517494] Modules linked in: [ 307.531584] ib_isert iscsi_target_mod ib_srpt target_core_mod rpcrdma sunrpc ib_srp scsi_transport_srp scsi_tgt ib_iser libiscsi ib_ipoib scsi_transport_iscsi rdma_ucm ib_ucm ib_uverbs ib_umad rdma_cm ib_cm iw_cm ib_qib intel_powerclamp coretemp rdmavt intel_rapl iosf_mbi kvm_intel kvm irqbypass crc32_pclmul ghash_clmulni_intel ipmi_ssif ib_core aesni_intel sg ipmi_si lrw gf128mul dca glue_helper ipmi_devintf iTCO_wdt gpio_ich hpwdt iTCO_vendor_support ablk_helper hpilo acpi_power_meter cryptd ipmi_msghandler ie31200_edac shpchp pcc_cpufreq lpc_ich pcspkr ip_tables xfs libcrc32c sd_mod crc_t10dif crct10dif_generic mgag200 i2c_algo_bit drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops ttm ahci crct10dif_pclmul crct10dif_common drm crc32c_intel libahci tg3 libata serio_raw ptp i2c_core [ 307.846113] pps_core dm_mirror dm_region_hash dm_log dm_mod [ 307.866505] CPU: 4 PID: 23867 Comm: mpitests-IMB-MP Kdump: loaded Not tainted 3.10.0-862.el7.x86_64.debug #1 [ 307.911178] Hardware name: HP ProLiant DL320e Gen8, BIOS J05 11/09/2013 [ 307.944206] Call Trace: [ 307.956973] [<ffffffffbd9e915b>] dump_stack+0x19/0x1b [ 307.982201] [<ffffffffbd2a2f58>] __warn+0xd8/0x100 [ 308.005999] [<ffffffffbd2a2fdf>] warn_slowpath_fmt+0x5f/0x80 [ 308.034260] [<ffffffffbd5f667e>] check_unmap+0x4ee/0xa20 [ 308.060801] [<ffffffffbd41acaa>] ? page_add_file_rmap+0x2a/0x1d0 [ 308.090689] [<ffffffffbd5f6c4d>] debug_dma_unmap_page+0x9d/0xb0 [ 308.120155] [<ffffffffbd4082e0>] ? might_fault+0xa0/0xb0 [ 308.146656] [<ffffffffc07761a5>] qib_tid_free.isra.14+0x215/0x2a0 [ib_qib] [ 308.180739] [<ffffffffc0776bf4>] qib_write+0x894/0x1280 [ib_qib] [ 308.210733] [<ffffffffbd540b00>] ? __inode_security_revalidate+0x70/0x80 [ 308.244837] [<ffffffffbd53c2b7>] ? security_file_permission+0x27/0xb0 [ 308.266025] qib_ib0.8006: multicast join failed for ff12:401b:8006:0000:0000:0000:ffff:ffff, status -22 [ 308.323421] [<ffffffffbd46f5d3>] vfs_write+0xc3/0x1f0 [ 308.347077] [<ffffffffbd492a5c>] ? fget_light+0xfc/0x510 [ 308.372533] [<ffffffffbd47045a>] SyS_write+0x8a/0x100 [ 308.396456] [<ffffffffbd9ff355>] system_call_fastpath+0x1c/0x21 The code calls a qib_map_page() which has never correctly tested for a mapping error. Fix by testing for pci_dma_mapping_error() in all cases and properly handling the failure in the caller. Additionally, streamline qib_map_page() arguments to satisfy just the single caller. Cc: <stable@vger.kernel.org> Reviewed-by: Alex Estrin <alex.estrin@intel.com> Tested-by: Don Dutile <ddutile@redhat.com> Reviewed-by: Don Dutile <ddutile@redhat.com> Signed-off-by: Mike Marciniszyn <mike.marciniszyn@intel.com> Signed-off-by: Dennis Dalessandro <dennis.dalessandro@intel.com> Signed-off-by: Doug Ledford <dledford@redhat.com>
163 lines
4.5 KiB
C
163 lines
4.5 KiB
C
/*
|
|
* Copyright (c) 2006, 2007, 2008, 2009 QLogic Corporation. All rights reserved.
|
|
* Copyright (c) 2003, 2004, 2005, 2006 PathScale, Inc. All rights reserved.
|
|
*
|
|
* This software is available to you under a choice of one of two
|
|
* licenses. You may choose to be licensed under the terms of the GNU
|
|
* General Public License (GPL) Version 2, available from the file
|
|
* COPYING in the main directory of this source tree, or the
|
|
* OpenIB.org BSD license below:
|
|
*
|
|
* Redistribution and use in source and binary forms, with or
|
|
* without modification, are permitted provided that the following
|
|
* conditions are met:
|
|
*
|
|
* - Redistributions of source code must retain the above
|
|
* copyright notice, this list of conditions and the following
|
|
* disclaimer.
|
|
*
|
|
* - Redistributions in binary form must reproduce the above
|
|
* copyright notice, this list of conditions and the following
|
|
* disclaimer in the documentation and/or other materials
|
|
* provided with the distribution.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
|
|
* BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
|
|
* ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
|
|
* CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
|
|
* SOFTWARE.
|
|
*/
|
|
|
|
#include <linux/mm.h>
|
|
#include <linux/sched/signal.h>
|
|
#include <linux/device.h>
|
|
|
|
#include "qib.h"
|
|
|
|
static void __qib_release_user_pages(struct page **p, size_t num_pages,
|
|
int dirty)
|
|
{
|
|
size_t i;
|
|
|
|
for (i = 0; i < num_pages; i++) {
|
|
if (dirty)
|
|
set_page_dirty_lock(p[i]);
|
|
put_page(p[i]);
|
|
}
|
|
}
|
|
|
|
/*
|
|
* Call with current->mm->mmap_sem held.
|
|
*/
|
|
static int __qib_get_user_pages(unsigned long start_page, size_t num_pages,
|
|
struct page **p)
|
|
{
|
|
unsigned long lock_limit;
|
|
size_t got;
|
|
int ret;
|
|
|
|
lock_limit = rlimit(RLIMIT_MEMLOCK) >> PAGE_SHIFT;
|
|
|
|
if (num_pages > lock_limit && !capable(CAP_IPC_LOCK)) {
|
|
ret = -ENOMEM;
|
|
goto bail;
|
|
}
|
|
|
|
for (got = 0; got < num_pages; got += ret) {
|
|
ret = get_user_pages(start_page + got * PAGE_SIZE,
|
|
num_pages - got,
|
|
FOLL_WRITE | FOLL_FORCE,
|
|
p + got, NULL);
|
|
if (ret < 0)
|
|
goto bail_release;
|
|
}
|
|
|
|
current->mm->pinned_vm += num_pages;
|
|
|
|
ret = 0;
|
|
goto bail;
|
|
|
|
bail_release:
|
|
__qib_release_user_pages(p, got, 0);
|
|
bail:
|
|
return ret;
|
|
}
|
|
|
|
/**
|
|
* qib_map_page - a safety wrapper around pci_map_page()
|
|
*
|
|
* A dma_addr of all 0's is interpreted by the chip as "disabled".
|
|
* Unfortunately, it can also be a valid dma_addr returned on some
|
|
* architectures.
|
|
*
|
|
* The powerpc iommu assigns dma_addrs in ascending order, so we don't
|
|
* have to bother with retries or mapping a dummy page to insure we
|
|
* don't just get the same mapping again.
|
|
*
|
|
* I'm sure we won't be so lucky with other iommu's, so FIXME.
|
|
*/
|
|
int qib_map_page(struct pci_dev *hwdev, struct page *page, dma_addr_t *daddr)
|
|
{
|
|
dma_addr_t phys;
|
|
|
|
phys = pci_map_page(hwdev, page, 0, PAGE_SIZE, PCI_DMA_FROMDEVICE);
|
|
if (pci_dma_mapping_error(hwdev, phys))
|
|
return -ENOMEM;
|
|
|
|
if (!phys) {
|
|
pci_unmap_page(hwdev, phys, PAGE_SIZE, PCI_DMA_FROMDEVICE);
|
|
phys = pci_map_page(hwdev, page, 0, PAGE_SIZE,
|
|
PCI_DMA_FROMDEVICE);
|
|
if (pci_dma_mapping_error(hwdev, phys))
|
|
return -ENOMEM;
|
|
/*
|
|
* FIXME: If we get 0 again, we should keep this page,
|
|
* map another, then free the 0 page.
|
|
*/
|
|
}
|
|
*daddr = phys;
|
|
return 0;
|
|
}
|
|
|
|
/**
|
|
* qib_get_user_pages - lock user pages into memory
|
|
* @start_page: the start page
|
|
* @num_pages: the number of pages
|
|
* @p: the output page structures
|
|
*
|
|
* This function takes a given start page (page aligned user virtual
|
|
* address) and pins it and the following specified number of pages. For
|
|
* now, num_pages is always 1, but that will probably change at some point
|
|
* (because caller is doing expected sends on a single virtually contiguous
|
|
* buffer, so we can do all pages at once).
|
|
*/
|
|
int qib_get_user_pages(unsigned long start_page, size_t num_pages,
|
|
struct page **p)
|
|
{
|
|
int ret;
|
|
|
|
down_write(¤t->mm->mmap_sem);
|
|
|
|
ret = __qib_get_user_pages(start_page, num_pages, p);
|
|
|
|
up_write(¤t->mm->mmap_sem);
|
|
|
|
return ret;
|
|
}
|
|
|
|
void qib_release_user_pages(struct page **p, size_t num_pages)
|
|
{
|
|
if (current->mm) /* during close after signal, mm can be NULL */
|
|
down_write(¤t->mm->mmap_sem);
|
|
|
|
__qib_release_user_pages(p, num_pages, 1);
|
|
|
|
if (current->mm) {
|
|
current->mm->pinned_vm -= num_pages;
|
|
up_write(¤t->mm->mmap_sem);
|
|
}
|
|
}
|