Daniel Vetter 7355965da2 drm/vkms: Forward timer right after drm_crtc_handle_vblank ... In commit def35e7c59 Author: Shayenne Moura <shayenneluzmoura@gmail.com> Date: Wed Jan 30 14:06:36 2019 -0200 drm/vkms: Bugfix extra vblank frame we fixed the vblank counter to give accurate results outside of drm_crtc_handle_vblank, which fixed bugs around vblank timestamps being off-by-one and causing the vblank counter to jump when it shouldn't. The trouble is that this completely broke crc generation. Shayenne and Rodrigo tracked this down to the vblank timestamp going backwards in time somehow. Which then resulted in an underflow in drm_vblank.c code, which resulted in all kinds of things breaking really badly. The reason for this is that once we've called drm_crtc_handle_vblank and the hrtimer isn't forwarded yet, we're returning a vblank timestamp in the past. This race is really hard to hit since it's small, except when you enable crc generation: In that case there's a call to drm_crtc_accurate_vblank right in-betwen, so we're guaranteed to hit the bug. The fix is to roll the hrtimer forward _before_ we do the vblank processing (which has a side-effect of incrementing the vblank counter), and we always subtract one frame from the hrtimer - since now it's always one frame in the future. To make sure we don't hit this again also add a WARN_ON checking for whether our timestamp is somehow moving into the past, which is never should. This also aligns more with how real hw works: 1. first all registers are updated with the new timestamp/vblank counter values. 2. then an interrupt is generated 3. kernel interrupt handler eventually fires. So doing this aligns vkms closer with what drm_vblank.c expects. Document this also in a comment. Cc: Shayenne Moura <shayenneluzmoura@gmail.com> Cc: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Tested-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com> Reviewed-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com> Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com> Link: https://patchwork.freedesktop.org/patch/msgid/20190606084404.12014-1-daniel.vetter@ffwll.ch		2019-06-06 20:36:21 -03:00
..
Makefile	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
vkms_crc.c	drm/vkms: Fix license inconsistent	2019-02-10 10:23:06 -02:00
vkms_crtc.c	drm/vkms: Forward timer right after drm_crtc_handle_vblank	2019-06-06 20:36:21 -03:00
vkms_drv.c	Linux 5.0-rc7	2019-02-18 13:27:15 +10:00
vkms_drv.h	drm/vkms: Fix license inconsistent	2019-02-10 10:23:06 -02:00
vkms_gem.c	drm/vkms: fix use-after-free when drm_gem_handle_create() fails	2019-03-18 08:45:57 +01:00
vkms_output.c	drm/vkms: Remove useless call to drm_connector_register/unregister()	2019-06-06 20:33:28 -03:00
vkms_plane.c	drm/vkms: Fix license inconsistent	2019-02-10 10:23:06 -02:00