Fernando Luis Vazquez Cao 6049f2530c rtnetlink: fix oops in rtnl_link_get_slave_info_data_size ... We should check whether rtnetlink link operations are defined before calling get_slave_size(). Without this, the following oops can occur when adding a tap device to OVS. [ 87.839553] BUG: unable to handle kernel NULL pointer dereference at 00000000000000a8 [ 87.839595] IP: [<ffffffff813d47c0>] if_nlmsg_size+0xf0/0x220 [...] [ 87.840651] Call Trace: [ 87.840664] [<ffffffff813d694b>] ? rtmsg_ifinfo+0x2b/0x100 [ 87.840688] [<ffffffff813c8340>] ? __netdev_adjacent_dev_insert+0x150/0x1a0 [ 87.840718] [<ffffffff813d6a50>] ? rtnetlink_event+0x30/0x40 [ 87.840742] [<ffffffff814b4144>] ? notifier_call_chain+0x44/0x70 [ 87.840768] [<ffffffff813c8946>] ? __netdev_upper_dev_link+0x3c6/0x3f0 [ 87.840798] [<ffffffffa0678d6c>] ? netdev_create+0xcc/0x160 [openvswitch] [ 87.840828] [<ffffffffa06781ea>] ? ovs_vport_add+0x4a/0xd0 [openvswitch] [ 87.840857] [<ffffffffa0670139>] ? new_vport+0x9/0x50 [openvswitch] [ 87.840884] [<ffffffffa067279e>] ? ovs_vport_cmd_new+0x11e/0x210 [openvswitch] [ 87.840915] [<ffffffff813f3efa>] ? genl_family_rcv_msg+0x19a/0x360 [ 87.840941] [<ffffffff813f40c0>] ? genl_family_rcv_msg+0x360/0x360 [ 87.840967] [<ffffffff813f4139>] ? genl_rcv_msg+0x79/0xc0 [ 87.840991] [<ffffffff813b6cf9>] ? __kmalloc_reserve.isra.25+0x29/0x80 [ 87.841018] [<ffffffff813f2389>] ? netlink_rcv_skb+0xa9/0xc0 [ 87.841042] [<ffffffff813f27cf>] ? genl_rcv+0x1f/0x30 [ 87.841064] [<ffffffff813f1988>] ? netlink_unicast+0xe8/0x1e0 [ 87.841088] [<ffffffff813f1d9a>] ? netlink_sendmsg+0x31a/0x750 [ 87.841113] [<ffffffff813aee96>] ? sock_sendmsg+0x86/0xc0 [ 87.841136] [<ffffffff813c960d>] ? __netdev_update_features+0x4d/0x200 [ 87.841163] [<ffffffff813ca94e>] ? ethtool_get_value+0x2e/0x50 [ 87.841188] [<ffffffff813af269>] ? ___sys_sendmsg+0x359/0x370 [ 87.841212] [<ffffffff813da686>] ? dev_ioctl+0x1a6/0x5c0 [ 87.841236] [<ffffffff8109c210>] ? autoremove_wake_function+0x30/0x30 [ 87.841264] [<ffffffff813ac59d>] ? sock_do_ioctl+0x3d/0x50 [ 87.841288] [<ffffffff813aca68>] ? sock_ioctl+0x1e8/0x2c0 [ 87.841312] [<ffffffff811934bf>] ? do_vfs_ioctl+0x2cf/0x4b0 [ 87.841335] [<ffffffff813afeb9>] ? __sys_sendmsg+0x39/0x70 [ 87.841362] [<ffffffff814b86f9>] ? system_call_fastpath+0x16/0x1b [ 87.841386] Code: c0 74 10 48 89 ef ff d0 83 c0 07 83 e0 fc 48 98 49 01 c7 48 89 ef e8 d0 d6 fe ff 48 85 c0 0f 84 df 00 00 00 48 8b 90 08 07 00 00 <48> 8b 8a a8 00 00 00 31 d2 48 85 c9 74 0c 48 89 ee 48 89 c7 ff [ 87.841529] RIP [<ffffffff813d47c0>] if_nlmsg_size+0xf0/0x220 [ 87.841555] RSP <ffff880221aa5950> [ 87.841569] CR2: 00000000000000a8 [ 87.851442] ---[ end trace e42ab217691b4fc2 ]--- Signed-off-by: Fernando Luis Vazquez Cao <fernando@oss.ntt.co.jp> Acked-by: Jiri Pirko <jiri@resnulli.us> Signed-off-by: David S. Miller <davem@davemloft.net>		2014-02-04 20:28:51 -08:00
..
9p	net/9p: remove virtio default hack and set appropriate bits instead	2013-11-23 16:13:36 -06:00
802	neigh: use NEIGH_VAR_INIT in ndo_neigh_setup functions.	2014-01-16 11:31:58 -08:00
8021q	8021q: Use ether_addr_copy	2014-01-21 18:13:04 -08:00
appletalk	net: Fix some fallout from the etner_addr_copy() changes.	2014-01-21 18:57:26 -08:00
atm	net: Fix some fallout from the etner_addr_copy() changes.	2014-01-21 18:57:26 -08:00
ax25	net: add build-time checks for msg->msg_name size	2014-01-18 23:04:16 -08:00
batman-adv	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2014-01-18 00:55:41 -08:00
bluetooth	net: add build-time checks for msg->msg_name size	2014-01-18 23:04:16 -08:00
bridge	bridge: Remove unnecessary vlan_put_tag in br_handle_vlan	2014-01-22 21:29:27 -08:00
caif	net: Missing change from the ether_addr_copy() fixups.	2014-01-21 22:54:01 -08:00
can	linux-can-fixes-for-3.14-20140129	2014-01-30 16:48:17 -08:00
ceph	Merge branch 'for-3.14/core' of git://git.kernel.dk/linux-block	2014-01-30 11:19:05 -08:00
core	rtnetlink: fix oops in rtnl_link_get_slave_info_data_size	2014-02-04 20:28:51 -08:00
dcb	dcb: use __dev_get_by_name instead of dev_get_by_name to find interface	2014-01-14 18:50:46 -08:00
dccp	ipv4: introduce hardened ip_no_pmtu_disc mode	2014-01-13 11:22:55 -08:00
decnet	net: add build-time checks for msg->msg_name size	2014-01-18 23:04:16 -08:00
dns_resolver	net/*: Fix FSF address in file headers	2013-12-06 12:37:57 -05:00
dsa	dsa: Use ether_addr_copy	2014-01-21 18:13:05 -08:00
ethernet	net: eth_type_trans() should use skb_header_pointer()	2014-01-16 15:30:31 -08:00
hsr	net/hsr: using kfree_rcu() to simplify the code	2013-12-17 16:32:30 -05:00
ieee802154	net: 6lowpan: fixup for code movement	2014-01-27 16:43:03 -08:00
ipv4	net/ipv4: Use proper RCU APIs for writer-side in udp_offload.c	2014-02-04 20:01:55 -08:00
ipv6	net: Fix memory leak if TPROXY used with TCP early demux	2014-01-27 16:22:11 -08:00
ipx	net: add build-time checks for msg->msg_name size	2014-01-18 23:04:16 -08:00
irda	net: add build-time checks for msg->msg_name size	2014-01-18 23:04:16 -08:00
iucv	net: rework recvmsg handler msg_name and msg_namelen logic	2013-11-20 21:52:30 -05:00
key	xfrm: export verify_userspi_info for pkfey and netlink interface	2013-12-16 12:54:02 +01:00
l2tp	ipv6: protect protocols not handling ipv4 from v4 connection/bind attempts	2014-01-21 16:59:19 -08:00
lapb	net/lapb: re-send packets on timeout	2013-09-23 16:52:45 -04:00
llc	llc: remove noisy WARN from llc_mac_hdr_init	2014-01-28 18:01:32 -08:00
mac80211	Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next into for-davem	2014-01-17 14:43:17 -05:00
mac802154	mac802154: fix following checkpath.pl warning Prefer pr_warn(... to pr_warning(...	2013-12-22 18:53:08 -05:00
mpls	ipip: add GSO/TSO support	2013-10-19 19:36:19 -04:00
netfilter	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2014-01-25 11:17:34 -08:00
netlabel	netlabel: Fix FSF address in file headers	2013-12-06 12:37:56 -05:00
netlink	net: add build-time checks for msg->msg_name size	2014-01-18 23:04:16 -08:00
netrom	net: add build-time checks for msg->msg_name size	2014-01-18 23:04:16 -08:00
nfc	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2014-01-25 11:17:34 -08:00
openvswitch	net: replace macros net_random and net_srandom with direct calls to prandom	2014-01-14 15:15:25 -08:00
packet	af_packet: Add Queue mapping mode to af_packet fanout operation	2014-01-22 17:35:50 -08:00
phonet	net: add build-time checks for msg->msg_name size	2014-01-18 23:04:16 -08:00
rds	net: add build-time checks for msg->msg_name size	2014-01-18 23:04:16 -08:00
rfkill	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2014-01-25 11:17:34 -08:00
rose	net: add build-time checks for msg->msg_name size	2014-01-18 23:04:16 -08:00
rxrpc	RxRPC fixes	2014-01-28 18:04:18 -08:00
sched	net: add and use skb_gso_transport_seglen()	2014-01-26 22:38:23 -08:00
sctp	sctp: remove macros sctp_bh_[un]lock_sock	2014-01-21 18:41:36 -08:00
sunrpc	Merge branch 'for-3.14' of git://linux-nfs.org/~bfields/linux	2014-01-30 10:18:43 -08:00
tipc	net: add build-time checks for msg->msg_name size	2014-01-18 23:04:16 -08:00
unix	net: add build-time checks for msg->msg_name size	2014-01-18 23:04:16 -08:00
vmw_vsock	net: add build-time checks for msg->msg_name size	2014-01-18 23:04:16 -08:00
wimax	wimax: remove dead code	2013-11-21 13:09:42 -05:00
wireless	Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next into for-davem	2014-01-17 14:43:17 -05:00
x25	net: add build-time checks for msg->msg_name size	2014-01-18 23:04:16 -08:00
xfrm	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2014-01-25 11:17:34 -08:00
compat.c	net: clamp ->msg_namelen instead of returning an error	2013-11-29 16:12:52 -05:00
Kconfig	net: netprio: rename config to be more consistent with cgroup configs	2014-01-03 23:41:42 +01:00
Makefile	net: move 6lowpan compression code to separate module	2014-01-15 15:36:38 -08:00
nonet.c
socket.c	net: handle error more gracefully in socketpair()	2013-12-10 22:24:13 -05:00
sysctl_net.c	net: Update the sysctl permissions handler to test effective uid/gid	2013-10-07 15:57:56 -04:00