Mark Rutland da9ec3d3dd perf: Correctly handle failed perf_get_aux_event() ... Vince reports a worrying issue: | so I was tracking down some odd behavior in the perf_fuzzer which turns | out to be because perf_even_open() sometimes returns 0 (indicating a file | descriptor of 0) even though as far as I can tell stdin is still open. ... and further the cause: | error is triggered if aux_sample_size has non-zero value. | | seems to be this line in kernel/events/core.c: | | if (perf_need_aux_event(event) && !perf_get_aux_event(event, group_leader)) | goto err_locked; | | (note, err is never set) This seems to be a thinko in commit: ab43762ef0 ("perf: Allow normal events to output AUX data") ... and we should probably return -EINVAL here, as this should only happen when the new event is mis-configured or does not have a compatible aux_event group leader. Fixes: ab43762ef0 ("perf: Allow normal events to output AUX data") Reported-by: Vince Weaver <vincent.weaver@maine.edu> Signed-off-by: Mark Rutland <mark.rutland@arm.com> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Signed-off-by: Ingo Molnar <mingo@kernel.org> Acked-by: Alexander Shishkin <alexander.shishkin@linux.intel.com> Tested-by: Vince Weaver <vincent.weaver@maine.edu>		2020-01-17 11:32:44 +01:00
..
callchain.c
core.c	perf: Correctly handle failed perf_get_aux_event()	2020-01-17 11:32:44 +01:00
hw_breakpoint.c
internal.h	perf/aux: Allow using AUX data in perf samples	2019-11-13 11:06:14 +01:00
Makefile
ring_buffer.c	perf/aux: Allow using AUX data in perf samples	2019-11-13 11:06:14 +01:00
uprobes.c	mm/mmap.c: use IS_ERR_VALUE to check return value of get_unmapped_area	2019-12-01 06:29:19 -08:00