Masami Hiramatsu 5f843ed415 kprobes: Fix error check when reusing optimized probes ... The following commit introduced a bug in one of our error paths: 819319fc93 ("kprobes: Return error if we fail to reuse kprobe instead of BUG_ON()") it missed to handle the return value of kprobe_optready() as error-value. In reality, the kprobe_optready() returns a bool result, so "true" case must be passed instead of 0. This causes some errors on kprobe boot-time selftests on ARM: [ ] Beginning kprobe tests... [ ] Probe ARM code [ ] kprobe [ ] kretprobe [ ] ARM instruction simulation [ ] Check decoding tables [ ] Run test cases [ ] FAIL: test_case_handler not run [ ] FAIL: Test andge r10, r11, r14, asr r7 [ ] FAIL: Scenario 11 ... [ ] FAIL: Scenario 7 [ ] Total instruction simulation tests=1631, pass=1433 fail=198 [ ] kprobe tests failed This can happen if an optimized probe is unregistered and next kprobe is registered on same address until the previous probe is not reclaimed. If this happens, a hidden aggregated probe may be kept in memory, and no new kprobe can probe same address. Also, in that case register_kprobe() will return "1" instead of minus error value, which can mislead caller logic. Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org> Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com> Cc: David S . Miller <davem@davemloft.net> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Naveen N . Rao <naveen.n.rao@linux.vnet.ibm.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: stable@vger.kernel.org # v5.0+ Fixes: 819319fc93 ("kprobes: Return error if we fail to reuse kprobe instead of BUG_ON()") Link: http://lkml.kernel.org/r/155530808559.32517.539898325433642204.stgit@devnote2 Signed-off-by: Ingo Molnar <mingo@kernel.org>		2019-04-16 09:38:16 +02:00
..
bpf	xdp: fix cpumap redirect SKB creation bug	2019-03-29 12:15:02 -07:00
cgroup
configs
debug
dma	dma-debug: only skip one stackframe entry	2019-04-11 19:29:50 +02:00
events	perf/core: Fix perf_event_disable_inatomic() race	2019-04-12 08:55:55 +02:00
gcov
irq	genirq: Respect IRQCHIP_SKIP_SET_WAKE in irq_chip_set_wake_parent()	2019-04-05 17:41:41 +02:00
livepatch
locking	locking/lockdep: Zap lock classes even with lock debugging disabled	2019-04-10 13:45:59 +02:00
power
printk
rcu
sched	sched/fair: Do not re-read ->h_load_next during hierarchical load calculation	2019-04-03 09:50:22 +02:00
time	alarmtimer: Return correct remaining time	2019-04-10 15:23:26 +02:00
trace	Merge branch 'page-refs' (page ref overflow)	2019-04-14 15:09:40 -07:00
.gitignore
acct.c
async.c
audit_fsnotify.c
audit_tree.c
audit_watch.c
audit.c
audit.h
auditfilter.c
auditsc.c
backtracetest.c
bounds.c
capability.c
compat.c
configs.c
context_tracking.c
cpu_pm.c
cpu.c	cpu/hotplug: Prevent crash when CPU bringup fails on CONFIG_HOTPLUG_CPU=n	2019-03-28 13:34:58 +01:00
crash_core.c
crash_dump.c
cred.c
delayacct.c
dma.c
elfcore.c
exec_domain.c
exit.c
extable.c
fail_function.c
fork.c
freezer.c
futex.c	futex: Ensure that futex address is aligned in handle_futex_death()	2019-03-22 13:05:26 +01:00
groups.c
hung_task.c
iomem.c
irq_work.c
jump_label.c
kallsyms.c
kcmp.c
Kconfig.freezer
Kconfig.hz
Kconfig.locks
Kconfig.preempt
kcov.c
kexec_core.c
kexec_file.c
kexec_internal.h
kexec.c
kmod.c
kprobes.c	kprobes: Fix error check when reusing optimized probes	2019-04-16 09:38:16 +02:00
ksysfs.c
kthread.c
latencytop.c
Makefile
memremap.c
module_signing.c
module-internal.h
module.c
notifier.c
nsproxy.c
padata.c
panic.c
params.c
pid_namespace.c
pid.c
profile.c
ptrace.c	ptrace: take into account saved_sigmask in PTRACE{GET,SET}SIGMASK	2019-03-29 10:01:37 -07:00
range.c
reboot.c
relay.c
resource.c
rseq.c
seccomp.c	syscalls: Remove start and number from syscall_get_arguments() args	2019-04-05 09:26:43 -04:00
signal.c	signal: don't silently convert SI_USER signals to non-current pidfd	2019-04-01 23:03:18 +02:00
smp.c
smpboot.c
smpboot.h
softirq.c
stackleak.c
stacktrace.c
stop_machine.c
sys_ni.c	pidfd patches for v5.1-rc1	2019-03-16 13:47:14 -07:00
sys.c
sysctl_binary.c
sysctl.c	kernel/sysctl.c: fix out-of-bounds access when setting file-max	2019-04-05 16:02:31 -10:00
task_work.c
taskstats.c
test_kprobes.c
torture.c
tracepoint.c
tsacct.c
ucount.c
uid16.c
uid16.h
umh.c
up.c
user_namespace.c
user-return-notifier.c
user.c
utsname_sysctl.c
utsname.c
watchdog_hld.c
watchdog.c	watchdog: Respect watchdog cpumask on CPU hotplug	2019-03-28 13:32:01 +01:00
workqueue_internal.h
workqueue.c	workqueue: Only unregister a registered lockdep key	2019-03-21 12:00:18 +01:00