linux_dsm_epyc7002/drivers/net/ethernet/rocker
Arnd Bergmann 16b8b6de32 rocker: fix Wmaybe-uninitialized false-positive
gcc-7 reports a warning that earlier versions did not have:

drivers/net/ethernet/rocker/rocker_ofdpa.c: In function 'ofdpa_port_stp_update':
arch/x86/include/asm/string_32.h:79:22: error: '*((void *)&prev_ctrls+4)' may be used uninitialized in this function [-Werror=maybe-uninitialized]
   *((short *)to + 2) = *((short *)from + 2);
   ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/rocker/rocker_ofdpa.c:2218:7: note: '*((void *)&prev_ctrls+4)' was declared here

This is clearly a variation of the warning about 'prev_state' that
was shut up using uninitialized_var().

We can slightly simplify the code and get rid of the warning by unconditionally
saving the prev_state and prev_ctrls variables. The inlined memcpy is not
particularly expensive here, as it just has to read five bytes from one or
two cache lines.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
2017-03-28 21:42:32 -07:00
..
Kconfig net: ethernet: rocker: Add dependency to CONFIG_BRIDGE in Kconfig 2014-12-09 15:26:43 -05:00
Makefile rocker: introduce worlds infrastructure 2016-02-17 23:08:34 -05:00
rocker_hw.h rocker: rename rocker.h to rocker_hw.h 2016-02-17 23:08:34 -05:00
rocker_main.c drivers: net: generalize napi_complete_done() 2017-01-30 15:10:42 -05:00
rocker_ofdpa.c rocker: fix Wmaybe-uninitialized false-positive 2017-03-28 21:42:32 -07:00
rocker_tlv.c rocker: push tlv processing into separate files 2016-02-17 23:08:34 -05:00
rocker_tlv.h rocker: push tlv processing into separate files 2016-02-17 23:08:34 -05:00
rocker.h rocker: Create an ordered workqueue for FIB offload 2016-12-03 19:29:35 -05:00