Dave Jones bb0dcebef9 ipmi: Remove unnecessary pci_disable_device. ... We call cleanup_one_si from ipmi_pci_remove, which calls ->addr_source_cleanup, which gets set to point to ipmi_pci_cleanup, which does a pci_disable_device. On return from this, we do a second pci_disable_device, which results in the trace below. ipmi_si 0000:00:16.0: disabling already-disabled device Call Trace: [<ffffffff818ce54c>] dump_stack+0x45/0x57 [<ffffffff810525f7>] warn_slowpath_common+0x97/0xe0 [<ffffffff810526f6>] warn_slowpath_fmt+0x46/0x50 [<ffffffff81497ca1>] pci_disable_device+0xb1/0xc0 [<ffffffffa00851a5>] ipmi_pci_remove+0x25/0x30 [ipmi_si] [<ffffffff8149a696>] pci_device_remove+0x46/0xc0 [<ffffffff8156801f>] __device_release_driver+0x7f/0xf0 [<ffffffff81568978>] driver_detach+0xb8/0xc0 [<ffffffff81567e50>] bus_remove_driver+0x50/0xa0 [<ffffffff8156914e>] driver_unregister+0x2e/0x60 [<ffffffff8149a3e5>] pci_unregister_driver+0x25/0x90 [<ffffffffa0085804>] cleanup_ipmi_si+0xd4/0xf0 [ipmi_si] [<ffffffff810c727a>] SyS_delete_module+0x12a/0x200 [<ffffffff818d4d72>] system_call_fastpath+0x12/0x17 Signed-off-by: Dave Jones <dsj@fb.com>		2016-01-12 15:08:49 -06:00
..
ipmi_bt_sm.c	ipmi: Make some data const that was only read	2015-09-03 15:02:27 -05:00
ipmi_devintf.c	ipmi: Free ipmi_recv_msg messages from the linked list on close	2015-02-19 20:58:40 -06:00
ipmi_kcs_sm.c	ipmi: Make some data const that was only read	2015-09-03 15:02:27 -05:00
ipmi_msghandler.c	ipmi: constify some struct and char arrays	2016-01-12 15:08:49 -06:00
ipmi_powernv.c	impi:Remove unneeded setting of module owner to THIS_MODULE in the platform structure, powernv_ipmi_driver	2015-09-03 15:02:24 -05:00
ipmi_poweroff.c	char: Convert use of typedef ctl_table to struct ctl_table	2013-06-17 16:43:08 -07:00
ipmi_si_intf.c	ipmi: Remove unnecessary pci_disable_device.	2016-01-12 15:08:49 -06:00
ipmi_si_sm.h	ipmi: Make some data const that was only read	2015-09-03 15:02:27 -05:00
ipmi_smic_sm.c	ipmi: Make some data const that was only read	2015-09-03 15:02:27 -05:00
ipmi_ssif.c	char: ipmi: Drop owner assignment from i2c_driver	2016-01-12 15:08:49 -06:00
ipmi_watchdog.c	ipmi watchdog : add panic_wdt_timeout parameter	2015-11-16 06:28:43 -06:00
Kconfig	drivers/char/ipmi: Add powernv IPMI driver	2014-12-11 15:04:12 -06:00
Makefile	drivers/char/ipmi: Add powernv IPMI driver	2014-12-11 15:04:12 -06:00