Subash Abhinov Kasiviswanathan 5c346525d3 net: qualcomm: rmnet: Fix rcu splat in rmnet_is_real_dev_registered ... Xiaolong reported a suspicious rcu_dereference_check in the device unregister notifier callback. Since we do not dereference the rx_handler_data, it's ok to just check for the value of the pointer. Note that this section is already protected by rtnl_lock. [ 101.364846] WARNING: suspicious RCU usage [ 101.365654] 4.13.0-rc6-01701-gceed73a #1 Not tainted [ 101.370873] ----------------------------- [ 101.372472] drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c:57 suspicious rcu_dereference_check() usage! [ 101.374427] [ 101.374427] other info that might help us debug this: [ 101.374427] [ 101.387491] [ 101.387491] rcu_scheduler_active = 2, debug_locks = 1 [ 101.389368] 1 lock held by trinity-main/2809: [ 101.390736] #0: (rtnl_mutex){+.+.+.}, at: [<8146085b>] rtnl_lock+0xf/0x11 [ 101.395482] [ 101.395482] stack backtrace: [ 101.396948] CPU: 0 PID: 2809 Comm: trinity-main Not tainted 4.13.0-rc6-01701-gceed73a #1 [ 101.398857] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.9.3-20161025_171302-gandalf 04/01/2014 [ 101.401079] Call Trace: [ 101.401656] dump_stack+0xa1/0xeb [ 101.402871] lockdep_rcu_suspicious+0xc7/0xd0 [ 101.403665] rmnet_is_real_dev_registered+0x40/0x4e [ 101.405199] rmnet_config_notify_cb+0x2c/0x142 [ 101.406344] ? wireless_nlevent_flush+0x47/0x71 [ 101.407385] notifier_call_chain+0x2d/0x47 [ 101.408645] raw_notifier_call_chain+0xc/0xe [ 101.409882] call_netdevice_notifiers_info+0x41/0x49 [ 101.411402] call_netdevice_notifiers+0xc/0xe [ 101.412713] rollback_registered_many+0x268/0x36e [ 101.413702] rollback_registered+0x39/0x56 [ 101.414965] unregister_netdevice_queue+0x79/0x88 [ 101.415908] unregister_netdev+0x16/0x1d Fixes: ceed73a2cf ("drivers: net: ethernet: qualcomm: rmnet: Initial implementation") Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org> Reported-by: kernel test robot <xiaolong.ye@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2017-09-23 19:59:53 -07:00
..
accessibility
acpi	Merge branches 'acpi-pmic', 'acpi-bus', 'acpi-wdat' and 'acpi-properties'	2017-09-22 23:38:45 +02:00
amba
android
ata	Merge branch 'for-4.14' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata	2017-09-06 22:41:21 -07:00
atm
auxdisplay
base	Power management fixes for v4.14-rc2	2017-09-22 17:28:59 -10:00
bcma
block	The highlights include:	2017-09-12 20:03:53 -07:00
bluetooth
bus	ARM: SoC driver updates for v4.14	2017-09-10 20:40:00 -07:00
cdrom
char	dmi: Mark all struct dmi_system_id instances const	2017-09-14 11:59:30 +02:00
clk	The diff is dominated by the Allwinner A10/A20 SoCs getting converted to	2017-09-13 11:04:14 -07:00
clocksource	Merge branch '4.14-features' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus	2017-09-15 20:43:33 -07:00
connector
cpufreq	cpufreq: ti-cpufreq: Support additional am43xx platforms	2017-09-20 00:51:01 +02:00
cpuidle	ARM: cpuidle: Avoid memleak if init fail	2017-09-19 23:10:51 +02:00
crypto	crypto: caam - fix LS1021A support on ARMv7 multiplatform kernel	2017-09-20 17:42:42 +08:00
dax	- Some request-based DM core and DM multipath fixes and cleanups	2017-09-14 13:43:16 -07:00
dca
devfreq
dio
dma	dmaengine updates for 4.14-rc1	2017-09-07 14:03:05 -07:00
dma-buf
edac
eisa
extcon
firewire
firmware	dmi: Mark all struct dmi_system_id instances const	2017-09-14 11:59:30 +02:00
fmc
fpga
fsi
gpio	- New Drivers	2017-09-07 13:51:13 -07:00
gpu	Merge tag 'exynos-drm-fixes-for-v4.14-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos into drm-fixes	2017-09-21 08:02:39 +10:00
hid	media updates for v4.14-rc1	2017-09-07 12:53:14 -07:00
hsi
hv	Merge branch 'x86-platform-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2017-09-07 09:25:15 -07:00
hwmon	dmi: Mark all struct dmi_system_id instances const	2017-09-14 11:59:30 +02:00
hwspinlock
hwtracing
i2c	i2c: i2c-stm32f7: add driver	2017-09-14 17:34:43 +02:00
ide	Merge branch 'for-4.14/block' of git://git.kernel.dk/linux-block	2017-09-07 11:59:42 -07:00
idle
iio	- New Drivers	2017-09-07 13:51:13 -07:00
infiniband	First -rc update for 4.14 kernel	2017-09-23 05:47:04 -10:00
input	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input	2017-09-22 17:23:41 -10:00
iommu	iommu/of: Remove PCI host bridge node check	2017-09-22 12:05:43 +02:00
ipack
irqchip	Merge branch '4.14-features' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus	2017-09-15 20:43:33 -07:00
isdn	isdn/i4l: fetch the ppp_write buffer in one shot	2017-09-20 16:01:36 -07:00
leds	dmi: Mark all struct dmi_system_id instances const	2017-09-14 11:59:30 +02:00
lightnvm
macintosh
mailbox	Just behavorial changes to a controller driver:	2017-09-07 13:23:37 -07:00
mcb
md	Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/shli/md	2017-09-19 08:39:32 -07:00
media	Merge branch 'work.set_fs' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2017-09-14 18:13:32 -07:00
memory	ARM: SoC driver updates for v4.14	2017-09-10 20:40:00 -07:00
memstick
message
mfd	dmi: Mark all struct dmi_system_id instances const	2017-09-14 11:59:30 +02:00
misc	mm: treewide: remove GFP_TEMPORARY allocation flag	2017-09-13 18:53:16 -07:00
mmc	mmc: cavium: Fix use-after-free in of_platform_device_destroy	2017-09-08 15:38:22 +02:00
mtd	mtd: nand: remove unused blockmask variable	2017-09-18 14:51:02 +02:00
mux
net	net: qualcomm: rmnet: Fix rcu splat in rmnet_is_real_dev_registered	2017-09-23 19:59:53 -07:00
nfc
ntb
nubus
nvdimm	libnvdimm, namespace: fix btt claim class crash	2017-09-18 17:29:01 -07:00
nvme	nvme-pci: implement the HMB entry number and size limitations	2017-09-11 12:29:40 -04:00
nvmem
of	dma-mapping updates for 4.14:	2017-09-12 13:30:06 -07:00
oprofile
parisc
parport
pci	PCI: endpoint: Use correct "end of test" interrupt	2017-09-20 13:56:06 -05:00
pcmcia
perf	drivers/perf: arm_pmu_acpi: Release memory obtained by kasprintf	2017-09-22 15:11:46 +01:00
phy	Merge branch '4.14-features' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus	2017-09-15 20:43:33 -07:00
pinctrl	pinctrl/amd: save pin registers over suspend/resume	2017-09-12 15:58:45 +02:00
platform	dmi: Mark all struct dmi_system_id instances const	2017-09-14 11:59:30 +02:00
pnp	dmi: Mark all struct dmi_system_id instances const	2017-09-14 11:59:30 +02:00
power	power supply and reset changes for the v4.14 series	2017-09-09 14:44:39 -07:00
powercap
pps	drivers/pps: use surrounding "if PPS" to remove numerous dependency checks	2017-09-08 18:26:51 -07:00
ps3
ptp
pwm	pwm: Changes for v4.14-rc1	2017-09-11 13:04:32 -07:00
rapidio
ras
regulator	- New Drivers	2017-09-07 13:51:13 -07:00
remoteproc	rpmsg updates for v4.14	2017-09-09 14:34:38 -07:00
reset	Merge branch '4.14-features' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus	2017-09-15 20:43:33 -07:00
rpmsg
rtc	RTC for 4.14	2017-09-13 10:56:00 -07:00
s390	s390/cio: recover from bad paths	2017-09-19 08:36:19 +02:00
sbus
scsi	scsi: sg: fixup infoleak when using SG_GET_REQUEST_TABLE	2017-09-15 15:16:49 -04:00
sfi
sh
sn
soc	Merge branch '4.14-features' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus	2017-09-15 20:43:33 -07:00
spi
spmi
ssb
staging	Merge branch 'work.mount' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2017-09-14 18:54:01 -07:00
target	Merge branch 'work.set_fs' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2017-09-14 18:13:32 -07:00
tc
tee
thermal	Merge branches 'thermal-core', 'thermal-soc', 'thermal-intel' and 'const-thermal-zone-structure' into next	2017-09-08 11:20:04 +08:00
thunderbolt
tty	dmi: Mark all struct dmi_system_id instances const	2017-09-14 11:59:30 +02:00
uio
usb	Merge branch 'work.set_fs' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2017-09-14 18:13:32 -07:00
uwb
vfio
vhost	lib/interval_tree: fast overlap detection	2017-09-08 18:26:49 -07:00
video	fbdev changes for v4.14:	2017-09-14 13:33:33 -07:00
virt
virtio	SCSI misc on 20170907	2017-09-07 21:11:05 -07:00
vlynq
vme
w1	power supply and reset changes for the v4.14 series	2017-09-09 14:44:39 -07:00
watchdog	Merge branch '4.14-features' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus	2017-09-15 20:43:33 -07:00
xen	xen: Fixes for rc2	2017-09-22 06:40:47 -10:00
zorro
Kconfig
Makefile