Leon Romanovsky dc1435c00f RDMA/srp: Rename SRP sysfs name after IB device rename trigger ... SRP logic used device name and port index as symlink to relevant kobject. If the IB device is renamed then the prior name will be re-used by the next device plugged in and sysfs will panic as SRP will try to re-use the same name. mlx5_ib: Mellanox Connect-IB Infiniband driver v5.0-0 sysfs: cannot create duplicate filename '/class/infiniband_srp/srp-mlx5_0-1' CPU: 3 PID: 1107 Comm: modprobe Not tainted 5.1.0-for-upstream-perf-2019-05-12_15-09-52-87 #1 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.2-1ubuntu1 04/01/2014 Call Trace: dump_stack+0x5a/0x73 sysfs_warn_dup+0x58/0x70 sysfs_do_create_link_sd.isra.2+0xa3/0xb0 device_add+0x33f/0x660 srp_add_one+0x301/0x4f0 [ib_srp] add_client_context+0x99/0xe0 [ib_core] enable_device_and_get+0xd1/0x1b0 [ib_core] ib_register_device+0x533/0x710 [ib_core] ? mutex_lock+0xe/0x30 __mlx5_ib_add+0x23/0x70 [mlx5_ib] mlx5_add_device+0x4e/0xd0 [mlx5_core] mlx5_register_interface+0x85/0xc0 [mlx5_core] ? 0xffffffffa0791000 do_one_initcall+0x4b/0x1cb ? kmem_cache_alloc_trace+0xc6/0x1d0 ? do_init_module+0x22/0x21f do_init_module+0x5a/0x21f load_module+0x17f2/0x1ca0 ? m_show+0x1c0/0x1c0 __do_sys_finit_module+0x94/0xe0 do_syscall_64+0x48/0x120 entry_SYSCALL_64_after_hwframe+0x44/0xa9 RIP: 0033:0x7f157cce10d9 The module load/unload sequence was used to trigger such kernel panic: sudo modprobe ib_srp sudo modprobe -r mlx5_ib sudo modprobe -r mlx5_core sudo modprobe mlx5_core Have SRP track the name of the core device so that it can't have a name collision. Fixes: d21943dd19 ("RDMA/core: Implement IB device rename function") Signed-off-by: Leon Romanovsky <leonro@mellanox.com> Reviewed-by: Bart Van Assche <bvanassche@acm.org> Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>		2019-05-21 15:06:45 -03:00
..
ib_addr.h
ib_cache.h	RDMA/cma: Use rdma_read_gid_attr_ndev_rcu to access netdev	2019-05-03 11:10:03 -03:00
ib_cm.h
ib_fmr_pool.h
ib_hdrs.h	IB/hfi1: Build TID RDMA WRITE request	2019-02-05 18:07:43 -05:00
ib_mad.h	RDMA: Use __packed annotation instead of __attribute__ ((packed))	2019-03-25 21:14:12 -03:00
ib_marshall.h
ib_pack.h
ib_pma.h
ib_sa.h
ib_smi.h	RDMA: Use __packed annotation instead of __attribute__ ((packed))	2019-03-25 21:14:12 -03:00
ib_umem_odp.h	RDMA/umem: Combine contiguous PAGE_SIZE regions in SGEs	2019-04-08 13:05:24 -03:00
ib_umem.h	RDMA/umem: Remove hugetlb flag	2019-05-06 13:08:11 -03:00
ib_verbs.h	RDMA/srp: Rename SRP sysfs name after IB device rename trigger	2019-05-21 15:06:45 -03:00
ib.h
iw_cm.h	RDMA: Get rid of iw_cm_verbs	2019-05-03 10:56:56 -03:00
iw_portmap.h	RDMA/iwpm: move kdoc comments to functions	2019-02-05 15:40:41 -07:00
mr_pool.h
opa_addr.h
opa_port_info.h	RDMA: Use __packed annotation instead of __attribute__ ((packed))	2019-03-25 21:14:12 -03:00
opa_smi.h	RDMA: Use __packed annotation instead of __attribute__ ((packed))	2019-03-25 21:14:12 -03:00
opa_vnic.h
rdma_cm_ib.h
rdma_cm.h	IB/cma: Define option to set ack timeout and pack tos_set	2019-02-08 16:14:21 -07:00
rdma_netlink.h	RDMA/core: Add RDMA_NLDEV_CMD_NEWLINK/DELLINK support	2019-02-19 20:52:19 -07:00
rdma_vt.h	IB/rdmavt: Fix ab/ba include issues	2019-04-24 11:31:49 -03:00
rdmavt_cq.h
rdmavt_mr.h
rdmavt_qp.h	IB/{rdmavt, qib, hfi1}: Use new routine to release reference counts	2019-04-24 11:31:49 -03:00
restrack.h	RDMA/restrack: Hide restrack DB from IB/core	2019-02-18 21:04:36 -07:00
rw.h
tid_rdma_defs.h	IB/hfi1: Build TID RDMA WRITE request	2019-02-05 18:07:43 -05:00
uverbs_ioctl.h	IB/verbs: Add helper function rdma_udata_to_drv_context	2019-02-15 11:17:25 -07:00
uverbs_named_ioctl.h	RDMA/uverbs: Fix typo in string concatenation macro	2018-12-06 21:11:06 -07:00
uverbs_std_types.h	IB: When attrs.udata/ufile is available use that instead of uobject	2019-04-08 13:05:25 -03:00
uverbs_types.h	IB: Pass uverbs_attr_bundle down uobject destroy path	2019-04-01 14:55:36 -03:00