mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-16 17:26:41 +07:00
5a9fc9c666
The change fixes a problem, if duty_ns is too small in comparison to period_ns (as a valid corner case duty_ns is 0 ns), then due to PWM_DUTY() macro applied on a value the result is overflowed over 8 bits, and instead of the highest bitfield duty cycle value 0xff the invalid duty cycle bitfield value 0x00 is written. For reference the LPC32xx spec defines PWMx_DUTY bitfield description is this way and it seems to be correct: [Low]/[High] = [PWM_DUTY]/[256-PWM_DUTY], where 0 < PWM_DUTY <= 255. In addition according to my oscilloscope measurements LPC32xx PWM is "tristate" in sense that it produces a wave with floating min/max voltage levels for different duty cycle values, for corner cases: PWM_DUTY == 0x01 => signal is in range from -1.05v to 0v .... PWM_DUTY == 0x80 => signal is in range from -0.75v to +0.75v .... PWM_DUTY == 0xff => signal is in range from 0v to +1.05v PWM_DUTY == 0x00 => signal is around 0v, PWM is off Due to this peculiarity on very long period ranges (less than 1KHz) and odd pre-divider values PWM generated wave does not remind a clock shape signal, but rather a heartbit shape signal with positive and negative peaks, so I would recommend to use high-speed HCLK clock as a PWM parent clock and avoid using RTC clock as a parent. The change corrects PWM output in corner cases and prevents any possible overflows in calculation of values for PWM_DUTY and PWM_RELOADV bitfields, thus helper macro definitions may be removed. Signed-off-by: Vladimir Zapolskiy <vz@mleia.com> Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
167 lines
4.1 KiB
C
167 lines
4.1 KiB
C
/*
|
|
* Copyright 2012 Alexandre Pereira da Silva <aletes.xgr@gmail.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; version 2.
|
|
*
|
|
*/
|
|
|
|
#include <linux/clk.h>
|
|
#include <linux/err.h>
|
|
#include <linux/io.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/of.h>
|
|
#include <linux/of_address.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/pwm.h>
|
|
#include <linux/slab.h>
|
|
|
|
struct lpc32xx_pwm_chip {
|
|
struct pwm_chip chip;
|
|
struct clk *clk;
|
|
void __iomem *base;
|
|
};
|
|
|
|
#define PWM_ENABLE BIT(31)
|
|
|
|
#define to_lpc32xx_pwm_chip(_chip) \
|
|
container_of(_chip, struct lpc32xx_pwm_chip, chip)
|
|
|
|
static int lpc32xx_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
|
|
int duty_ns, int period_ns)
|
|
{
|
|
struct lpc32xx_pwm_chip *lpc32xx = to_lpc32xx_pwm_chip(chip);
|
|
unsigned long long c;
|
|
int period_cycles, duty_cycles;
|
|
u32 val;
|
|
c = clk_get_rate(lpc32xx->clk);
|
|
|
|
/* The highest acceptable divisor is 256, which is represented by 0 */
|
|
period_cycles = div64_u64(c * period_ns,
|
|
(unsigned long long)NSEC_PER_SEC * 256);
|
|
if (!period_cycles)
|
|
period_cycles = 1;
|
|
if (period_cycles > 255)
|
|
period_cycles = 0;
|
|
|
|
/* Compute 256 x #duty/period value and care for corner cases */
|
|
duty_cycles = div64_u64((unsigned long long)(period_ns - duty_ns) * 256,
|
|
period_ns);
|
|
if (!duty_cycles)
|
|
duty_cycles = 1;
|
|
if (duty_cycles > 255)
|
|
duty_cycles = 255;
|
|
|
|
val = readl(lpc32xx->base + (pwm->hwpwm << 2));
|
|
val &= ~0xFFFF;
|
|
val |= (period_cycles << 8) | duty_cycles;
|
|
writel(val, lpc32xx->base + (pwm->hwpwm << 2));
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int lpc32xx_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm)
|
|
{
|
|
struct lpc32xx_pwm_chip *lpc32xx = to_lpc32xx_pwm_chip(chip);
|
|
u32 val;
|
|
int ret;
|
|
|
|
ret = clk_prepare_enable(lpc32xx->clk);
|
|
if (ret)
|
|
return ret;
|
|
|
|
val = readl(lpc32xx->base + (pwm->hwpwm << 2));
|
|
val |= PWM_ENABLE;
|
|
writel(val, lpc32xx->base + (pwm->hwpwm << 2));
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void lpc32xx_pwm_disable(struct pwm_chip *chip, struct pwm_device *pwm)
|
|
{
|
|
struct lpc32xx_pwm_chip *lpc32xx = to_lpc32xx_pwm_chip(chip);
|
|
u32 val;
|
|
|
|
val = readl(lpc32xx->base + (pwm->hwpwm << 2));
|
|
val &= ~PWM_ENABLE;
|
|
writel(val, lpc32xx->base + (pwm->hwpwm << 2));
|
|
|
|
clk_disable_unprepare(lpc32xx->clk);
|
|
}
|
|
|
|
static const struct pwm_ops lpc32xx_pwm_ops = {
|
|
.config = lpc32xx_pwm_config,
|
|
.enable = lpc32xx_pwm_enable,
|
|
.disable = lpc32xx_pwm_disable,
|
|
.owner = THIS_MODULE,
|
|
};
|
|
|
|
static int lpc32xx_pwm_probe(struct platform_device *pdev)
|
|
{
|
|
struct lpc32xx_pwm_chip *lpc32xx;
|
|
struct resource *res;
|
|
int ret;
|
|
|
|
lpc32xx = devm_kzalloc(&pdev->dev, sizeof(*lpc32xx), GFP_KERNEL);
|
|
if (!lpc32xx)
|
|
return -ENOMEM;
|
|
|
|
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
|
|
lpc32xx->base = devm_ioremap_resource(&pdev->dev, res);
|
|
if (IS_ERR(lpc32xx->base))
|
|
return PTR_ERR(lpc32xx->base);
|
|
|
|
lpc32xx->clk = devm_clk_get(&pdev->dev, NULL);
|
|
if (IS_ERR(lpc32xx->clk))
|
|
return PTR_ERR(lpc32xx->clk);
|
|
|
|
lpc32xx->chip.dev = &pdev->dev;
|
|
lpc32xx->chip.ops = &lpc32xx_pwm_ops;
|
|
lpc32xx->chip.npwm = 1;
|
|
lpc32xx->chip.base = -1;
|
|
|
|
ret = pwmchip_add(&lpc32xx->chip);
|
|
if (ret < 0) {
|
|
dev_err(&pdev->dev, "failed to add PWM chip, error %d\n", ret);
|
|
return ret;
|
|
}
|
|
|
|
platform_set_drvdata(pdev, lpc32xx);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int lpc32xx_pwm_remove(struct platform_device *pdev)
|
|
{
|
|
struct lpc32xx_pwm_chip *lpc32xx = platform_get_drvdata(pdev);
|
|
unsigned int i;
|
|
|
|
for (i = 0; i < lpc32xx->chip.npwm; i++)
|
|
pwm_disable(&lpc32xx->chip.pwms[i]);
|
|
|
|
return pwmchip_remove(&lpc32xx->chip);
|
|
}
|
|
|
|
static const struct of_device_id lpc32xx_pwm_dt_ids[] = {
|
|
{ .compatible = "nxp,lpc3220-pwm", },
|
|
{ /* sentinel */ }
|
|
};
|
|
MODULE_DEVICE_TABLE(of, lpc32xx_pwm_dt_ids);
|
|
|
|
static struct platform_driver lpc32xx_pwm_driver = {
|
|
.driver = {
|
|
.name = "lpc32xx-pwm",
|
|
.of_match_table = lpc32xx_pwm_dt_ids,
|
|
},
|
|
.probe = lpc32xx_pwm_probe,
|
|
.remove = lpc32xx_pwm_remove,
|
|
};
|
|
module_platform_driver(lpc32xx_pwm_driver);
|
|
|
|
MODULE_ALIAS("platform:lpc32xx-pwm");
|
|
MODULE_AUTHOR("Alexandre Pereira da Silva <aletes.xgr@gmail.com>");
|
|
MODULE_DESCRIPTION("LPC32XX PWM Driver");
|
|
MODULE_LICENSE("GPL v2");
|