John Hurley 59eb87cb52 net: sched: prevent duplicate flower rules from tcf_proto destroy race ... When a new filter is added to cls_api, the function tcf_chain_tp_insert_unique() looks up the protocol/priority/chain to determine if the tcf_proto is duplicated in the chain's hashtable. It then creates a new entry or continues with an existing one. In cls_flower, this allows the function fl_ht_insert_unque to determine if a filter is a duplicate and reject appropriately, meaning that the duplicate will not be passed to drivers via the offload hooks. However, when a tcf_proto is destroyed it is removed from its chain before a hardware remove hook is hit. This can lead to a race whereby the driver has not received the remove message but duplicate flows can be accepted. This, in turn, can lead to the offload driver receiving incorrect duplicate flows and out of order add/delete messages. Prevent duplicates by utilising an approach suggested by Vlad Buslov. A hash table per block stores each unique chain/protocol/prio being destroyed. This entry is only removed when the full destroy (and hardware offload) has completed. If a new flow is being added with the same identiers as a tc_proto being detroyed, then the add request is replayed until the destroy is complete. Fixes: 8b64678e0a ("net: sched: refactor tp insert/delete for concurrent execution") Signed-off-by: John Hurley <john.hurley@netronome.com> Signed-off-by: Vlad Buslov <vladbu@mellanox.com> Reviewed-by: Simon Horman <simon.horman@netronome.com> Reported-by: Louis Peens <louis.peens@netronome.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2019-11-05 17:47:26 -08:00
..
9p
bluetooth	Bluetooth: Add support for utilizing Fast Advertising Interval	2019-09-05 17:27:21 +02:00
caif
iucv
netfilter	netfilter: nf_tables: bogus EBUSY when deleting flowtable after flush	2019-09-25 11:01:19 +02:00
netns	can: netns: remove "can_" prefix from members struct netns_can	2019-09-04 13:29:14 +02:00
nfc	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234	2019-06-19 17:09:07 +02:00
phonet	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 336	2019-06-05 17:37:07 +02:00
sctp	sctp: add chunks to sk_backlog when the newsk sk_socket is not set	2019-10-09 16:27:04 -07:00
tc_act	net: sched: take reference to psample group in flow_action infra	2019-09-16 09:18:03 +02:00
6lowpan.h
act_api.h	net: sched: use get_dev() action API in flow_action infra	2019-09-16 09:18:03 +02:00
addrconf.h	ipv6: Fix return value of ipv6_mc_may_pull() for malformed packets	2019-08-19 17:19:46 -07:00
af_ieee802154.h
af_rxrpc.h
af_unix.h
af_vsock.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 321	2019-06-05 17:37:05 +02:00
ah.h
arp.h
atmclip.h
ax25.h
ax88796.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
bond_3ad.h
bond_alb.h
bond_options.h	bonding: add an option to specify a delay between peer notifications	2019-07-04 12:30:48 -07:00
bonding.h	bonding: fix state transition issue in link monitoring	2019-11-05 17:40:16 -08:00
bpf_sk_storage.h	bpf: support cloning sk storage on accept()	2019-08-17 23:18:54 +02:00
busy_poll.h	net: annotate lockless accesses to sk->sk_napi_id	2019-10-30 17:34:35 -07:00
calipso.h
cfg80211-wext.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
cfg80211.h	mac80211: fix scan when operating on DFS channels in ETSI domains	2019-10-07 22:10:50 +02:00
cfg802154.h
checksum.h
cipso_ipv4.h
cls_cgroup.h
codel_impl.h
codel_qdisc.h
codel.h
compat.h
datalink.h
dcbevent.h
dcbnl.h
devlink.h	net: devlink: move reload fail indication to devlink core and expose to user	2019-09-13 22:11:14 +02:00
dn_dev.h
dn_fib.h
dn_neigh.h
dn_nsp.h
dn_route.h
dn.h
drop_monitor.h	drop_monitor: Add basic infrastructure for hardware drops	2019-08-17 12:40:08 -07:00
dsa.h	net: dsa: Pass ndo_setup_tc slave callback to drivers	2019-09-16 21:32:57 +02:00
dsfield.h
dst_cache.h
dst_metadata.h
dst_ops.h
dst.h	net: dst.h: Fix shifting signed 32-bit value by 31 bits problem	2019-07-01 10:48:34 -07:00
erspan.h
esp.h
ethoc.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
failover.h
fib_notifier.h
fib_rules.h	net: fib_rules: do not flow dissect local packets	2019-07-11 14:22:53 -07:00
firewire.h
flow_dissector.h	net/flow_dissector: switch to siphash	2019-10-23 20:13:22 -07:00
flow_offload.h	net: sched: extend flow_action_entry with destructor	2019-09-16 09:18:02 +02:00
flow.h
fou.h
fq_impl.h	net/flow_dissector: switch to siphash	2019-10-23 20:13:22 -07:00
fq.h	net/flow_dissector: switch to siphash	2019-10-23 20:13:22 -07:00
garp.h
gen_stats.h
genetlink.h
geneve.h
gre.h
gro_cells.h
gtp.h
gue.h	net:gue.h:Fix shifting signed 32-bit value by 31 bits problem	2019-07-01 10:58:23 -07:00
hwbm.h	net: hwbm: if CONFIG_NET_HWBM unset, make stub functions static	2019-10-25 16:24:32 -07:00
icmp.h
ieee80211_radiotap.h
ieee802154_netdev.h
if_inet6.h	ipv6: shrink struct ipv6_mc_socklist	2019-08-28 14:43:03 -07:00
ife.h
ila.h
inet6_connection_sock.h
inet6_hashtables.h
inet_common.h	inet: factor out inet_send_prepare()	2019-07-03 13:51:54 -07:00
inet_connection_sock.h	net/tls: use RCU protection on icsk->icsk_ulp_data	2019-08-31 23:44:28 -07:00
inet_ecn.h
inet_frag.h	inet: frags: re-introduce skb coalescing for local delivery	2019-08-08 15:55:10 -07:00
inet_hashtables.h
inet_sock.h	ip: support SO_MARK cmsg	2019-09-13 21:44:19 +02:00
inet_timewait_sock.h	tcp: honor SO_PRIORITY in TIME_WAIT state	2019-09-27 12:05:02 +02:00
inetpeer.h
ip6_checksum.h
ip6_fib.h	ipv6: Dump route exceptions if requested	2019-06-24 10:18:49 -07:00
ip6_route.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-06-27 21:06:39 -07:00
ip6_tunnel.h	ip6_tunnel: allow not to count pkts on tstats by passing dev as NULL	2019-06-18 20:48:45 -04:00
ip_fib.h	net: Properly update v4 routes with v6 nexthop	2019-09-05 12:35:58 +02:00
ip_tunnels.h
ip_vs.h	ipvs: move old_secure_tcp into struct netns_ipvs	2019-10-24 11:56:02 +02:00
ip.h	ipv4: fix IPSKB_FRAG_PMTU handling with fragmentation	2019-10-21 10:46:42 -07:00
ipcomp.h
ipconfig.h
ipv6_frag.h	inet: fix various use-after-free in defrags units	2019-06-19 11:37:47 -04:00
ipv6_stubs.h
ipv6.h	ipv6: add priority parameter to ip6_xmit()	2019-09-27 12:05:02 +02:00
ipx.h
iw_handler.h
kcm.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
l3mdev.h
lag.h
lapb.h
lib80211.h
llc_c_ac.h
llc_c_ev.h
llc_c_st.h
llc_conn.h	llc: fix sk_buff leak in llc_conn_service()	2019-10-08 13:23:05 -07:00
llc_if.h
llc_pdu.h
llc_s_ac.h
llc_s_ev.h
llc_s_st.h
llc_sap.h
llc.h
lwtunnel.h
mac80211.h	mac80211: allow drivers to set max MTU	2019-09-11 09:33:29 +02:00
mac802154.h
mip6.h
mld.h
mpls_iptunnel.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 295	2019-06-05 17:36:38 +02:00
mpls.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 295	2019-06-05 17:36:38 +02:00
mrp.h
ncsi.h
ndisc.h	net-ipv6-ndisc: add support for RFC7710 RA Captive Portal Identifier	2019-07-22 12:10:54 -07:00
neighbour.h
net_failover.h
net_namespace.h	netns: fix GFP flags in rtnl_net_notifyid()	2019-10-25 20:14:42 -07:00
net_ratelimit.h
netevent.h
netlabel.h
netlink.h	netlink: Fix nlmsg_parse as a wrapper for strict message parsing	2019-08-13 20:37:16 -07:00
netprio_cgroup.h
netrom.h
nexthop.h	net: Properly update v4 routes with v6 nexthop	2019-09-05 12:35:58 +02:00
nl802154.h
nsh.h
p8022.h
page_pool.h	net: core: page_pool: add user refcnt and reintroduce page_pool_destroy	2019-07-08 14:58:04 -07:00
ping.h
pkt_cls.h	net: sched: take reference to action dev before calling offloads	2019-08-26 14:17:43 -07:00
pkt_sched.h	Merge ra.kernel.org:/pub/scm/linux/kernel/git/netdev/net	2019-09-17 23:51:10 +02:00
pptp.h
protocol.h
psample.h	net: sched: take reference to psample group in flow_action infra	2019-09-16 09:18:03 +02:00
psnap.h
raw.h
rawv6.h
red.h
regulatory.h
request_sock.h	net: add {READ|WRITE}_ONCE() annotations on ->rskq_accept_head	2019-10-09 21:34:31 -07:00
rose.h
route.h	ipv4: Revert removal of rt_uses_gateway	2019-09-20 18:23:33 -07:00
rsi_91x.h
rtnetlink.h
rtnh.h
sch_generic.h	net: sched: prevent duplicate flower rules from tcf_proto destroy race	2019-11-05 17:47:26 -08:00
scm.h
secure_seq.h
seg6_hmac.h
seg6_local.h
seg6.h
slhc_vj.h
smc.h
snmp.h
sock_reuseport.h	udp: correct reuseport selection with connected sockets	2019-09-16 09:02:18 +02:00
sock.h	net: annotate accesses to sk->sk_incoming_cpu	2019-10-30 13:24:25 -07:00
Space.h
stp.h
strparser.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
switchdev.h
tcp_states.h
tcp.h	tcp: annotate sk->sk_rcvbuf lockless reads	2019-10-13 10:13:08 -07:00
timewait_sock.h
tipc.h
tls.h	net/tls: clean up the number of #ifdefs for CONFIG_TLS_DEVICE	2019-09-05 09:49:49 +02:00
transp_v6.h
tso.h
tun_proto.h
udp_tunnel.h
udp.h	udp: Remove unlikely() from IS_ERR*() condition	2019-08-30 19:49:37 -07:00
udplite.h
vsock_addr.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 321	2019-06-05 17:37:05 +02:00
vxlan.h	vxlan: add adjacent link to limit depth level	2019-10-24 14:53:49 -07:00
wext.h
wimax.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 268	2019-06-05 17:30:29 +02:00
x25.h
x25device.h
xdp_priv.h	xdp: add tracepoints for XDP mem	2019-06-19 11:23:13 -04:00
xdp_sock.h	xsk: add support to allow unaligned chunk placement	2019-08-31 01:08:26 +02:00
xdp.h	xdp: page_pool related fix to cpumap	2019-06-19 11:23:13 -04:00
xfrm.h	xfrm interface: fix management of phydev	2019-07-17 10:03:54 +02:00