linux_dsm_epyc7002/drivers/rpmsg
Johannes Berg 59ae1d127a networking: introduce and use skb_put_data()
A common pattern with skb_put() is to just want to memcpy()
some data into the new space, introduce skb_put_data() for
this.

An spatch similar to the one for skb_put_zero() converts many
of the places using it:

    @@
    identifier p, p2;
    expression len, skb, data;
    type t, t2;
    @@
    (
    -p = skb_put(skb, len);
    +p = skb_put_data(skb, data, len);
    |
    -p = (t)skb_put(skb, len);
    +p = skb_put_data(skb, data, len);
    )
    (
    p2 = (t2)p;
    -memcpy(p2, data, len);
    |
    -memcpy(p, data, len);
    )

    @@
    type t, t2;
    identifier p, p2;
    expression skb, data;
    @@
    t *p;
    ...
    (
    -p = skb_put(skb, sizeof(t));
    +p = skb_put_data(skb, data, sizeof(t));
    |
    -p = (t *)skb_put(skb, sizeof(t));
    +p = skb_put_data(skb, data, sizeof(t));
    )
    (
    p2 = (t2)p;
    -memcpy(p2, data, sizeof(*p));
    |
    -memcpy(p, data, sizeof(*p));
    )

    @@
    expression skb, len, data;
    @@
    -memcpy(skb_put(skb, len), data, len);
    +skb_put_data(skb, data, len);

(again, manually post-processed to retain some comments)

Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2017-06-16 11:48:37 -04:00
..
Kconfig soc: qcom: smd: Remove standalone driver 2017-03-28 17:58:07 -07:00
Makefile rpmsg: Driver for user space endpoint interface 2017-01-18 10:43:15 -08:00
qcom_smd.c rpmsg: smd: Register rpmsg user space interface for edges 2017-01-18 10:43:15 -08:00
rpmsg_char.c networking: introduce and use skb_put_data() 2017-06-16 11:48:37 -04:00
rpmsg_core.c rpmsg: rpmsg_create_ept() returns NULL on error 2017-02-13 00:52:54 -08:00
rpmsg_internal.h rpmsg: Driver for user space endpoint interface 2017-01-18 10:43:15 -08:00
virtio_rpmsg_bus.c virtio: wrap find_vqs 2017-05-02 23:41:42 +03:00