linux_dsm_epyc7002/drivers/net/wireless/broadcom
Nicolas Iooss 7703773ef1 brcmfmac: fix pmksa->bssid usage
The struct cfg80211_pmksa defines its bssid field as:

    const u8 *bssid;

contrary to struct brcmf_pmksa, which uses:

    u8 bssid[ETH_ALEN];

Therefore in brcmf_cfg80211_del_pmksa(), &pmksa->bssid takes the address
of this field (of type u8**), not the one of its content (which would be
u8*).  Remove the & operator to make brcmf_dbg("%pM") and memcmp()
behave as expected.

This bug have been found using a custom static checker (which checks the
usage of %p... attributes at build time).  It has been introduced in
commit 6c404f34f2 ("brcmfmac: Cleanup pmksa cache handling code"),
which replaced pmksa->bssid by &pmksa->bssid while refactoring the code,
without modifying struct cfg80211_pmksa definition.

Replace &pmk[i].bssid with pmk[i].bssid too to make the code clearer,
this change does not affect the semantic.

Fixes: 6c404f34f2 ("brcmfmac: Cleanup pmksa cache handling code")
Cc: stable@vger.kernel.org
Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
2016-09-03 20:02:03 +03:00
..
b43 b43: Completely remove support for phy_a 2016-06-16 18:23:18 +03:00
b43legacy cfg80211: remove enum ieee80211_band 2016-04-12 15:56:15 +02:00
brcm80211 brcmfmac: fix pmksa->bssid usage 2016-09-03 20:02:03 +03:00
Kconfig
Makefile