mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-17 15:06:02 +07:00
0c65b2b90d
Before this change of_get_phy_mode() returned an enum, phy_interface_t. On error, -ENODEV etc, is returned. If the result of the function is stored in a variable of type phy_interface_t, and the compiler has decided to represent this as an unsigned int, comparision with -ENODEV etc, is a signed vs unsigned comparision. Fix this problem by changing the API. Make the function return an error, or 0 on success, and pass a pointer, of type phy_interface_t, where the phy mode should be stored. v2: Return with *interface set to PHY_INTERFACE_MODE_NA on error. Add error checks to all users of of_get_phy_mode() Fixup a few reverse christmas tree errors Fixup a few slightly malformed reverse christmas trees v3: Fix 0-day reported errors. Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: David S. Miller <davem@davemloft.net>
37 lines
806 B
C
37 lines
806 B
C
/* SPDX-License-Identifier: GPL-2.0-only */
|
|
/*
|
|
* OF helpers for network devices.
|
|
*/
|
|
|
|
#ifndef __LINUX_OF_NET_H
|
|
#define __LINUX_OF_NET_H
|
|
|
|
#include <linux/phy.h>
|
|
|
|
#ifdef CONFIG_OF_NET
|
|
#include <linux/of.h>
|
|
|
|
struct net_device;
|
|
extern int of_get_phy_mode(struct device_node *np, phy_interface_t *interface);
|
|
extern const void *of_get_mac_address(struct device_node *np);
|
|
extern struct net_device *of_find_net_device_by_node(struct device_node *np);
|
|
#else
|
|
static inline int of_get_phy_mode(struct device_node *np,
|
|
phy_interface_t *interface)
|
|
{
|
|
return -ENODEV;
|
|
}
|
|
|
|
static inline const void *of_get_mac_address(struct device_node *np)
|
|
{
|
|
return ERR_PTR(-ENODEV);
|
|
}
|
|
|
|
static inline struct net_device *of_find_net_device_by_node(struct device_node *np)
|
|
{
|
|
return NULL;
|
|
}
|
|
#endif
|
|
|
|
#endif /* __LINUX_OF_NET_H */
|