Roman Gushchin 569a933b03 bpf: allocate local storage buffers using GFP_ATOMIC ... Naresh reported an issue with the non-atomic memory allocation of cgroup local storage buffers: [ 73.047526] BUG: sleeping function called from invalid context at /srv/oe/build/tmp-rpb-glibc/work-shared/intel-corei7-64/kernel-source/mm/slab.h:421 [ 73.060915] in_atomic(): 1, irqs_disabled(): 0, pid: 3157, name: test_cgroup_sto [ 73.068342] INFO: lockdep is turned off. [ 73.072293] CPU: 2 PID: 3157 Comm: test_cgroup_sto Not tainted 4.20.0-rc2-next-20181113 #1 [ 73.080548] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS 2.0b 07/27/2017 [ 73.088018] Call Trace: [ 73.090463] dump_stack+0x70/0xa5 [ 73.093783] ___might_sleep+0x152/0x240 [ 73.097619] __might_sleep+0x4a/0x80 [ 73.101191] __kmalloc_node+0x1cf/0x2f0 [ 73.105031] ? cgroup_storage_update_elem+0x46/0x90 [ 73.109909] cgroup_storage_update_elem+0x46/0x90 cgroup_storage_update_elem() (as well as other update map update callbacks) is called with disabled preemption, so GFP_ATOMIC allocation should be used: e.g. alloc_htab_elem() in hashtab.c. Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org> Tested-by: Naresh Kamboju <naresh.kamboju@linaro.org> Signed-off-by: Roman Gushchin <guro@fb.com> Cc: Alexei Starovoitov <ast@kernel.org> Cc: Daniel Borkmann <daniel@iogearbox.net> Signed-off-by: Alexei Starovoitov <ast@kernel.org>		2018-11-16 21:17:49 -08:00
..
arraymap.c	bpf: return EOPNOTSUPP when map lookup isn't supported	2018-10-09 21:52:20 -07:00
bpf_lru_list.c
bpf_lru_list.h
btf.c	bpf, btf: fix a missing check bug in btf_parse	2018-10-26 00:42:03 +02:00
cgroup.c	bpf: add cg_skb_is_valid_access for BPF_PROG_TYPE_CGROUP_SKB	2018-10-19 13:49:34 -07:00
core.c	bpf: show real jited prog address in /proc/kallsyms	2018-11-02 21:39:01 +01:00
cpumap.c	bpf: fix redirect to map under tail calls	2018-08-17 15:56:23 -07:00
devmap.c	bpf: devmap: fix wrong interface selection in notifier_call	2018-10-26 00:32:21 +02:00
disasm.c
disasm.h
hashtab.c	bpf: add bpffs pretty print for percpu arraymap/hash/lru_hash	2018-08-30 14:03:53 +02:00
helpers.c	bpf: fix direct packet write into pop/peek helpers	2018-10-25 17:02:06 -07:00
inode.c	bpf: decouple btf from seq bpf fs dump and enable more maps	2018-08-13 00:52:45 +02:00
local_storage.c	bpf: allocate local storage buffers using GFP_ATOMIC	2018-11-16 21:17:49 -08:00
lpm_trie.c	bpf: decouple btf from seq bpf fs dump and enable more maps	2018-08-13 00:52:45 +02:00
Makefile	bpf: add queue and stack maps	2018-10-19 13:24:31 -07:00
map_in_map.c	bpf: don't allow create maps of per-cpu cgroup local storages	2018-10-01 16:18:33 +02:00
map_in_map.h
offload.c	bpf: add verifier callback to get stack usage info for offloaded progs	2018-10-08 10:24:12 +02:00
percpu_freelist.c
percpu_freelist.h
queue_stack_maps.c	bpf: fix leaking uninitialized memory on pop/peek helpers	2018-10-25 17:02:06 -07:00
reuseport_array.c
stackmap.c	bpf: rename stack trace map operations	2018-10-19 13:24:30 -07:00
syscall.c	bpf: fix bpf_prog_get_info_by_fd to return 0 func_lens for unpriv	2018-11-02 13:51:15 -07:00
tnum.c
verifier.c	bpf: fix off-by-one error in adjust_subprog_starts	2018-11-16 21:10:00 -08:00
xskmap.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2018-10-19 11:03:06 -07:00