Sundar R Iyer 500b4ac90d regulator: return set_mode is same mode is requested ... On Mon, 2010-05-17 at 17:34 +0200, Mark Brown wrote: > This doesn't seem like the right error handling - if the driver has a > set_mode() you'd *expect* it to have a get_mode() but there's no need > for it to be a strict requirement. True. In such a case, even a valid request would be lost! So now in the updated patch: - check if get_mode is present to avoid oops; - if get_mode is not present, proceed anyways for the request. Here is the updated patch: >From bad0d5eb51ef84be5b100e3dd0f5a590ea0529b6 Mon Sep 17 00:00:00 2001 From: Sundar R Iyer <sundar.iyer@stericsson.com> Date: Fri, 14 May 2010 15:14:17 +0530 Subject: [PATCH 1/1] regulator: return set_mode when same mode is requested save I/O costs by returning when the same mode is requested for the regulator Cc: Liam Girdwood <lrg@slimlogic.co.uk> Cc: Mark Brown <broonie@opensource.wolfsonmicro.com> Acked-by: Linus Walleij <linus.walleij@stericsson.com> Signed-off-by: Sundar R Iyer <sundar.iyer@stericsson.com> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com> Signed-off-by: Liam Girdwood <lrg@slimlogic.co.uk>		2010-05-25 10:16:02 +01:00
..
accessibility
acpi	sysfs: add struct file* to bin_attr callbacks	2010-05-21 09:37:31 -07:00
amba
ata	Merge remote branch 'origin' into secretlab/next-devicetree	2010-05-22 00:36:56 -06:00
atm	Merge remote branch 'origin' into secretlab/next-devicetree	2010-05-22 00:36:56 -06:00
auxdisplay
base	driver-core: fix Typo in drivers/base/core.c for CONFIG_MODULE	2010-05-21 09:37:32 -07:00
block	Merge remote branch 'origin' into secretlab/next-devicetree	2010-05-22 00:36:56 -06:00
bluetooth	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next-2.6	2010-05-20 21:04:44 -07:00
cdrom	of: Always use 'struct device.of_node' to get device node pointer.	2010-05-18 16:10:44 -06:00
char	Merge branch 'bkl/ioctl' of git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing	2010-05-24 08:01:10 -07:00
clocksource	Merge branch 'timers-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip	2010-05-19 17:10:57 -07:00
connector
cpufreq	Merge branch 'x86-cpu-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip	2010-05-18 08:49:13 -07:00
cpuidle
crypto	Merge remote branch 'origin' into secretlab/next-devicetree	2010-05-22 00:36:56 -06:00
dca
dio
dma	Merge git://git.kernel.org/pub/scm/linux/kernel/git/lethal/sh-2.6	2010-05-24 07:58:28 -07:00
edac	Merge remote branch 'origin' into secretlab/next-devicetree	2010-05-22 00:36:56 -06:00
eisa
firewire	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial	2010-05-20 09:20:59 -07:00
firmware	sysfs: add struct file* to bin_attr callbacks	2010-05-21 09:37:31 -07:00
gpio	Merge remote branch 'origin' into secretlab/next-devicetree	2010-05-22 00:36:56 -06:00
gpu	Merge branch 'drm-for-2.6.35' of git://git.kernel.org/pub/scm/linux/kernel/git/airlied/drm-2.6	2010-05-21 11:14:52 -07:00
hid	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid	2010-05-21 10:51:03 -07:00
hwmon	Merge branch 'bkl/ioctl' of git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing	2010-05-24 08:01:10 -07:00
i2c	Merge remote branch 'origin' into secretlab/next-devicetree	2010-05-22 00:36:56 -06:00
ide	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/ide-2.6	2010-05-24 08:05:29 -07:00
idle
ieee1394
ieee802154
infiniband	Merge remote branch 'origin' into secretlab/next-devicetree	2010-05-22 00:36:56 -06:00
input	Merge branch 'bkl/ioctl' of git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing	2010-05-24 08:01:10 -07:00
isdn	Merge branch 'bkl/ioctl' of git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing	2010-05-24 08:01:10 -07:00
leds	of: Remove duplicate fields from of_platform_driver	2010-05-22 00:10:40 -06:00
lguest
macintosh	Merge branch 'bkl/ioctl' of git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing	2010-05-24 08:01:10 -07:00
mca
md	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6	2010-05-21 19:37:45 -07:00
media	Merge branch 'bkl/ioctl' of git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing	2010-05-24 08:01:10 -07:00
memstick
message	fusion: fix kernel-doc notation	2010-05-24 07:31:20 -07:00
mfd	regulator: use voltage number array in 88pm860x	2010-05-25 10:16:02 +01:00
misc	Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc	2010-05-21 11:17:05 -07:00
mmc	Merge git://git.kernel.org/pub/scm/linux/kernel/git/lethal/sh-2.6	2010-05-24 07:58:28 -07:00
mtd	Merge branch 'bkl/ioctl' of git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing	2010-05-24 08:01:10 -07:00
net	Revert "ath9k: Group Key fix for VAPs"	2010-05-24 07:45:43 -07:00
nubus
of	Merge remote branch 'origin' into secretlab/next-devicetree	2010-05-22 00:36:56 -06:00
oprofile
parisc
parport	Merge remote branch 'origin' into secretlab/next-devicetree	2010-05-22 00:36:56 -06:00
pci	Merge branch 'linux-next' of git://git.kernel.org/pub/scm/linux/kernel/git/jbarnes/pci-2.6	2010-05-21 18:58:52 -07:00
pcmcia	Merge branch 'bkl/ioctl' of git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing	2010-05-24 08:01:10 -07:00
platform	Move N014, N051 and CR620 dmi information to load scm dmi table	2010-05-20 10:16:13 -04:00
pnp
power	Merge git://git.infradead.org/battery-2.6	2010-05-24 08:00:13 -07:00
pps
ps3
rapidio	sysfs: add struct file* to bin_attr callbacks	2010-05-21 09:37:31 -07:00
regulator	regulator: return set_mode is same mode is requested	2010-05-25 10:16:02 +01:00
rtc	Merge branch 'bkl/ioctl' of git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing	2010-05-24 08:01:10 -07:00
s390	sysfs: add struct file* to bin_attr callbacks	2010-05-21 09:37:31 -07:00
sbus	Merge branch 'bkl/ioctl' of git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing	2010-05-24 08:01:10 -07:00
scsi	Merge branch 'bkl/ioctl' of git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing	2010-05-24 08:01:10 -07:00
serial	Merge git://git.kernel.org/pub/scm/linux/kernel/git/lethal/sh-2.6	2010-05-24 07:58:28 -07:00
sfi
sh
sn
spi	Merge remote branch 'origin' into secretlab/next-devicetree	2010-05-22 00:36:56 -06:00
ssb	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next-2.6	2010-05-20 21:04:44 -07:00
staging	Merge git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging-2.6	2010-05-21 15:26:46 -07:00
tc
telephony
thermal
uio
usb	Merge branch 'bkl/ioctl' of git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing	2010-05-24 08:01:10 -07:00
uwb
vhost	Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6	2010-05-16 22:26:58 -07:00
video	Merge remote branch 'origin' into secretlab/next-devicetree	2010-05-22 00:36:56 -06:00
virtio	Merge branch 'virtio' of git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux-2.6-for-linus	2010-05-21 17:22:52 -07:00
vlynq
w1	sysfs: add struct file* to bin_attr callbacks	2010-05-21 09:37:31 -07:00
watchdog	Merge remote branch 'origin' into secretlab/next-devicetree	2010-05-22 00:36:56 -06:00
xen
zorro	sysfs: add struct file* to bin_attr callbacks	2010-05-21 09:37:31 -07:00
Kconfig
Makefile