mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-11-24 04:30:52 +07:00
3f649ab728
Using uninitialized_var() is dangerous as it papers over real bugs[1] (or can in the future), and suppresses unrelated compiler warnings (e.g. "unused variable"). If the compiler thinks it is uninitialized, either simply initialize the variable or make compiler changes. In preparation for removing[2] the[3] macro[4], remove all remaining needless uses with the following script: git grep '\buninitialized_var\b' | cut -d: -f1 | sort -u | \ xargs perl -pi -e \ 's/\buninitialized_var\(([^\)]+)\)/\1/g; s:\s*/\* (GCC be quiet|to make compiler happy) \*/$::g;' drivers/video/fbdev/riva/riva_hw.c was manually tweaked to avoid pathological white-space. No outstanding warnings were found building allmodconfig with GCC 9.3.0 for x86_64, i386, arm64, arm, powerpc, powerpc64le, s390x, mips, sparc64, alpha, and m68k. [1] https://lore.kernel.org/lkml/20200603174714.192027-1-glider@google.com/ [2] https://lore.kernel.org/lkml/CA+55aFw+Vbj0i=1TGqCR5vQkCzWJ0QxK6CernOU6eedsudAixw@mail.gmail.com/ [3] https://lore.kernel.org/lkml/CA+55aFwgbgqhbp1fkxvRKEpzyR5J8n1vKT1VZdz9knmPuXhOeg@mail.gmail.com/ [4] https://lore.kernel.org/lkml/CA+55aFz2500WfbKXAx8s67wrm9=yVJu65TpLgN_ybYNv0VEOKA@mail.gmail.com/ Reviewed-by: Leon Romanovsky <leonro@mellanox.com> # drivers/infiniband and mlx4/mlx5 Acked-by: Jason Gunthorpe <jgg@mellanox.com> # IB Acked-by: Kalle Valo <kvalo@codeaurora.org> # wireless drivers Reviewed-by: Chao Yu <yuchao0@huawei.com> # erofs Signed-off-by: Kees Cook <keescook@chromium.org>
139 lines
2.8 KiB
C
139 lines
2.8 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Copyright (C) 2007 Red Hat, Inc. All rights reserved.
|
|
*/
|
|
|
|
#include <net/genetlink.h>
|
|
#include <linux/dlm.h>
|
|
#include <linux/dlm_netlink.h>
|
|
#include <linux/gfp.h>
|
|
|
|
#include "dlm_internal.h"
|
|
|
|
static uint32_t dlm_nl_seqnum;
|
|
static uint32_t listener_nlportid;
|
|
|
|
static struct genl_family family;
|
|
|
|
static int prepare_data(u8 cmd, struct sk_buff **skbp, size_t size)
|
|
{
|
|
struct sk_buff *skb;
|
|
void *data;
|
|
|
|
skb = genlmsg_new(size, GFP_NOFS);
|
|
if (!skb)
|
|
return -ENOMEM;
|
|
|
|
/* add the message headers */
|
|
data = genlmsg_put(skb, 0, dlm_nl_seqnum++, &family, 0, cmd);
|
|
if (!data) {
|
|
nlmsg_free(skb);
|
|
return -EINVAL;
|
|
}
|
|
|
|
*skbp = skb;
|
|
return 0;
|
|
}
|
|
|
|
static struct dlm_lock_data *mk_data(struct sk_buff *skb)
|
|
{
|
|
struct nlattr *ret;
|
|
|
|
ret = nla_reserve(skb, DLM_TYPE_LOCK, sizeof(struct dlm_lock_data));
|
|
if (!ret)
|
|
return NULL;
|
|
return nla_data(ret);
|
|
}
|
|
|
|
static int send_data(struct sk_buff *skb)
|
|
{
|
|
struct genlmsghdr *genlhdr = nlmsg_data((struct nlmsghdr *)skb->data);
|
|
void *data = genlmsg_data(genlhdr);
|
|
|
|
genlmsg_end(skb, data);
|
|
|
|
return genlmsg_unicast(&init_net, skb, listener_nlportid);
|
|
}
|
|
|
|
static int user_cmd(struct sk_buff *skb, struct genl_info *info)
|
|
{
|
|
listener_nlportid = info->snd_portid;
|
|
printk("user_cmd nlpid %u\n", listener_nlportid);
|
|
return 0;
|
|
}
|
|
|
|
static const struct genl_ops dlm_nl_ops[] = {
|
|
{
|
|
.cmd = DLM_CMD_HELLO,
|
|
.validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP,
|
|
.doit = user_cmd,
|
|
},
|
|
};
|
|
|
|
static struct genl_family family __ro_after_init = {
|
|
.name = DLM_GENL_NAME,
|
|
.version = DLM_GENL_VERSION,
|
|
.ops = dlm_nl_ops,
|
|
.n_ops = ARRAY_SIZE(dlm_nl_ops),
|
|
.module = THIS_MODULE,
|
|
};
|
|
|
|
int __init dlm_netlink_init(void)
|
|
{
|
|
return genl_register_family(&family);
|
|
}
|
|
|
|
void dlm_netlink_exit(void)
|
|
{
|
|
genl_unregister_family(&family);
|
|
}
|
|
|
|
static void fill_data(struct dlm_lock_data *data, struct dlm_lkb *lkb)
|
|
{
|
|
struct dlm_rsb *r = lkb->lkb_resource;
|
|
|
|
memset(data, 0, sizeof(struct dlm_lock_data));
|
|
|
|
data->version = DLM_LOCK_DATA_VERSION;
|
|
data->nodeid = lkb->lkb_nodeid;
|
|
data->ownpid = lkb->lkb_ownpid;
|
|
data->id = lkb->lkb_id;
|
|
data->remid = lkb->lkb_remid;
|
|
data->status = lkb->lkb_status;
|
|
data->grmode = lkb->lkb_grmode;
|
|
data->rqmode = lkb->lkb_rqmode;
|
|
if (lkb->lkb_ua)
|
|
data->xid = lkb->lkb_ua->xid;
|
|
if (r) {
|
|
data->lockspace_id = r->res_ls->ls_global_id;
|
|
data->resource_namelen = r->res_length;
|
|
memcpy(data->resource_name, r->res_name, r->res_length);
|
|
}
|
|
}
|
|
|
|
void dlm_timeout_warn(struct dlm_lkb *lkb)
|
|
{
|
|
struct sk_buff *send_skb;
|
|
struct dlm_lock_data *data;
|
|
size_t size;
|
|
int rv;
|
|
|
|
size = nla_total_size(sizeof(struct dlm_lock_data)) +
|
|
nla_total_size(0); /* why this? */
|
|
|
|
rv = prepare_data(DLM_CMD_TIMEOUT, &send_skb, size);
|
|
if (rv < 0)
|
|
return;
|
|
|
|
data = mk_data(send_skb);
|
|
if (!data) {
|
|
nlmsg_free(send_skb);
|
|
return;
|
|
}
|
|
|
|
fill_data(data, lkb);
|
|
|
|
send_data(send_skb);
|
|
}
|
|
|