Adalbert Lazăr 4c404ce233 vsock/virtio: fix kernel panic from virtio_transport_reset_no_sock ... Previous to commit 22b5c0b63f ("vsock/virtio: fix kernel panic after device hot-unplug"), vsock_core_init() was called from virtio_vsock_probe(). Now, virtio_transport_reset_no_sock() can be called before vsock_core_init() has the chance to run. [Wed Feb 27 14:17:09 2019] BUG: unable to handle kernel NULL pointer dereference at 0000000000000110 [Wed Feb 27 14:17:09 2019] #PF error: [normal kernel read fault] [Wed Feb 27 14:17:09 2019] PGD 0 P4D 0 [Wed Feb 27 14:17:09 2019] Oops: 0000 [#1] SMP PTI [Wed Feb 27 14:17:09 2019] CPU: 3 PID: 59 Comm: kworker/3:1 Not tainted 5.0.0-rc7-390-generic-hvi #390 [Wed Feb 27 14:17:09 2019] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Ubuntu-1.8.2-1ubuntu1 04/01/2014 [Wed Feb 27 14:17:09 2019] Workqueue: virtio_vsock virtio_transport_rx_work [vmw_vsock_virtio_transport] [Wed Feb 27 14:17:09 2019] RIP: 0010:virtio_transport_reset_no_sock+0x8c/0xc0 [vmw_vsock_virtio_transport_common] [Wed Feb 27 14:17:09 2019] Code: 35 8b 4f 14 48 8b 57 08 31 f6 44 8b 4f 10 44 8b 07 48 8d 7d c8 e8 84 f8 ff ff 48 85 c0 48 89 c3 74 2a e8 f7 31 03 00 48 89 df <48> 8b 80 10 01 00 00 e8 68 fb 69 ed 48 8b 75 f0 65 48 33 34 25 28 [Wed Feb 27 14:17:09 2019] RSP: 0018:ffffb42701ab7d40 EFLAGS: 00010282 [Wed Feb 27 14:17:09 2019] RAX: 0000000000000000 RBX: ffff9d79637ee080 RCX: 0000000000000003 [Wed Feb 27 14:17:09 2019] RDX: 0000000000000001 RSI: 0000000000000002 RDI: ffff9d79637ee080 [Wed Feb 27 14:17:09 2019] RBP: ffffb42701ab7d78 R08: ffff9d796fae70e0 R09: ffff9d796f403500 [Wed Feb 27 14:17:09 2019] R10: ffffb42701ab7d90 R11: 0000000000000000 R12: ffff9d7969d09240 [Wed Feb 27 14:17:09 2019] R13: ffff9d79624e6840 R14: ffff9d7969d09318 R15: ffff9d796d48ff80 [Wed Feb 27 14:17:09 2019] FS: 0000000000000000(0000) GS:ffff9d796fac0000(0000) knlGS:0000000000000000 [Wed Feb 27 14:17:09 2019] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [Wed Feb 27 14:17:09 2019] CR2: 0000000000000110 CR3: 0000000427f22000 CR4: 00000000000006e0 [Wed Feb 27 14:17:09 2019] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [Wed Feb 27 14:17:09 2019] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [Wed Feb 27 14:17:09 2019] Call Trace: [Wed Feb 27 14:17:09 2019] virtio_transport_recv_pkt+0x63/0x820 [vmw_vsock_virtio_transport_common] [Wed Feb 27 14:17:09 2019] ? kfree+0x17e/0x190 [Wed Feb 27 14:17:09 2019] ? detach_buf_split+0x145/0x160 [Wed Feb 27 14:17:09 2019] ? __switch_to_asm+0x40/0x70 [Wed Feb 27 14:17:09 2019] virtio_transport_rx_work+0xa0/0x106 [vmw_vsock_virtio_transport] [Wed Feb 27 14:17:09 2019] NET: Registered protocol family 40 [Wed Feb 27 14:17:09 2019] process_one_work+0x167/0x410 [Wed Feb 27 14:17:09 2019] worker_thread+0x4d/0x460 [Wed Feb 27 14:17:09 2019] kthread+0x105/0x140 [Wed Feb 27 14:17:09 2019] ? rescuer_thread+0x360/0x360 [Wed Feb 27 14:17:09 2019] ? kthread_destroy_worker+0x50/0x50 [Wed Feb 27 14:17:09 2019] ret_from_fork+0x35/0x40 [Wed Feb 27 14:17:09 2019] Modules linked in: vmw_vsock_virtio_transport vmw_vsock_virtio_transport_common input_leds vsock serio_raw i2c_piix4 mac_hid qemu_fw_cfg autofs4 cirrus ttm drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops virtio_net psmouse drm net_failover pata_acpi virtio_blk failover floppy Fixes: 22b5c0b63f ("vsock/virtio: fix kernel panic after device hot-unplug") Reported-by: Alexandru Herghelegiu <aherghelegiu@bitdefender.com> Signed-off-by: Adalbert Lazăr <alazar@bitdefender.com> Co-developed-by: Stefan Hajnoczi <stefanha@redhat.com> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Reviewed-by: Stefano Garzarella <sgarzare@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2019-03-08 15:15:44 -08:00
..
6lowpan
9p
802
8021q
appletalk	appletalk: Fix use-after-free in atalk_proc_exit	2019-03-03 13:01:49 -08:00
atm	net: atm: Add another IS_ENABLED(CONFIG_COMPAT) in atm_dev_ioctl	2019-03-07 10:14:50 -08:00
ax25
batman-adv
bluetooth	Bluetooth: Add quirk for reading BD_ADDR from fwnode property	2019-02-26 10:08:26 +01:00
bpf	Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next	2019-03-04 10:14:31 -08:00
bpfilter
bridge	Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next	2019-03-02 14:01:04 -08:00
caif
can
ceph
core	ethtool: reduce stack usage with clang	2019-03-07 09:45:21 -08:00
dcb
dccp
decnet
dns_resolver
dsa	net: dsa: Use prepare/commit phase in dsa_slave_vlan_rx_add_vid()	2019-03-03 20:45:52 -08:00
ethernet
hsr	net/hsr: fix possible crash in add_timer()	2019-03-07 11:02:08 -08:00
ieee802154	net: remove unused struct inet_frag_queue.fragments field	2019-02-26 08:27:05 -08:00
ife
ipv4	route: set the deleted fnhe fnhe_daddr to 0 in ip_del_fnhe to fix a race	2019-03-08 10:50:34 -08:00
ipv6	net: ignore sysctl_devconf_inherit_init_net without SYSCTL	2019-03-04 13:14:34 -08:00
iucv
kcm
key
l2tp
l3mdev
lapb
llc
mac80211
mac802154
mpls	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-03-02 12:54:35 -08:00
ncsi
netfilter	netfilter: nf_tables: merge ipv4 and ipv6 nat chain types	2019-03-01 14:36:59 +01:00
netlabel	netlabel: fix out-of-bounds memory accesses	2019-02-27 21:45:24 -08:00
netlink
netrom
nfc	net: nfc: Fix NULL dereference on nfc_llcp_build_tlv fails	2019-02-27 12:47:08 -08:00
nsh
openvswitch	netfilter: nat: remove nf_nat_l3proto.h and nf_nat_core.h	2019-02-27 10:54:08 +01:00
packet
phonet
psample
qrtr
rds
rfkill
rose
rxrpc	rxrpc: Fix client call connect/disconnect race	2019-03-08 11:26:16 -08:00
sched	net: sched: flower: insert new filter to idr after setting its mask	2019-03-06 10:52:16 -08:00
sctp	sctp: call sctp_auth_init_hmacs() in sctp_sock_migrate()	2019-03-08 11:42:49 -08:00
smc	net/smc: allow pnetid-less configuration	2019-02-28 12:49:44 -08:00
strparser
sunrpc
switchdev	switchdev: Remove unused transaction item queue	2019-03-01 21:35:19 -08:00
tipc	tipc: fix RDM/DGRAM connect() regression	2019-03-05 12:49:13 -08:00
tls	tls: Fix tls_device receive	2019-03-03 22:10:16 -08:00
unix
vmw_vsock	vsock/virtio: fix kernel panic from virtio_transport_reset_no_sock	2019-03-08 15:15:44 -08:00
wimax
wireless
x25
xdp
xfrm
compat.c	net: fixup address-space warnings in compat_mc_{get,set}sockopt()	2019-03-03 20:58:25 -08:00
Kconfig	net: devlink: turn devlink into a built-in	2019-02-26 08:49:05 -08:00
Makefile
socket.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-03-02 12:54:35 -08:00
sysctl_net.c