Parav Pandit 4be3a4fa51 IB/core: Fix kernel crash during fail to initialize device ... This patch fixes the kernel crash that occurs during ib_dealloc_device() called due to provider driver fails with an error after ib_alloc_device() and before it can register using ib_register_device(). This crashed seen in tha lab as below which can occur with any IB device which fails to perform its device initialization before invoking ib_register_device(). This patch avoids touching cache and port immutable structures if device is not yet initialized. It also releases related memory when cache and port immutable data structure initialization fails during register_device() state. [81416.561946] BUG: unable to handle kernel NULL pointer dereference at (null) [81416.570340] IP: ib_cache_release_one+0x29/0x80 [ib_core] [81416.576222] PGD 78da66067 [81416.576223] PUD 7f2d7c067 [81416.579484] PMD 0 [81416.582720] [81416.587242] Oops: 0000 [#1] SMP [81416.722395] task: ffff8807887515c0 task.stack: ffffc900062c0000 [81416.729148] RIP: 0010:ib_cache_release_one+0x29/0x80 [ib_core] [81416.735793] RSP: 0018:ffffc900062c3a90 EFLAGS: 00010202 [81416.741823] RAX: 0000000000000000 RBX: 0000000000000001 RCX: 0000000000000000 [81416.749785] RDX: 0000000000000000 RSI: 0000000000000282 RDI: ffff880859fec000 [81416.757757] RBP: ffffc900062c3aa0 R08: ffff8808536e5ac0 R09: ffff880859fec5b0 [81416.765708] R10: 00000000536e5c01 R11: ffff8808536e5ac0 R12: ffff880859fec000 [81416.773672] R13: 0000000000000000 R14: ffff8808536e5ac0 R15: ffff88084ebc0060 [81416.781621] FS: 00007fd879fab740(0000) GS:ffff88085fac0000(0000) knlGS:0000000000000000 [81416.790522] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [81416.797094] CR2: 0000000000000000 CR3: 00000007eb215000 CR4: 00000000003406e0 [81416.805051] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [81416.812997] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [81416.820950] Call Trace: [81416.824226] ib_device_release+0x1e/0x40 [ib_core] [81416.829858] device_release+0x32/0xa0 [81416.834370] kobject_cleanup+0x63/0x170 [81416.839058] kobject_put+0x25/0x50 [81416.843319] ib_dealloc_device+0x25/0x40 [ib_core] [81416.848986] mlx5_ib_add+0x163/0x1990 [mlx5_ib] [81416.854414] mlx5_add_device+0x5a/0x160 [mlx5_core] [81416.860191] mlx5_register_interface+0x8d/0xc0 [mlx5_core] [81416.866587] ? 0xffffffffa09e9000 [81416.870816] mlx5_ib_init+0x15/0x17 [mlx5_ib] [81416.876094] do_one_initcall+0x51/0x1b0 [81416.880861] ? __vunmap+0x85/0xd0 [81416.885113] ? kmem_cache_alloc_trace+0x14b/0x1b0 [81416.890768] ? vfree+0x2e/0x70 [81416.894762] do_init_module+0x60/0x1fa [81416.899441] load_module+0x15f6/0x1af0 [81416.904114] ? __symbol_put+0x60/0x60 [81416.908709] ? ima_post_read_file+0x3d/0x80 [81416.913828] ? security_kernel_post_read_file+0x6b/0x80 [81416.920006] SYSC_finit_module+0xa6/0xf0 [81416.924888] SyS_finit_module+0xe/0x10 [81416.929568] entry_SYSCALL_64_fastpath+0x1a/0xa9 [81416.935089] RIP: 0033:0x7fd879494949 [81416.939543] RSP: 002b:00007ffdbc1b4e58 EFLAGS: 00000202 ORIG_RAX: 0000000000000139 [81416.947982] RAX: ffffffffffffffda RBX: 0000000001b66f00 RCX: 00007fd879494949 [81416.955965] RDX: 0000000000000000 RSI: 000000000041a13c RDI: 0000000000000003 [81416.963926] RBP: 0000000000000003 R08: 0000000000000000 R09: 0000000001b652a0 [81416.971861] R10: 0000000000000003 R11: 0000000000000202 R12: 00007ffdbc1b3e70 [81416.979763] R13: 00007ffdbc1b3e50 R14: 0000000000000005 R15: 0000000000000000 [81417.008005] RIP: ib_cache_release_one+0x29/0x80 [ib_core] RSP: ffffc900062c3a90 [81417.016045] CR2: 0000000000000000 Fixes: 55aeed0654 ("IB/core: Make ib_alloc_device init the kobject") Fixes: 7738613e7c ("IB/core: Add per port immutable struct to ib_device") Cc: <stable@vger.kernel.org> # v4.2+ Reviewed-by: Daniel Jurgens <danielj@mellanox.com> Signed-off-by: Parav Pandit <parav@mellanox.com> Signed-off-by: Leon Romanovsky <leon@kernel.org> Signed-off-by: Doug Ledford <dledford@redhat.com>		2017-04-21 12:26:05 -04:00
..
addr.c	netlink: pass extended ACK struct to parsing functions	2017-04-13 13:58:22 -04:00
agent.c	IB/core: Remove debug prints after allocation failure	2016-12-03 13:12:52 -05:00
agent.h	IB/mad: Add final OPA MAD processing	2015-06-12 14:49:18 -04:00
cache.c	IB/core: Add inline function to validate port	2017-01-27 14:33:59 -05:00
cgroup.c	IB/core: added support to use rdma cgroup controller	2017-01-10 11:14:27 -05:00
cm_msgs.h	IB/core: Fix unaligned accesses	2015-05-05 13:21:27 -04:00
cm.c	IB/cma: Add debug messages to error flows	2017-01-24 16:20:37 -05:00
cma_configfs.c	IB/cma: Add default RoCE TOS to CMA configfs	2017-02-15 09:51:28 -05:00
cma.c	First set of updates for 4.11 kernel merge window	2017-02-23 08:27:57 -08:00
core_priv.h	Merge branch 'for-4.11' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup	2017-02-27 21:41:08 -08:00
cq.c	IB/cq: Don't process more than the given budget	2017-03-24 22:19:48 -04:00
device.c	IB/core: Fix kernel crash during fail to initialize device	2017-04-21 12:26:05 -04:00
fmr_pool.c	IB/core: Remove debug prints after allocation failure	2016-12-03 13:12:52 -05:00
iwcm.c	rdma_cm: add rdma_reject_msg() helper function	2016-12-14 11:38:28 -05:00
iwcm.h	iw_cm: free cm_id resources on the last deref	2016-08-02 13:15:18 -04:00
iwpm_msg.c	IB/core: Remove debug prints after allocation failure	2016-12-03 13:12:52 -05:00
iwpm_util.c	netlink: pass extended ACK struct to parsing functions	2017-04-13 13:58:22 -04:00
iwpm_util.h	iwpm: crash fix for large connections test	2016-03-16 13:48:32 -04:00
mad_priv.h	IB/mad: use CQ abstraction	2016-01-19 15:25:45 -05:00
mad_rmpp.c	IB/mad: Add final OPA MAD processing	2015-06-12 14:49:18 -04:00
mad_rmpp.h	RDMA: Remove subversion $Id tags	2008-07-14 23:48:44 -07:00
mad.c	IB/mad: Add port_num to error message	2017-01-24 14:20:42 -05:00
Makefile	IB/core: Add idr based standard types	2017-04-05 13:28:04 -04:00
mr_pool.c	IB/core: add a simple MR pool	2016-05-13 13:37:18 -04:00
multicast.c	IB/multicast: Check ib_find_pkey() return value	2016-12-14 13:27:34 -05:00
netlink.c	netlink: extended ACK reporting	2017-04-13 13:58:20 -04:00
opa_smi.h	IB: Add rdma_cap_ib_switch helper and use where appropriate	2015-07-14 13:20:08 -04:00
packer.c	IB/core: trivial prink cleanup.	2016-03-03 10:20:25 -05:00
rdma_core.c	IB/core: Nullify ib_uobject during allocation	2017-04-20 11:44:07 -04:00
rdma_core.h	IB/core: Add support for fd objects	2017-04-05 13:28:04 -04:00
roce_gid_mgmt.c	IB/core: Remove pointer casting from void to net_device	2017-02-15 09:51:28 -05:00
rw.c	IB/core, RDMA RW API: Do not exceed QP SGE send limit	2016-08-02 12:02:41 -04:00
sa_query.c	netlink: pass extended ACK struct to parsing functions	2017-04-13 13:58:22 -04:00
sa.h	IB: Remove garbage non-ASCII characters from comments	2007-07-09 16:17:32 -07:00
smi.c	IB: Add rdma_cap_ib_switch helper and use where appropriate	2015-07-14 13:20:08 -04:00
smi.h	IB: Add rdma_cap_ib_switch helper and use where appropriate	2015-07-14 13:20:08 -04:00
sysfs.c	IB/core: Initialize ib_device.dev.parent earlier	2017-01-24 12:23:35 -05:00
ucm.c	IB/core: Use dev.parent instead of dma_device	2017-01-24 12:23:35 -05:00
ucma.c	infiniband: remove WARN that is not kernel bug	2016-12-03 13:17:07 -05:00
ud_header.c	IB/core: trivial prink cleanup.	2016-03-03 10:20:25 -05:00
umem_odp.c	sched/headers: Prepare to move the get_task_struct()/put_task_struct() and related APIs from <linux/sched.h> to <linux/sched/task.h>	2017-03-02 08:42:40 +01:00
umem_rbtree.c	IB/umem: Update on demand page (ODP) support	2017-02-14 11:41:17 -05:00
umem.c	sched/headers: Prepare for new header dependencies before moving code to <linux/sched/signal.h>	2017-03-02 08:42:29 +01:00
user_mad.c	IB/core: Use dev.parent instead of dma_device	2017-01-24 12:23:35 -05:00
uverbs_cmd.c	IB/core: Rename uverbs event file structure	2017-04-20 11:44:07 -04:00
uverbs_main.c	IB/core: Rename uverbs event file structure	2017-04-20 11:44:07 -04:00
uverbs_marshall.c	IB/core: Add gid_type to gid attribute	2015-12-23 10:35:10 -05:00
uverbs_std_types.c	IB/core: Rename uverbs event file structure	2017-04-20 11:44:07 -04:00
uverbs.h	IB/core: Rename uverbs event file structure	2017-04-20 11:44:07 -04:00
verbs.c	IB/core: Add support for draining IB_POLL_DIRECT completion queues	2017-02-19 09:51:55 -05:00