Hans de Goede 4bcdec39c4 ASoC: Intel: cht_bsw_max98090_ti: Enable codec clock once and keep it enabled ... Users have been seeing sound stability issues with max98090 codecs since: commit 648e921888 ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL") At first that commit broke sound for Chromebook Swanky and Clapper models, the problem was that the machine-driver has been controlling the wrong clock on those models since support for them was added. This was hidden by clk-pmc-atom.c keeping the actual clk on unconditionally. With the machine-driver controlling the proper clock, sound works again but we are seeing bug reports describing it as: low volume, "sounds like played at 10x speed" and instable. When these issues are hit the following message is seen in dmesg: "max98090 i2c-193C9890:00: PLL unlocked". Attempts have been made to fix this by inserting a delay between enabling the clk and enabling and checking the pll, but this has not helped. It seems that at least on boards which use pmc_plt_clk_0 as clock, if we ever disable the clk, the pll looses its lock and after that we get various issues. This commit fixes this by enabling the clock once at probe time on these boards. In essence this restores the old behavior of clk-pmc-atom.c always keeping the clk on on these boards. Fixes: 648e921888 ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL") Reported-by: Mogens Jensen <mogens-jensen@protonmail.com> Reported-by: Dean Wallace <duffydack73@gmail.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com> Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Signed-off-by: Mark Brown <broonie@kernel.org>		2019-04-03 11:37:10 +07:00
..
atom	ASoC: intel: Fix crash at suspend/resume after failed codec registration	2019-03-25 12:09:13 +00:00
baytrail	ASoC: Updates for v5.1	2019-02-08 14:20:32 +01:00
boards	ASoC: Intel: cht_bsw_max98090_ti: Enable codec clock once and keep it enabled	2019-04-03 11:37:10 +07:00
common	ASoC: Intel: Boards: Add Maxim98373 support	2019-02-26 11:45:36 +00:00
haswell	ASoC: Updates for v5.1	2019-02-08 14:20:32 +01:00
skylake	ASoC: Intel: Skylake: enable S24_LE format support	2019-03-26 13:24:26 +00:00
Kconfig	ASoC: Intel: atom: Make PCI dependency explicit	2019-01-03 16:33:22 +00:00
Makefile	ASoC: Intel: Fix Kconfig with top-level selector	2018-01-08 16:18:48 +00:00