mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-18 12:47:02 +07:00
9345005f4e
During heavy CPU-hotplug operations the following spurious kernel warnings can trigger: do_IRQ: No ... irq handler for vector (irq -1) [ See: https://bugzilla.kernel.org/show_bug.cgi?id=64831 ] When downing a cpu it is possible that there are unhandled irqs left in the APIC IRR register. The following code path shows how the problem can occur: 1. CPU 5 is to go down. 2. cpu_disable() on CPU 5 executes with interrupt flag cleared by local_irq_save() via stop_machine(). 3. IRQ 12 asserts on CPU 5, setting IRR but not ISR because interrupt flag is cleared (CPU unabled to handle the irq) 4. IRQs are migrated off of CPU 5, and the vectors' irqs are set to -1. 5. stop_machine() finishes cpu_disable() 6. cpu_die() for CPU 5 executes in normal context. 7. CPU 5 attempts to handle IRQ 12 because the IRR is set for IRQ 12. The code attempts to find the vector's IRQ and cannot because it has been set to -1. 8. do_IRQ() warning displays warning about CPU 5 IRQ 12. I added a debug printk to output which CPU & vector was retriggered and discovered that that we are getting bogus events. I see a 100% correlation between this debug printk in fixup_irqs() and the do_IRQ() warning. This patchset resolves this by adding definitions for VECTOR_UNDEFINED(-1) and VECTOR_RETRIGGERED(-2) and modifying the code to use them. Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=64831 Signed-off-by: Prarit Bhargava <prarit@redhat.com> Reviewed-by: Rui Wang <rui.y.wang@intel.com> Cc: Michel Lespinasse <walken@google.com> Cc: Seiji Aguchi <seiji.aguchi@hds.com> Cc: Yang Zhang <yang.z.zhang@Intel.com> Cc: Paul Gortmaker <paul.gortmaker@windriver.com> Cc: janet.morgan@Intel.com Cc: tony.luck@Intel.com Cc: ruiv.wang@gmail.com Link: http://lkml.kernel.org/r/1388938252-16627-1-git-send-email-prarit@redhat.com [ Cleaned up the code a bit. ] Signed-off-by: Ingo Molnar <mingo@kernel.org>
214 lines
6.7 KiB
C
214 lines
6.7 KiB
C
#ifndef _ASM_X86_HW_IRQ_H
|
|
#define _ASM_X86_HW_IRQ_H
|
|
|
|
/*
|
|
* (C) 1992, 1993 Linus Torvalds, (C) 1997 Ingo Molnar
|
|
*
|
|
* moved some of the old arch/i386/kernel/irq.h to here. VY
|
|
*
|
|
* IRQ/IPI changes taken from work by Thomas Radke
|
|
* <tomsoft@informatik.tu-chemnitz.de>
|
|
*
|
|
* hacked by Andi Kleen for x86-64.
|
|
* unified by tglx
|
|
*/
|
|
|
|
#include <asm/irq_vectors.h>
|
|
|
|
#ifndef __ASSEMBLY__
|
|
|
|
#include <linux/percpu.h>
|
|
#include <linux/profile.h>
|
|
#include <linux/smp.h>
|
|
|
|
#include <linux/atomic.h>
|
|
#include <asm/irq.h>
|
|
#include <asm/sections.h>
|
|
|
|
/* Interrupt handlers registered during init_IRQ */
|
|
extern asmlinkage void apic_timer_interrupt(void);
|
|
extern asmlinkage void x86_platform_ipi(void);
|
|
extern asmlinkage void kvm_posted_intr_ipi(void);
|
|
extern asmlinkage void error_interrupt(void);
|
|
extern asmlinkage void irq_work_interrupt(void);
|
|
|
|
extern asmlinkage void spurious_interrupt(void);
|
|
extern asmlinkage void thermal_interrupt(void);
|
|
extern asmlinkage void reschedule_interrupt(void);
|
|
|
|
extern asmlinkage void invalidate_interrupt(void);
|
|
extern asmlinkage void invalidate_interrupt0(void);
|
|
extern asmlinkage void invalidate_interrupt1(void);
|
|
extern asmlinkage void invalidate_interrupt2(void);
|
|
extern asmlinkage void invalidate_interrupt3(void);
|
|
extern asmlinkage void invalidate_interrupt4(void);
|
|
extern asmlinkage void invalidate_interrupt5(void);
|
|
extern asmlinkage void invalidate_interrupt6(void);
|
|
extern asmlinkage void invalidate_interrupt7(void);
|
|
extern asmlinkage void invalidate_interrupt8(void);
|
|
extern asmlinkage void invalidate_interrupt9(void);
|
|
extern asmlinkage void invalidate_interrupt10(void);
|
|
extern asmlinkage void invalidate_interrupt11(void);
|
|
extern asmlinkage void invalidate_interrupt12(void);
|
|
extern asmlinkage void invalidate_interrupt13(void);
|
|
extern asmlinkage void invalidate_interrupt14(void);
|
|
extern asmlinkage void invalidate_interrupt15(void);
|
|
extern asmlinkage void invalidate_interrupt16(void);
|
|
extern asmlinkage void invalidate_interrupt17(void);
|
|
extern asmlinkage void invalidate_interrupt18(void);
|
|
extern asmlinkage void invalidate_interrupt19(void);
|
|
extern asmlinkage void invalidate_interrupt20(void);
|
|
extern asmlinkage void invalidate_interrupt21(void);
|
|
extern asmlinkage void invalidate_interrupt22(void);
|
|
extern asmlinkage void invalidate_interrupt23(void);
|
|
extern asmlinkage void invalidate_interrupt24(void);
|
|
extern asmlinkage void invalidate_interrupt25(void);
|
|
extern asmlinkage void invalidate_interrupt26(void);
|
|
extern asmlinkage void invalidate_interrupt27(void);
|
|
extern asmlinkage void invalidate_interrupt28(void);
|
|
extern asmlinkage void invalidate_interrupt29(void);
|
|
extern asmlinkage void invalidate_interrupt30(void);
|
|
extern asmlinkage void invalidate_interrupt31(void);
|
|
|
|
extern asmlinkage void irq_move_cleanup_interrupt(void);
|
|
extern asmlinkage void reboot_interrupt(void);
|
|
extern asmlinkage void threshold_interrupt(void);
|
|
|
|
extern asmlinkage void call_function_interrupt(void);
|
|
extern asmlinkage void call_function_single_interrupt(void);
|
|
|
|
#ifdef CONFIG_TRACING
|
|
/* Interrupt handlers registered during init_IRQ */
|
|
extern void trace_apic_timer_interrupt(void);
|
|
extern void trace_x86_platform_ipi(void);
|
|
extern void trace_error_interrupt(void);
|
|
extern void trace_irq_work_interrupt(void);
|
|
extern void trace_spurious_interrupt(void);
|
|
extern void trace_thermal_interrupt(void);
|
|
extern void trace_reschedule_interrupt(void);
|
|
extern void trace_threshold_interrupt(void);
|
|
extern void trace_call_function_interrupt(void);
|
|
extern void trace_call_function_single_interrupt(void);
|
|
#define trace_irq_move_cleanup_interrupt irq_move_cleanup_interrupt
|
|
#define trace_reboot_interrupt reboot_interrupt
|
|
#define trace_kvm_posted_intr_ipi kvm_posted_intr_ipi
|
|
#endif /* CONFIG_TRACING */
|
|
|
|
/* IOAPIC */
|
|
#define IO_APIC_IRQ(x) (((x) >= NR_IRQS_LEGACY) || ((1<<(x)) & io_apic_irqs))
|
|
extern unsigned long io_apic_irqs;
|
|
|
|
extern void init_VISWS_APIC_irqs(void);
|
|
extern void setup_IO_APIC(void);
|
|
extern void disable_IO_APIC(void);
|
|
|
|
struct io_apic_irq_attr {
|
|
int ioapic;
|
|
int ioapic_pin;
|
|
int trigger;
|
|
int polarity;
|
|
};
|
|
|
|
static inline void set_io_apic_irq_attr(struct io_apic_irq_attr *irq_attr,
|
|
int ioapic, int ioapic_pin,
|
|
int trigger, int polarity)
|
|
{
|
|
irq_attr->ioapic = ioapic;
|
|
irq_attr->ioapic_pin = ioapic_pin;
|
|
irq_attr->trigger = trigger;
|
|
irq_attr->polarity = polarity;
|
|
}
|
|
|
|
/* Intel specific interrupt remapping information */
|
|
struct irq_2_iommu {
|
|
struct intel_iommu *iommu;
|
|
u16 irte_index;
|
|
u16 sub_handle;
|
|
u8 irte_mask;
|
|
};
|
|
|
|
/* AMD specific interrupt remapping information */
|
|
struct irq_2_irte {
|
|
u16 devid; /* Device ID for IRTE table */
|
|
u16 index; /* Index into IRTE table*/
|
|
};
|
|
|
|
/*
|
|
* This is performance-critical, we want to do it O(1)
|
|
*
|
|
* Most irqs are mapped 1:1 with pins.
|
|
*/
|
|
struct irq_cfg {
|
|
struct irq_pin_list *irq_2_pin;
|
|
cpumask_var_t domain;
|
|
cpumask_var_t old_domain;
|
|
u8 vector;
|
|
u8 move_in_progress : 1;
|
|
#ifdef CONFIG_IRQ_REMAP
|
|
u8 remapped : 1;
|
|
union {
|
|
struct irq_2_iommu irq_2_iommu;
|
|
struct irq_2_irte irq_2_irte;
|
|
};
|
|
#endif
|
|
};
|
|
|
|
extern int assign_irq_vector(int, struct irq_cfg *, const struct cpumask *);
|
|
extern void send_cleanup_vector(struct irq_cfg *);
|
|
|
|
struct irq_data;
|
|
int __ioapic_set_affinity(struct irq_data *, const struct cpumask *,
|
|
unsigned int *dest_id);
|
|
extern int IO_APIC_get_PCI_irq_vector(int bus, int devfn, int pin, struct io_apic_irq_attr *irq_attr);
|
|
extern void setup_ioapic_dest(void);
|
|
|
|
extern void enable_IO_APIC(void);
|
|
|
|
/* Statistics */
|
|
extern atomic_t irq_err_count;
|
|
extern atomic_t irq_mis_count;
|
|
|
|
/* EISA */
|
|
extern void eisa_set_level_irq(unsigned int irq);
|
|
|
|
/* SMP */
|
|
extern __visible void smp_apic_timer_interrupt(struct pt_regs *);
|
|
extern __visible void smp_spurious_interrupt(struct pt_regs *);
|
|
extern __visible void smp_x86_platform_ipi(struct pt_regs *);
|
|
extern __visible void smp_error_interrupt(struct pt_regs *);
|
|
#ifdef CONFIG_X86_IO_APIC
|
|
extern asmlinkage void smp_irq_move_cleanup_interrupt(void);
|
|
#endif
|
|
#ifdef CONFIG_SMP
|
|
extern __visible void smp_reschedule_interrupt(struct pt_regs *);
|
|
extern __visible void smp_call_function_interrupt(struct pt_regs *);
|
|
extern __visible void smp_call_function_single_interrupt(struct pt_regs *);
|
|
extern __visible void smp_invalidate_interrupt(struct pt_regs *);
|
|
#endif
|
|
|
|
extern void (*__initconst interrupt[NR_VECTORS-FIRST_EXTERNAL_VECTOR])(void);
|
|
#ifdef CONFIG_TRACING
|
|
#define trace_interrupt interrupt
|
|
#endif
|
|
|
|
#define VECTOR_UNDEFINED -1
|
|
#define VECTOR_RETRIGGERED -2
|
|
|
|
typedef int vector_irq_t[NR_VECTORS];
|
|
DECLARE_PER_CPU(vector_irq_t, vector_irq);
|
|
extern void setup_vector_irq(int cpu);
|
|
|
|
#ifdef CONFIG_X86_IO_APIC
|
|
extern void lock_vector_lock(void);
|
|
extern void unlock_vector_lock(void);
|
|
extern void __setup_vector_irq(int cpu);
|
|
#else
|
|
static inline void lock_vector_lock(void) {}
|
|
static inline void unlock_vector_lock(void) {}
|
|
static inline void __setup_vector_irq(int cpu) {}
|
|
#endif
|
|
|
|
#endif /* !ASSEMBLY_ */
|
|
|
|
#endif /* _ASM_X86_HW_IRQ_H */
|