mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2025-01-15 23:56:55 +07:00
0da2dbd602
the following script:
# tc qdisc add dev crash0 clsact
# tc filter add dev crash0 egress matchall \
> action gact pass index 90
# tc actions replace action gact \
> goto chain 42 index 90 cookie c1a0c1a0
# tc actions show action gact
had the following output:
Error: Failed to init TC action chain.
We have an error talking to the kernel
total acts 1
action order 0: gact action goto chain 42
random type none pass val 0
index 90 ref 2 bind 1
cookie c1a0c1a0
Then, the first packet transmitted by crash0 made the kernel crash:
BUG: unable to handle kernel NULL pointer dereference at 0000000000000000
#PF error: [normal kernel read fault]
PGD 0 P4D 0
Oops: 0000 [#1] SMP PTI
CPU: 2 PID: 0 Comm: swapper/2 Not tainted 5.0.0-rc4.gotochain_crash+ #533
Hardware name: Red Hat KVM, BIOS 0.5.1 01/01/2011
RIP: 0010:tcf_action_exec+0xb8/0x100
Code: 00 00 00 20 74 1d 83 f8 03 75 09 49 83 c4 08 4d 39 ec 75 bc 48 83 c4 10 5b 5d 41 5c 41 5d 41 5e 41 5f c3 49 8b 97 a8 00 00 00 <48> 8b 12 48 89 55 00 48 83 c4 10 5b 5d 41 5c 41 5d 41 5e 41 5f c3
RSP: 0018:ffff8c2434703be0 EFLAGS: 00010246
RAX: 000000002000002a RBX: ffff8c23ed6d7e00 RCX: 000000000000005a
RDX: 0000000000000000 RSI: 0000000000000001 RDI: ffff8c23ed6d7e00
RBP: ffff8c2434703c80 R08: ffff8c243b639ac8 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000000 R12: ffff8c2429e68b00
R13: ffff8c2429e68b08 R14: 0000000000000001 R15: ffff8c2429c5a480
FS: 0000000000000000(0000) GS:ffff8c2434700000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000000000000 CR3: 000000002dc0e005 CR4: 00000000001606e0
Call Trace:
<IRQ>
tcf_classify+0x58/0x120
__dev_queue_xmit+0x40a/0x890
? ip6_finish_output2+0x369/0x590
ip6_finish_output2+0x369/0x590
? ip6_output+0x68/0x110
ip6_output+0x68/0x110
? nf_hook.constprop.35+0x79/0xc0
mld_sendpack+0x16f/0x220
mld_ifc_timer_expire+0x195/0x2c0
? igmp6_timer_handler+0x70/0x70
call_timer_fn+0x2b/0x130
run_timer_softirq+0x3e8/0x440
? tick_sched_timer+0x37/0x70
__do_softirq+0xe3/0x2f5
irq_exit+0xf0/0x100
smp_apic_timer_interrupt+0x6c/0x130
apic_timer_interrupt+0xf/0x20
</IRQ>
RIP: 0010:native_safe_halt+0x2/0x10
Code: 74 ff ff ff 7f f3 c3 65 48 8b 04 25 00 5c 01 00 f0 80 48 02 20 48 8b 00 a8 08 74 8b eb c1 90 90 90 90 90 90 90 90 90 90 fb f4 <c3> 0f 1f 00 66 2e 0f 1f 84 00 00 00 00 00 f4 c3 90 90 90 90 90 90
RSP: 0018:ffff9c8640387eb8 EFLAGS: 00000246 ORIG_RAX: ffffffffffffff13
RAX: ffffffff8b2184f0 RBX: 0000000000000002 RCX: 0000000000000001
RDX: 0000000000000001 RSI: 0000000000000087 RDI: 0000000000000002
RBP: 0000000000000002 R08: 000eb57882b36cc3 R09: 0000000000000020
R10: 0000000000000004 R11: 0000000000000000 R12: 0000000000000000
R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
? __sched_text_end+0x1/0x1
default_idle+0x1c/0x140
do_idle+0x1c4/0x280
cpu_startup_entry+0x19/0x20
start_secondary+0x1a7/0x200
secondary_startup_64+0xa4/0xb0
Modules linked in: act_gact act_bpf veth ip6table_filter ip6_tables iptable_filter binfmt_misc crct10dif_pclmul crc32_pclmul ghash_clmulni_intel snd_hda_codec_generic ext4 snd_hda_intel snd_hda_codec snd_hwdep snd_hda_core mbcache jbd2 snd_seq snd_seq_device snd_pcm aesni_intel crypto_simd cryptd glue_helper virtio_balloon joydev pcspkr snd_timer snd i2c_piix4 soundcore nfsd auth_rpcgss nfs_acl lockd grace sunrpc ip_tables xfs ata_generic pata_acpi qxl drm_kms_helper syscopyarea virtio_net sysfillrect net_failover virtio_blk sysimgblt fb_sys_fops virtio_console ttm failover drm crc32c_intel serio_raw ata_piix libata floppy virtio_pci virtio_ring virtio dm_mirror dm_region_hash dm_log dm_mod [last unloaded: act_bpf]
CR2: 0000000000000000
Validating the control action within tcf_gact_init() proved to fix the
above issue. A TDC selftest is added to verify the correct behavior.
Fixes: db50514f9a ("net: sched: add termination action to allow goto chain")
Fixes: 97763dc0f4 ("net_sched: reject unknown tcfa_action values")
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
590 lines
17 KiB
JSON
590 lines
17 KiB
JSON
[
|
|
{
|
|
"id": "e89a",
|
|
"name": "Add valid pass action",
|
|
"category": [
|
|
"actions",
|
|
"gact"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action gact",
|
|
0,
|
|
1,
|
|
255
|
|
]
|
|
],
|
|
"cmdUnderTest": "$TC actions add action pass index 8",
|
|
"expExitCode": "0",
|
|
"verifyCmd": "$TC actions list action gact",
|
|
"matchPattern": "action order [0-9]*: gact action pass.*index 8 ref",
|
|
"matchCount": "1",
|
|
"teardown": [
|
|
"$TC actions flush action gact"
|
|
]
|
|
},
|
|
{
|
|
"id": "a02c",
|
|
"name": "Add valid pipe action",
|
|
"category": [
|
|
"actions",
|
|
"gact"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action gact",
|
|
0,
|
|
1,
|
|
255
|
|
]
|
|
],
|
|
"cmdUnderTest": "$TC actions add action pipe index 6",
|
|
"expExitCode": "0",
|
|
"verifyCmd": "$TC actions list action gact",
|
|
"matchPattern": "action order [0-9]*: gact action pipe.*index 6 ref",
|
|
"matchCount": "1",
|
|
"teardown": [
|
|
"$TC actions flush action gact"
|
|
]
|
|
},
|
|
{
|
|
"id": "feef",
|
|
"name": "Add valid reclassify action",
|
|
"category": [
|
|
"actions",
|
|
"gact"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action gact",
|
|
0,
|
|
1,
|
|
255
|
|
]
|
|
],
|
|
"cmdUnderTest": "$TC actions add action reclassify index 5",
|
|
"expExitCode": "0",
|
|
"verifyCmd": "$TC actions list action gact",
|
|
"matchPattern": "action order [0-9]*: gact action reclassify.*index 5 ref",
|
|
"matchCount": "1",
|
|
"teardown": [
|
|
"$TC actions flush action gact"
|
|
]
|
|
},
|
|
{
|
|
"id": "8a7a",
|
|
"name": "Add valid drop action",
|
|
"category": [
|
|
"actions",
|
|
"gact"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action gact",
|
|
0,
|
|
1,
|
|
255
|
|
]
|
|
],
|
|
"cmdUnderTest": "$TC actions add action drop index 30",
|
|
"expExitCode": "0",
|
|
"verifyCmd": "$TC actions list action gact",
|
|
"matchPattern": "action order [0-9]*: gact action drop.*index 30 ref",
|
|
"matchCount": "1",
|
|
"teardown": [
|
|
"$TC actions flush action gact"
|
|
]
|
|
},
|
|
{
|
|
"id": "9a52",
|
|
"name": "Add valid continue action",
|
|
"category": [
|
|
"actions",
|
|
"gact"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action gact",
|
|
0,
|
|
1,
|
|
255
|
|
]
|
|
],
|
|
"cmdUnderTest": "$TC actions add action continue index 432",
|
|
"expExitCode": "0",
|
|
"verifyCmd": "$TC actions list action gact",
|
|
"matchPattern": "action order [0-9]*: gact action continue.*index 432 ref",
|
|
"matchCount": "1",
|
|
"teardown": [
|
|
"$TC actions flush action gact"
|
|
]
|
|
},
|
|
{
|
|
"id": "d700",
|
|
"name": "Add invalid action",
|
|
"category": [
|
|
"actions",
|
|
"gact"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action gact",
|
|
0,
|
|
1,
|
|
255
|
|
]
|
|
],
|
|
"cmdUnderTest": "$TC actions add action pump index 386",
|
|
"expExitCode": "255",
|
|
"verifyCmd": "$TC actions list action gact",
|
|
"matchPattern": "action order [0-9]*: gact action.*index 386 ref",
|
|
"matchCount": "0",
|
|
"teardown": [
|
|
"$TC actions flush action gact"
|
|
]
|
|
},
|
|
{
|
|
"id": "9215",
|
|
"name": "Add action with duplicate index",
|
|
"category": [
|
|
"actions",
|
|
"gact"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action gact",
|
|
0,
|
|
1,
|
|
255
|
|
],
|
|
"$TC actions add action pipe index 15"
|
|
],
|
|
"cmdUnderTest": "$TC actions add action drop index 15",
|
|
"expExitCode": "255",
|
|
"verifyCmd": "$TC actions list action gact",
|
|
"matchPattern": "action order [0-9]*: gact action drop.*index 15 ref",
|
|
"matchCount": "0",
|
|
"teardown": [
|
|
"$TC actions flush action gact"
|
|
]
|
|
},
|
|
{
|
|
"id": "798e",
|
|
"name": "Add action with index exceeding 32-bit maximum",
|
|
"category": [
|
|
"actions",
|
|
"gact"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action gact",
|
|
0,
|
|
1,
|
|
255
|
|
]
|
|
],
|
|
"cmdUnderTest": "$TC actions add action drop index 4294967296",
|
|
"expExitCode": "255",
|
|
"verifyCmd": "actions list action gact",
|
|
"matchPattern": "action order [0-9]*: gact action drop.*index 4294967296 ref",
|
|
"matchCount": "0",
|
|
"teardown": [
|
|
"$TC actions flush action gact"
|
|
]
|
|
},
|
|
{
|
|
"id": "22be",
|
|
"name": "Add action with index at 32-bit maximum",
|
|
"category": [
|
|
"actions",
|
|
"gact"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action gact",
|
|
0,
|
|
1,
|
|
255
|
|
]
|
|
],
|
|
"cmdUnderTest": "$TC actions add action drop index 4294967295",
|
|
"expExitCode": "0",
|
|
"verifyCmd": "$TC actions list action gact",
|
|
"matchPattern": "action order [0-9]*: gact action drop.*index 4294967295 ref",
|
|
"matchCount": "1",
|
|
"teardown": [
|
|
"$TC actions flush action gact"
|
|
]
|
|
},
|
|
{
|
|
"id": "ac2a",
|
|
"name": "List actions",
|
|
"category": [
|
|
"actions",
|
|
"gact"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action gact",
|
|
0,
|
|
1,
|
|
255
|
|
],
|
|
"$TC actions add action reclassify index 101",
|
|
"$TC actions add action reclassify index 102",
|
|
"$TC actions add action reclassify index 103",
|
|
"$TC actions add action reclassify index 104",
|
|
"$TC actions add action reclassify index 105"
|
|
],
|
|
"cmdUnderTest": "$TC actions list action gact",
|
|
"expExitCode": "0",
|
|
"verifyCmd": "$TC actions list action gact",
|
|
"matchPattern": "action order [0-9]*: gact action reclassify",
|
|
"matchCount": "5",
|
|
"teardown": [
|
|
"$TC actions flush action gact"
|
|
]
|
|
},
|
|
{
|
|
"id": "3edf",
|
|
"name": "Flush gact actions",
|
|
"category": [
|
|
"actions",
|
|
"gact"
|
|
],
|
|
"setup": [
|
|
"$TC actions add action reclassify index 101",
|
|
"$TC actions add action reclassify index 102",
|
|
"$TC actions add action reclassify index 103",
|
|
"$TC actions add action reclassify index 104",
|
|
"$TC actions add action reclassify index 105"
|
|
],
|
|
"cmdUnderTest": "$TC actions flush action gact",
|
|
"expExitCode": "0",
|
|
"verifyCmd": "$TC actions list action gact",
|
|
"matchPattern": "action order [0-9]*: gact action reclassify",
|
|
"matchCount": "0",
|
|
"teardown": []
|
|
},
|
|
{
|
|
"id": "63ec",
|
|
"name": "Delete pass action",
|
|
"category": [
|
|
"actions",
|
|
"gact"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action gact",
|
|
0,
|
|
1,
|
|
255
|
|
],
|
|
"$TC actions add action pass index 1"
|
|
],
|
|
"cmdUnderTest": "$TC actions del action gact index 1",
|
|
"expExitCode": "0",
|
|
"verifyCmd": "$TC actions list action gact",
|
|
"matchPattern": "action order [0-9]*: gact action pass.*index 1 ref",
|
|
"matchCount": "0",
|
|
"teardown": [
|
|
"$TC actions flush action gact"
|
|
]
|
|
},
|
|
{
|
|
"id": "46be",
|
|
"name": "Delete pipe action",
|
|
"category": [
|
|
"actions",
|
|
"gact"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action gact",
|
|
0,
|
|
1,
|
|
255
|
|
],
|
|
"$TC actions add action pipe index 9"
|
|
],
|
|
"cmdUnderTest": "$TC actions del action gact index 9",
|
|
"expExitCode": "0",
|
|
"verifyCmd": "$TC actions list action gact",
|
|
"matchPattern": "action order [0-9]*: gact action pipe.*index 9 ref",
|
|
"matchCount": "0",
|
|
"teardown": [
|
|
"$TC actions flush action gact"
|
|
]
|
|
},
|
|
{
|
|
"id": "2e08",
|
|
"name": "Delete reclassify action",
|
|
"category": [
|
|
"actions",
|
|
"gact"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action gact",
|
|
0,
|
|
1,
|
|
255
|
|
],
|
|
"$TC actions add action reclassify index 65536"
|
|
],
|
|
"cmdUnderTest": "$TC actions del action gact index 65536",
|
|
"expExitCode": "0",
|
|
"verifyCmd": "$TC actions list action gact",
|
|
"matchPattern": "action order [0-9]*: gact action reclassify.*index 65536 ref",
|
|
"matchCount": "0",
|
|
"teardown": [
|
|
"$TC actions flush action gact"
|
|
]
|
|
},
|
|
{
|
|
"id": "99c4",
|
|
"name": "Delete drop action",
|
|
"category": [
|
|
"actions",
|
|
"gact"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action gact",
|
|
0,
|
|
1,
|
|
255
|
|
],
|
|
"$TC actions add action drop index 16"
|
|
],
|
|
"cmdUnderTest": "$TC actions del action gact index 16",
|
|
"expExitCode": "0",
|
|
"verifyCmd": "$TC actions list action gact",
|
|
"matchPattern": "action order [0-9]*: gact action drop.*index 16 ref",
|
|
"matchCount": "0",
|
|
"teardown": [
|
|
"$TC actions flush action gact"
|
|
]
|
|
},
|
|
{
|
|
"id": "fb6b",
|
|
"name": "Delete continue action",
|
|
"category": [
|
|
"actions",
|
|
"gact"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action gact",
|
|
0,
|
|
1,
|
|
255
|
|
],
|
|
"$TC actions add action continue index 32"
|
|
],
|
|
"cmdUnderTest": "$TC actions del action gact index 32",
|
|
"expExitCode": "0",
|
|
"verifyCmd": "actions list action gact",
|
|
"matchPattern": "action order [0-9]*: gact action continue.*index 32 ref",
|
|
"matchCount": "0",
|
|
"teardown": [
|
|
"$TC actions flush action gact"
|
|
]
|
|
},
|
|
{
|
|
"id": "0eb3",
|
|
"name": "Delete non-existent action",
|
|
"category": [
|
|
"actions",
|
|
"gact"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action gact",
|
|
0,
|
|
1,
|
|
255
|
|
]
|
|
],
|
|
"cmdUnderTest": "$TC actions del action gact index 2",
|
|
"expExitCode": "255",
|
|
"verifyCmd": "$TC actions list action gact",
|
|
"matchPattern": "action order [0-9]*: gact action",
|
|
"matchCount": "0",
|
|
"teardown": [
|
|
"$TC actions flush action gact"
|
|
]
|
|
},
|
|
{
|
|
"id": "f02c",
|
|
"name": "Replace gact action",
|
|
"category": [
|
|
"actions",
|
|
"gact"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action gact",
|
|
0,
|
|
1,
|
|
255
|
|
],
|
|
"$TC actions add action drop index 10",
|
|
"$TC actions add action drop index 12"
|
|
],
|
|
"cmdUnderTest": "$TC actions replace action ok index 12",
|
|
"expExitCode": "0",
|
|
"verifyCmd": "$TC actions ls action gact",
|
|
"matchPattern": "action order [0-9]*: gact action pass",
|
|
"matchCount": "1",
|
|
"teardown": [
|
|
"$TC actions flush action gact"
|
|
]
|
|
},
|
|
{
|
|
"id": "525f",
|
|
"name": "Get gact action by index",
|
|
"category": [
|
|
"actions",
|
|
"gact"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action gact",
|
|
0,
|
|
1,
|
|
255
|
|
],
|
|
"$TC actions add action drop index 3900800700"
|
|
],
|
|
"cmdUnderTest": "$TC actions get action gact index 3900800700",
|
|
"expExitCode": "0",
|
|
"verifyCmd": "$TC actions get action gact index 3900800700",
|
|
"matchPattern": "index 3900800700",
|
|
"matchCount": "1",
|
|
"teardown": [
|
|
"$TC actions flush action gact"
|
|
]
|
|
},
|
|
{
|
|
"id": "1021",
|
|
"name": "Add batch of 32 gact pass actions",
|
|
"category": [
|
|
"actions",
|
|
"gact"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action gact",
|
|
0,
|
|
1,
|
|
255
|
|
]
|
|
],
|
|
"cmdUnderTest": "bash -c \"for i in \\`seq 1 32\\`; do cmd=\\\"action pass index \\$i \\\"; args=\"\\$args\\$cmd\"; done && $TC actions add \\$args\"",
|
|
"expExitCode": "0",
|
|
"verifyCmd": "$TC actions list action gact",
|
|
"matchPattern": "^[ \t]+index [0-9]+ ref",
|
|
"matchCount": "32",
|
|
"teardown": [
|
|
"$TC actions flush action gact"
|
|
]
|
|
},
|
|
{
|
|
"id": "da7a",
|
|
"name": "Add batch of 32 gact continue actions with cookie",
|
|
"category": [
|
|
"actions",
|
|
"gact"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action gact",
|
|
0,
|
|
1,
|
|
255
|
|
]
|
|
],
|
|
"cmdUnderTest": "bash -c \"for i in \\`seq 1 32\\`; do cmd=\\\"action continue index \\$i cookie aabbccddeeff112233445566778800a1 \\\"; args=\"\\$args\\$cmd\"; done && $TC actions add \\$args\"",
|
|
"expExitCode": "0",
|
|
"verifyCmd": "$TC actions list action gact",
|
|
"matchPattern": "^[ \t]+index [0-9]+ ref",
|
|
"matchCount": "32",
|
|
"teardown": [
|
|
"$TC actions flush action gact"
|
|
]
|
|
},
|
|
{
|
|
"id": "8aa3",
|
|
"name": "Delete batch of 32 gact continue actions",
|
|
"category": [
|
|
"actions",
|
|
"gact"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action gact",
|
|
0,
|
|
1,
|
|
255
|
|
],
|
|
"bash -c \"for i in \\`seq 1 32\\`; do cmd=\\\"action continue index \\$i \\\"; args=\\\"\\$args\\$cmd\\\"; done && $TC actions add \\$args\""
|
|
],
|
|
"cmdUnderTest": "bash -c \"for i in \\`seq 1 32\\`; do cmd=\\\"action gact index \\$i \\\"; args=\"\\$args\\$cmd\"; done && $TC actions del \\$args\"",
|
|
"expExitCode": "0",
|
|
"verifyCmd": "$TC actions list action gact",
|
|
"matchPattern": "^[ \t]+index [0-9]+ ref",
|
|
"matchCount": "0",
|
|
"teardown": []
|
|
},
|
|
{
|
|
"id": "8e47",
|
|
"name": "Add gact action with random determ goto chain control action",
|
|
"category": [
|
|
"actions",
|
|
"gact"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action gact",
|
|
0,
|
|
1,
|
|
255
|
|
]
|
|
],
|
|
"cmdUnderTest": "$TC actions add action pass random determ goto chain 1 2 index 90",
|
|
"expExitCode": "255",
|
|
"verifyCmd": "$TC actions list action gact",
|
|
"matchPattern": "action order [0-9]*: gact action pass random type determ goto chain 1 val 2.*index 90 ref",
|
|
"matchCount": "0",
|
|
"teardown": [
|
|
"$TC actions flush action gact"
|
|
]
|
|
},
|
|
{
|
|
"id": "ca89",
|
|
"name": "Replace gact action with invalid goto chain control",
|
|
"category": [
|
|
"actions",
|
|
"gact"
|
|
],
|
|
"setup": [
|
|
[
|
|
"$TC actions flush action gact",
|
|
0,
|
|
1,
|
|
255
|
|
],
|
|
"$TC actions add action pass random determ drop 2 index 90"
|
|
],
|
|
"cmdUnderTest": "$TC actions replace action goto chain 42 random determ drop 5 index 90 cookie c1a0c1a0",
|
|
"expExitCode": "255",
|
|
"verifyCmd": "$TC actions list action gact",
|
|
"matchPattern": "action order [0-9]*: gact action pass.*random type determ drop val 2.*index 90 ref",
|
|
"matchCount": "1",
|
|
"teardown": [
|
|
"$TC actions flush action gact"
|
|
]
|
|
}
|
|
]
|