mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-25 11:33:45 +07:00
1cf86bc212
If you do this on an sdm845 board:
grep "" /sys/kernel/debug/pinctrl/*spmi:pmic*/pinconf-groups
...it looks like nonsense. For every pin you see listed:
input bias disabled, input bias high impedance, input bias pull down, input bias pull up, ...
That's because pmic_gpio_config_get() isn't complying with the rules
that pinconf_generic_dump_one() expects. Specifically for boolean
parameters (anything with a "struct pin_config_item" where has_arg is
false) the function expects that the function should return its value
not through the "config" parameter but should return "0" if the value
is set and "-EINVAL" if the value isn't set.
Let's fix this.
From a quick sample of other pinctrl drivers, it appears to be
tradition to also return 1 through the config parameter for these
boolean parameters when they exist. I'm not one to knock tradition,
so I'll follow tradition and return 1 in these cases. While I'm at
it, I'll also continue searching for four leaf clovers, kocking on
wood three times, and trying not to break mirrors.
NOTE: This also fixes an apparent typo for reading
PIN_CONFIG_BIAS_DISABLE where the old driver was accidentally
using "=" instead of "==" and thus was setting some internal
state when you tried to query PIN_CONFIG_BIAS_DISABLE. Oops.
Fixes:
|
||
---|---|---|
.. | ||
Kconfig | ||
Makefile | ||
pinctrl-apq8064.c | ||
pinctrl-apq8084.c | ||
pinctrl-ipq4019.c | ||
pinctrl-ipq8064.c | ||
pinctrl-ipq8074.c | ||
pinctrl-mdm9615.c | ||
pinctrl-msm8x74.c | ||
pinctrl-msm8660.c | ||
pinctrl-msm8916.c | ||
pinctrl-msm8960.c | ||
pinctrl-msm8994.c | ||
pinctrl-msm8996.c | ||
pinctrl-msm8998.c | ||
pinctrl-msm.c | ||
pinctrl-msm.h | ||
pinctrl-qdf2xxx.c | ||
pinctrl-sdm845.c | ||
pinctrl-spmi-gpio.c | ||
pinctrl-spmi-mpp.c | ||
pinctrl-ssbi-gpio.c | ||
pinctrl-ssbi-mpp.c |