Xin Long d25adbeb0c sctp: fix an use-after-free issue in sctp_sock_dump ... Commit 86fdb3448c ("sctp: ensure ep is not destroyed before doing the dump") tried to fix an use-after-free issue by checking !sctp_sk(sk)->ep with holding sock and sock lock. But Paolo noticed that endpoint could be destroyed in sctp_rcv without sock lock protection. It means the use-after-free issue still could be triggered when sctp_rcv put and destroy ep after sctp_sock_dump checks !ep, although it's pretty hard to reproduce. I could reproduce it by mdelay in sctp_rcv while msleep in sctp_close and sctp_sock_dump long time. This patch is to add another param cb_done to sctp_for_each_transport and dump ep->assocs with holding tsp after jumping out of transport's traversal in it to avoid this issue. It can also improve sctp diag dump to make it run faster, as no need to save sk into cb->args[5] and keep calling sctp_for_each_transport any more. This patch is also to use int * instead of int for the pos argument in sctp_for_each_transport, which could make postion increment only in sctp_for_each_transport and no need to keep changing cb->args[2] in sctp_sock_filter and sctp_sock_dump any more. Fixes: 86fdb3448c ("sctp: ensure ep is not destroyed before doing the dump") Reported-by: Paolo Abeni <pabeni@redhat.com> Signed-off-by: Xin Long <lucien.xin@gmail.com> Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> Acked-by: Neil Horman <nhorman@tuxdriver.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2017-09-15 14:47:49 -07:00
..
auth.h	net, sctp: convert sctp_auth_bytes.refcnt from atomic_t to refcount_t	2017-07-04 22:35:18 +01:00
checksum.h	include/net/: Fix FSF address in file headers	2013-12-06 12:37:56 -05:00
command.h	sctp: remove the typedef sctp_verb_t	2017-08-11 10:02:44 -07:00
constants.h	sctp: remove the typedef sctp_subtype_t	2017-08-06 21:33:42 -07:00
sctp.h	sctp: fix an use-after-free issue in sctp_sock_dump	2017-09-15 14:47:49 -07:00
sm.h	sctp: fix some indents in sm_make_chunk.c	2017-08-11 10:02:44 -07:00
structs.h	sctp: remove the typedef sctp_socket_type_t	2017-08-11 10:02:44 -07:00
tsnmap.h	sctp: Fix FSF address in file headers	2013-12-06 12:37:56 -05:00
ulpevent.h	sctp: potential read out of bounds in sctp_ulpevent_type_enabled()	2017-09-13 16:59:47 -07:00
ulpqueue.h	sctp: Fix FSF address in file headers	2013-12-06 12:37:56 -05:00