Kees Cook 800e7a205a b43: Remove uninitialized_var() usage ... Using uninitialized_var() is dangerous as it papers over real bugs[1] (or can in the future), and suppresses unrelated compiler warnings (e.g. "unused variable"). If the compiler thinks it is uninitialized, either simply initialize the variable or make compiler changes. As a precursor to removing[2] this[3] macro[4], just initialize this variable to NULL. No later NULL deref is possible due to the early returns outside of the (phy->rev >= 7 && phy->rev < 19) case, which explicitly tests for NULL. [1] https://lore.kernel.org/lkml/20200603174714.192027-1-glider@google.com/ [2] https://lore.kernel.org/lkml/CA+55aFw+Vbj0i=1TGqCR5vQkCzWJ0QxK6CernOU6eedsudAixw@mail.gmail.com/ [3] https://lore.kernel.org/lkml/CA+55aFwgbgqhbp1fkxvRKEpzyR5J8n1vKT1VZdz9knmPuXhOeg@mail.gmail.com/ [4] https://lore.kernel.org/lkml/CA+55aFz2500WfbKXAx8s67wrm9=yVJu65TpLgN_ybYNv0VEOKA@mail.gmail.com/ Fixes: 58619b14d1 ("b43: move under broadcom vendor directory") Signed-off-by: Kees Cook <keescook@chromium.org> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Link: https://lore.kernel.org/r/20200620033007.1444705-5-keescook@chromium.org		2020-07-15 13:36:38 +03:00
..
b43.h	b43: fix spelling mistake "hw_registred" -> "hw_registered"	2018-10-01 18:41:34 +03:00
bus.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 20	2019-05-21 11:28:46 +02:00
bus.h
debugfs.c	b43: Use scnprintf() for avoiding potential buffer overflow	2020-03-12 15:43:37 +02:00
debugfs.h
dma.c	b43: dma: Fix use true/false for bool type variable	2019-10-31 10:08:18 +02:00
dma.h
Kconfig	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
leds.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 20	2019-05-21 11:28:46 +02:00
leds.h
lo.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 20	2019-05-21 11:28:46 +02:00
lo.h
main.c	broadcom: fix wiki website url	2020-07-15 13:18:41 +03:00
main.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 20	2019-05-21 11:28:46 +02:00
Makefile
phy_a.h
phy_ac.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
phy_ac.h
phy_common.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 20	2019-05-21 11:28:46 +02:00
phy_common.h	b43: Use cordic algorithm from kernel library	2018-11-29 17:30:50 +02:00
phy_g.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 20	2019-05-21 11:28:46 +02:00
phy_g.h
phy_ht.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 20	2019-05-21 11:28:46 +02:00
phy_ht.h
phy_lcn.c
phy_lcn.h
phy_lp.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 20	2019-05-21 11:28:46 +02:00
phy_lp.h
phy_n.c	b43: Remove uninitialized_var() usage	2020-07-15 13:36:38 +03:00
phy_n.h
pio.c	b43: remove Comparison of 0/1 to bool variable in pio.c	2020-05-06 11:45:27 +03:00
pio.h
ppr.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
ppr.h
radio_2055.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 20	2019-05-21 11:28:46 +02:00
radio_2055.h
radio_2056.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 20	2019-05-21 11:28:46 +02:00
radio_2056.h
radio_2057.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 20	2019-05-21 11:28:46 +02:00
radio_2057.h
radio_2059.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 20	2019-05-21 11:28:46 +02:00
radio_2059.h
rfkill.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 20	2019-05-21 11:28:46 +02:00
rfkill.h
sdio.c	mmc: sdio: Move SDIO IDs from b43-sdio driver to common include file	2020-05-29 12:37:59 +02:00
sdio.h
sysfs.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 20	2019-05-21 11:28:46 +02:00
sysfs.h
tables_lpphy.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 20	2019-05-21 11:28:46 +02:00
tables_lpphy.h
tables_nphy.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 20	2019-05-21 11:28:46 +02:00
tables_nphy.h
tables_phy_ht.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 20	2019-05-21 11:28:46 +02:00
tables_phy_ht.h
tables_phy_lcn.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 20	2019-05-21 11:28:46 +02:00
tables_phy_lcn.h
tables.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 20	2019-05-21 11:28:46 +02:00
tables.h
wa.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 20	2019-05-21 11:28:46 +02:00
wa.h
xmit.c	b43: remove dead function b43_rssinoise_postprocess()	2020-05-07 13:04:21 -07:00
xmit.h