Suzuki K. Poulose 4592281403 perf tools: Remove the node from rblist in strlist__remove ... The following commit: author David Ahern <dsahern@gmail.com> Tue, 31 Jul 2012 04:31:33 +0000 (22:31 -0600) committer Arnaldo Carvalho de Melo <acme@redhat.com> Fri, 3 Aug 2012 13:39:51 +0000 (10:39 -0300) commit ee8dd3ca43 causes a double free during a probe deletion as the node is never removed from the list via strlist__remove(), even though it gets 'deleted' (read free()'d). This causes a double free when we do strlist__delete() as the node is already deleted but present in the rblist. [suzukikp@suzukikp perf]$ sudo ./perf probe -a do_fork Added new event: probe:do_fork (on do_fork) You can now use it in all perf tools, such as: perf record -e probe:do_fork -aR sleep 1 [suzukikp@suzukikp perf]$ sudo ./perf probe -d do_fork Removed event: probe:do_fork *** glibc detected *** ./perf: double free or corruption (fasttop): 0x000000000133d600 *** ======= Backtrace: ========= /lib64/libc.so.6[0x38eec7dda6] ./perf(rblist__delete+0x5c)[0x47d3dc] ./perf(del_perf_probe_events+0xb6)[0x47b826] ./perf(cmd_probe+0x471)[0x42c8d1] ./perf[0x4150b3] ./perf(main+0x501)[0x4148e1] /lib64/libc.so.6(__libc_start_main+0xed)[0x38eec2169d] ./perf[0x414a61] Make sure we remove the node from the rblist before we delete the node. The rblist__remove_node() will invoke rblist->node_delete, which will take care of deleting the node with the suitable function provided by the user. Reported-by: Ananth N. Mavinakayanahalli <ananth@in.ibm.com> Signed-off-by: Suzuki K. Poulose <suzuki@in.ibm.com> Acked-by: David Ahern <dsahern@gmail.com> Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com> Cc: David Ahern <dsahern@gmail.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Ingo Molnar <mingo@kernel.org> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Link: http://lkml.kernel.org/r/20120829055840.7802.1459.stgit@suzukikp.in.ibm.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>		2012-09-05 17:36:42 -03:00
..
firewire	tools/firewire: nosy-dump: increment program version	2010-07-27 11:04:12 +02:00
hv	Tools: hv: verify origin of netlink connector message	2012-06-10 00:29:46 +09:00
include/tools	tools/include: Add byteshift headers for endian access	2012-02-28 10:22:51 -08:00
lguest	lguest: move the lguest tool to the tools directory	2012-01-12 15:44:47 +10:30
lib/traceevent	tools lib traceevent: Modify header to work in C++ programs	2012-09-05 17:17:30 -03:00
nfsd	NFSD: Added fault injection script	2011-11-07 21:10:47 -05:00
perf	perf tools: Remove the node from rblist in strlist__remove	2012-09-05 17:36:42 -03:00
power	tools/power: turbostat: fix large c1% issue	2012-07-19 22:26:33 -04:00
scripts	perf tools: Let O= makes handle relative paths	2012-08-16 14:11:11 -03:00
testing	fault-injection: fix failcmd.sh warning	2012-07-31 18:42:38 -07:00
usb	testusb: expose looping forever option "l" to user	2012-06-13 16:15:03 -07:00
virtio	virtio/tools: add delayed interupt mode	2012-05-02 18:22:14 +03:00
vm	mm: Fix signal SIGFPE in slabinfo.c.	2012-07-02 23:11:14 +03:00
Makefile	tools: Connect to the kernel build system	2012-04-11 15:00:17 -03:00