mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-11-26 17:40:53 +07:00
272725c7db
Replace uses of fb->bits_per_pixel with fb->format->cpp[0]*8. Less duplicated information is a good thing. Note that I didn't put parens around the cpp*8 in the below cocci script, on account of not wanting spurious parens all over the place. Instead I did the unsafe way, and tried to look over the entire diff to spot if any dangerous expressions were produced. I didn't see any. There are some cases where previously the code did X*bpp/8, so the division happened after the multiplication. Those are now just X*cpp so the division effectively happens before the multiplication, but that is perfectly fine since bpp is always a multiple of 8. @@ struct drm_framebuffer *FB; expression E; @@ drm_helper_mode_fill_fb_struct(...) { ... - FB->bits_per_pixel = E; ... } @@ struct drm_framebuffer *FB; expression E; @@ i9xx_get_initial_plane_config(...) { ... - FB->bits_per_pixel = E; ... } @@ struct drm_framebuffer *FB; expression E; @@ ironlake_get_initial_plane_config(...) { ... - FB->bits_per_pixel = E; ... } @@ struct drm_framebuffer *FB; expression E; @@ skylake_get_initial_plane_config(...) { ... - FB->bits_per_pixel = E; ... } @@ struct drm_framebuffer FB; expression E; @@ ( - E * FB.bits_per_pixel / 8 + E * FB.format->cpp[0] | - FB.bits_per_pixel / 8 + FB.format->cpp[0] | - E * FB.bits_per_pixel >> 3 + E * FB.format->cpp[0] | - FB.bits_per_pixel >> 3 + FB.format->cpp[0] | - (FB.bits_per_pixel + 7) / 8 + FB.format->cpp[0] | - FB.bits_per_pixel + FB.format->cpp[0] * 8 | - FB.format->cpp[0] * 8 != 8 + FB.format->cpp[0] != 1 ) @@ struct drm_framebuffer *FB; expression E; @@ ( - E * FB->bits_per_pixel / 8 + E * FB->format->cpp[0] | - FB->bits_per_pixel / 8 + FB->format->cpp[0] | - E * FB->bits_per_pixel >> 3 + E * FB->format->cpp[0] | - FB->bits_per_pixel >> 3 + FB->format->cpp[0] | - (FB->bits_per_pixel + 7) / 8 + FB->format->cpp[0] | - FB->bits_per_pixel + FB->format->cpp[0] * 8 | - FB->format->cpp[0] * 8 != 8 + FB->format->cpp[0] != 1 ) @@ struct drm_plane_state *state; expression E; @@ ( - E * state->fb->bits_per_pixel / 8 + E * state->fb->format->cpp[0] | - state->fb->bits_per_pixel / 8 + state->fb->format->cpp[0] | - E * state->fb->bits_per_pixel >> 3 + E * state->fb->format->cpp[0] | - state->fb->bits_per_pixel >> 3 + state->fb->format->cpp[0] | - (state->fb->bits_per_pixel + 7) / 8 + state->fb->format->cpp[0] | - state->fb->bits_per_pixel + state->fb->format->cpp[0] * 8 | - state->fb->format->cpp[0] * 8 != 8 + state->fb->format->cpp[0] != 1 ) @@ @@ - (8 * 8) + 8 * 8 @@ struct drm_framebuffer FB; @@ - (FB.format->cpp[0]) + FB.format->cpp[0] @@ struct drm_framebuffer *FB; @@ - (FB->format->cpp[0]) + FB->format->cpp[0] @@ @@ struct drm_framebuffer { ... - int bits_per_pixel; ... }; v2: Clean up the 'cpp*8 != 8' and '(8 * 8)' cases (Laurent) v3: Adjusted the semantic patch a bit and regenerated due to code changes Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Alex Deucher <alexander.deucher@amd.com> (v1) Link: http://patchwork.freedesktop.org/patch/msgid/1481751140-18352-1-git-send-email-ville.syrjala@linux.intel.com |
||
---|---|---|
.. | ||
accel_2d.c | ||
backlight.c | ||
blitter.c | ||
blitter.h | ||
cdv_device.c | ||
cdv_device.h | ||
cdv_intel_crt.c | ||
cdv_intel_display.c | ||
cdv_intel_dp.c | ||
cdv_intel_hdmi.c | ||
cdv_intel_lvds.c | ||
framebuffer.c | ||
framebuffer.h | ||
gem.c | ||
gem.h | ||
gma_device.c | ||
gma_device.h | ||
gma_display.c | ||
gma_display.h | ||
gtt.c | ||
gtt.h | ||
intel_bios.c | ||
intel_bios.h | ||
intel_gmbus.c | ||
intel_i2c.c | ||
Kconfig | ||
Makefile | ||
mdfld_device.c | ||
mdfld_dsi_dpi.c | ||
mdfld_dsi_dpi.h | ||
mdfld_dsi_output.c | ||
mdfld_dsi_output.h | ||
mdfld_dsi_pkg_sender.c | ||
mdfld_dsi_pkg_sender.h | ||
mdfld_intel_display.c | ||
mdfld_output.c | ||
mdfld_output.h | ||
mdfld_tmd_vid.c | ||
mdfld_tpo_vid.c | ||
mid_bios.c | ||
mid_bios.h | ||
mmu.c | ||
mmu.h | ||
oaktrail_crtc.c | ||
oaktrail_device.c | ||
oaktrail_hdmi_i2c.c | ||
oaktrail_hdmi.c | ||
oaktrail_lvds_i2c.c | ||
oaktrail_lvds.c | ||
oaktrail.h | ||
opregion.c | ||
opregion.h | ||
power.c | ||
power.h | ||
psb_device.c | ||
psb_device.h | ||
psb_drv.c | ||
psb_drv.h | ||
psb_intel_display.c | ||
psb_intel_drv.h | ||
psb_intel_lvds.c | ||
psb_intel_modes.c | ||
psb_intel_reg.h | ||
psb_intel_sdvo_regs.h | ||
psb_intel_sdvo.c | ||
psb_irq.c | ||
psb_irq.h | ||
psb_lid.c | ||
psb_reg.h | ||
tc35876x-dsi-lvds.c | ||
tc35876x-dsi-lvds.h |