Michal Schmidt 437708c443 IPoIB: Report operstate consistently when brought up without a link ... After booting without a working link, "ip link" shows: 5: mlx4_ib1: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 2044 qdisc pfifo_fast state DOWN qlen 256 ... 7: mlx4_ib1.8003@mlx4_ib1: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 2044 qdisc pfifo_fast state DOWN qlen 256 ... Then after connecting and disconnecting the link, which should result in exactly the same state as before, it shows: 5: mlx4_ib1: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 2044 qdisc pfifo_fast state DOWN qlen 256 ... 7: mlx4_ib1.8003@mlx4_ib1: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 2044 qdisc pfifo_fast state LOWERLAYERDOWN qlen 256 ... Notice the (now correct) LOWERLAYERDOWN operstate shown for the mlx4_ib1.8003 interface. Ideally the identical state would be shown right after boot. The problem is related to the calling of netif_carrier_off() in network drivers. For a long time it was known that doing netif_carrier_off() before registering the netdevice would result in the interface's operstate being shown as UNKNOWN if the device was brought up without a working link. This problem was fixed in commit 8f4cccbbd9 ('net: Set device operstate at registration time'), but still there remains the minor inconsistency demonstrated above. This patch fixes it by moving ipoib's call to netif_carrier_off() into the .ndo_open method, which is where network drivers ordinarily do it. With the patch when doing the same test as above, the operstate of mlx4_ib1.8003 is shown as LOWERLAYERDOWN right after boot. Signed-off-by: Michal Schmidt <mschmidt@redhat.com> Acked-by: Erez Shitrit <erezsh@mellanox.com> Signed-off-by: Roland Dreier <roland@purestorage.com>		2014-01-22 23:01:05 -08:00
..
ipoib_cm.c	IPoIB: Change CM skb memory allocation to be non-atomic during init	2013-11-08 14:42:48 -08:00
ipoib_ethtool.c	IPoIB: Add version and firmware info to ethtool reporting	2013-02-19 08:21:36 -08:00
ipoib_fs.c	Merge branch 'modsplit-Oct31_2011' of git://git.kernel.org/pub/scm/linux/kernel/git/paulg/linux	2011-11-06 19:44:47 -08:00
ipoib_ib.c	IPoIB: Add path query flushing in ipoib_ib_dev_cleanup	2013-11-08 14:42:49 -08:00
ipoib_main.c	IPoIB: Report operstate consistently when brought up without a link	2014-01-22 23:01:05 -08:00
ipoib_multicast.c	IPoIB: Start multicast join process only on active ports	2013-11-08 14:42:49 -08:00
ipoib_netlink.c	infiniband: make sure the src net is infiniband when create new link	2014-01-03 20:38:56 -05:00
ipoib_verbs.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	2010-03-30 22:02:32 +09:00
ipoib_vlan.c	IPoIB: Fix deadlock between dev_change_flags() and __ipoib_dev_flush()	2013-11-08 14:42:49 -08:00
ipoib.h	IPoIB: Fix usage of uninitialized multicast objects	2013-11-08 14:42:49 -08:00
Kconfig	kconfig: rename CONFIG_EMBEDDED to CONFIG_EXPERT	2011-01-20 17:02:05 -08:00
Makefile	IB/ipoib: Add rtnl_link_ops support	2012-09-20 16:49:17 -04:00