linux_dsm_epyc7002/drivers/gpu/drm
Chris Wilson 42c3b603da drm/i915: Always pin the default context
Through a twisty and circuituous path it is possible to currently trick
the code into creating a default context and forgetting to pin it
immediately into the GGTT. (This requires a system using contexts without
an aliasing ppgtt, which is currently restricted to Baytrails machines
manually specifying a module parameter to force enable contexts, or
on Sandybridge and later that manually disable the aliasing ppgtt.) The
consequence is that during module unload we attempt to unpin the default
context twice and encounter a BUG remonstrating that we attempt to unpin
an unbound object.

[  161.002869] Kernel BUG at f84861f8 [verbose debug info unavailable]
[  161.002875] invalid opcode: 0000 [#1] SMP
[  161.002882] Modules linked in: coretemp kvm_intel kvm crc32_pclmul aesni_intel aes_i586 xts lrw gf128mul ablk_helper cryptd hid_sensor_accel_3d hid_sensor_gyro_3d hid_sensor_magn_3d hid_sensor_trigger industrialio_triggered_buffer kfifo_buf industrialio hid_sensor_iio_common snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_intel snd_hda_codec snd_hwdep snd_pcm snd_page_alloc snd_seq_midi snd_seq_midi_event dm_multipath scsi_dh asix ppdev usbnet snd_rawmidi mii hid_sensor_hub microcode snd_seq rfcomm bnep snd_seq_device bluetooth snd_timer snd parport_pc binfmt_misc soundcore dw_dmac_pci dw_dmac_core mac_hid lp parport dm_mirror dm_region_hash dm_log hid_generic usbhid hid i915(O-) drm_kms_helper(O) igb dca ptp pps_core i2c_algo_bit drm(O) ahci libahci video
[  161.002991] CPU: 0 PID: 2114 Comm: rmmod Tainted: G        W  O 3.13.0-rc8+ #2
[  161.002997] Hardware name: NEXCOM VTC1010/Aptio CRB, BIOS 5.6.5 09/24/2013
[  161.003004] task: dbdd6800 ti: dbe0e000 task.ti: dbe0e000
[  161.003010] EIP: 0060:[<f84861f8>] EFLAGS: 00010246 CPU: 0
[  161.003044] EIP is at i915_gem_object_ggtt_unpin+0x88/0x90 [i915]
[  161.003050] EAX: dfce3840 EBX: 00000000 ECX: dfafd690 EDX: dfce3874
[  161.003056] ESI: c0086b40 EDI: df962e00 EBP: dbe0fe1c ESP: dbe0fe0c
[  161.003062]  DS: 007b ES: 007b FS: 00d8 GS: 00e0 SS: 0068
[  161.003068] CR0: 8005003b CR2: b7718000 CR3: 1bec0000 CR4: 001007f0
[  161.003076] Stack:
[  161.003081]  00afc014 00000004 c0086b40 dfafc000 dbe0fe38 f8487e5a dfaa5400 c0086b40
[  161.003099]  dfafc000 dfaa5400 dfaa5414 dbe0fe58 f84741aa 00000000 f89c34b9 dfaa5414
[  161.003117]  dfaa5400 dfaa5400 f644b000 dbe0fe6c f89a5443 dfaa5400 f8505000 f644b000
[  161.003134] Call Trace:
[  161.003169]  [<f8487e5a>] i915_gem_context_fini+0xba/0x1c0 [i915]
[  161.003202]  [<f84741aa>] i915_driver_unload+0x1fa/0x2f0 [i915]
[  161.003232]  [<f89a5443>] drm_dev_unregister+0x23/0x90 [drm]
[  161.003259]  [<f89a54ed>] drm_put_dev+0x3d/0x70 [drm]
[  161.003294]  [<f8470615>] i915_pci_remove+0x15/0x20 [i915]
[  161.003306]  [<c1338a6f>] pci_device_remove+0x2f/0xa0
[  161.003317]  [<c140c871>] __device_release_driver+0x61/0xc0
[  161.003328]  [<c140d12f>] driver_detach+0x8f/0xa0
[  161.003341]  [<c140c54f>] bus_remove_driver+0x4f/0xc0
[  161.003353]  [<c140d708>] driver_unregister+0x28/0x60
[  161.003362]  [<c10cee42>] ? stop_cpus+0x32/0x40
[  161.003372]  [<c10bd510>] ? module_refcount+0x90/0x90
[  161.003383]  [<c13378c5>] pci_unregister_driver+0x15/0x60
[  161.003413]  [<f89a739f>] drm_pci_exit+0x9f/0xb0 [drm]
[  161.003458]  [<f84e624a>] i915_exit+0x1b/0x1d [i915]
[  161.003468]  [<c10bf8a8>] SyS_delete_module+0x158/0x1f0
[  161.003480]  [<c1173d5d>] ? ____fput+0xd/0x10
[  161.003488]  [<c106f0fe>] ? task_work_run+0x7e/0xb0
[  161.003499]  [<c165a68d>] sysenter_do_call+0x12/0x28
[  161.003505] Code: 0f b6 4d f3 8d 51 0f 83 e1 f0 83 e2 0f 09 d1 84 d2 88 48 54 75 07 80 a7 91 00 00 00 7f 83 c4 04 5b 5e 5f 5d c3 8d b6 00 00 00 00 <0f> 0b 8d b6 00 00 00 00 55 89 e5 57 56 53 83 ec 64 3e 8d 74 26
[  161.003586] EIP: [<f84861f8>] i915_gem_object_ggtt_unpin+0x88/0x90 [i915] SS:ESP 0068:dbe0fe0c

v2: Rename the local variable (is_default_ctx) to avoid confusion with
the function is_default_ctx(). And correct Jesse's email address.

Reported-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=73985
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Ben Widawsky <benjamin.widawsky@intel.com>
Tested-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Reviewed-by: Ben Widawsky <benjamin.widawsky@intel.com>
[danvet: Fix up the rebase fail from my first attempt, thankfully
pointed out by Ville.]
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
2014-01-27 17:16:10 +01:00
..
armada Merge branch 'drm-intel-next' of git://people.freedesktop.org/~danvet/drm-intel into drm-next 2014-01-20 10:21:54 +10:00
ast drivers: gpu: Mark functions as static in ast_ttm.c 2014-01-14 12:59:16 +10:00
bochs drm/bochs: new driver 2013-12-23 11:02:39 +10:00
cirrus drivers: gpu: Mark functions as static and remove unused function in cirrus_ttm.c 2014-01-14 12:59:19 +10:00
exynos drm/exynos: fix build error caused by removed drm core macros 2014-01-07 16:53:25 +09:00
gma500 drm/gma500: Remove unused function declaration 2014-01-14 12:38:40 +10:00
i2c drm/i2c: tda998x: set VIF for full range, underscanned display 2013-10-18 15:58:32 +01:00
i810 drm: kill DRIVER_REQUIRE_AGP 2013-12-18 11:17:53 +10:00
i915 drm/i915: Always pin the default context 2014-01-27 17:16:10 +01:00
mga drivers: gpu: Include appropriate header file in mga_ioc32.c 2014-01-14 12:59:24 +10:00
mgag200 drm/mgag200: fix oops in cursor code. 2014-01-16 14:43:04 +10:00
msm drm: store the gem vma offset manager in a typed pointer 2014-01-14 12:38:32 +10:00
nouveau Merge branch 'drm-intel-next' of git://people.freedesktop.org/~danvet/drm-intel into drm-next 2014-01-20 10:21:54 +10:00
omapdrm drm: store the gem vma offset manager in a typed pointer 2014-01-14 12:38:32 +10:00
panel drm/panel: Add support for Panasonic VVX10F004B0 2013-12-17 18:09:58 +01:00
qxl gpu: fix qxl missing crc32_le 2014-01-14 13:08:37 +10:00
r128 drivers: gpu: Include appropriate header file in r128_ioc32.c 2014-01-14 13:05:37 +10:00
radeon Merge branch 'drm-vbl-timestamp' of git://gitorious.org/vsyrjala/linux into drm-next 2014-01-22 09:13:13 +10:00
rcar-du Merge branch 'drm/next/du' of git://linuxtv.org/pinchartl/fbdev into drm-next 2013-12-23 10:42:36 +10:00
savage drm: Kill DRM_*MEMORYBARRIER 2013-12-18 11:35:21 +10:00
shmobile drm/shmob: call drm_put_dev directly from ->remove hook 2013-12-18 11:05:46 +10:00
sis drivers: gpu: Mark function as static in sis_drv.c 2014-01-14 13:04:33 +10:00
tdfx
tegra drm/tegra: Changes for v3.14-rc1 2013-12-23 10:43:42 +10:00
tilcdc drm: store the gem vma offset manager in a typed pointer 2014-01-14 12:38:32 +10:00
ttm Merge branch 'drm-intel-next' of git://people.freedesktop.org/~danvet/drm-intel into drm-next 2014-01-20 10:21:54 +10:00
udl drm: Push dirtyfb ioctl kms locking down to drivers 2013-12-18 10:49:08 +10:00
via drivers: gpu: Mark function as static in via_drv.c 2014-01-14 13:05:00 +10:00
vmwgfx drm/vmwgfx: Fix recently introduced sparse / smatch warnings and errors 2014-01-21 13:22:18 +01:00
ati_pcigart.c
drm_agpsupport.c drm: rip out DRM_AGP_MEM and DRM_AGP_KERN 2013-12-18 11:32:55 +10:00
drm_auth.c
drm_buffer.c drm: Kill DRM_COPY_(TO|FROM)_USER 2013-12-18 11:35:01 +10:00
drm_bufs.c drm: rip out drm_core_has_AGP 2013-12-18 11:20:04 +10:00
drm_cache.c
drm_context.c
drm_crtc_helper.c drm: Pass the display mode to drm_calc_timestamping_constants() 2014-01-20 11:04:46 +02:00
drm_crtc.c drm: Push dirtyfb ioctl kms locking down to drivers 2013-12-18 10:49:08 +10:00
drm_debugfs.c drm: Make drm_debugfs_list const 2013-11-06 12:05:21 +10:00
drm_dma.c
drm_dp_helper.c
drm_drv.c drm: Kill file_priv->ioctl_count tracking 2013-12-18 11:42:13 +10:00
drm_edid_load.c drm/edid: Make edid_load() return a void * 2013-12-18 10:42:13 +10:00
drm_edid.c drm/edid: Populate picture aspect ratio for CEA modes 2014-01-20 18:32:21 +01:00
drm_encoder_slave.c
drm_fb_cma_helper.c
drm_fb_helper.c drm: do not steal the display if we have a master 2013-12-18 10:47:20 +10:00
drm_flip_work.c kfifo API type safety 2013-11-15 09:32:23 +09:00
drm_fops.c drm: remove dev->vma_count 2013-12-18 11:43:29 +10:00
drm_gem_cma_helper.c
drm_gem.c drm/gem: Always initialize the gem object in object_init 2014-01-21 10:19:58 +01:00
drm_global.c
drm_hashtab.c
drm_info.c drm: remove dev->vma_count 2013-12-18 11:43:29 +10:00
drm_ioc32.c
drm_ioctl.c
drm_irq.c drm/radeon: Move the early vblank IRQ fixup to radeon_get_crtc_scanoutpos() 2014-01-20 12:21:35 +02:00
drm_lock.c
drm_memory.c drm: rip out DRM_AGP_MEM and DRM_AGP_KERN 2013-12-18 11:32:55 +10:00
drm_mipi_dsi.c drm: Add MIPI DSI bus support 2013-12-17 18:09:43 +01:00
drm_mm.c
drm_modes.c Revert "drm: copy mode type in drm_mode_connector_list_update()" 2014-01-14 12:50:49 +10:00
drm_panel.c drm: Add panel support 2013-12-17 18:09:46 +01:00
drm_pci.c drm: remove global_mutex locking around agp_init 2013-12-18 11:27:29 +10:00
drm_platform.c drm: restrict the device list for shadow attached drivers 2013-12-18 11:08:36 +10:00
drm_prime.c
drm_rect.c
drm_scatter.c
drm_stub.c Merge branch 'drm-intel-next' of git://people.freedesktop.org/~danvet/drm-intel into drm-next 2014-01-20 10:21:54 +10:00
drm_sysfs.c drm/sysfs: fix OOM verification 2013-11-28 14:35:23 +10:00
drm_trace_points.c
drm_trace.h
drm_usb.c drivers: gpu: Include appropriate header file in drm_usb.c 2014-01-14 12:53:41 +10:00
drm_vm.c drm: remove dev->vma_count 2013-12-18 11:43:29 +10:00
drm_vma_manager.c
Kconfig drm/bochs: new driver 2013-12-23 11:02:39 +10:00
Makefile drm/bochs: new driver 2013-12-23 11:02:39 +10:00
README.drm

************************************************************
* For the very latest on DRI development, please see:      *
*     http://dri.freedesktop.org/                          *
************************************************************

The Direct Rendering Manager (drm) is a device-independent kernel-level
device driver that provides support for the XFree86 Direct Rendering
Infrastructure (DRI).

The DRM supports the Direct Rendering Infrastructure (DRI) in four major
ways:

    1. The DRM provides synchronized access to the graphics hardware via
       the use of an optimized two-tiered lock.

    2. The DRM enforces the DRI security policy for access to the graphics
       hardware by only allowing authenticated X11 clients access to
       restricted regions of memory.

    3. The DRM provides a generic DMA engine, complete with multiple
       queues and the ability to detect the need for an OpenGL context
       switch.

    4. The DRM is extensible via the use of small device-specific modules
       that rely extensively on the API exported by the DRM module.


Documentation on the DRI is available from:
    http://dri.freedesktop.org/wiki/Documentation
    http://sourceforge.net/project/showfiles.php?group_id=387
    http://dri.sourceforge.net/doc/

For specific information about kernel-level support, see:

    The Direct Rendering Manager, Kernel Support for the Direct Rendering
    Infrastructure
    http://dri.sourceforge.net/doc/drm_low_level.html

    Hardware Locking for the Direct Rendering Infrastructure
    http://dri.sourceforge.net/doc/hardware_locking_low_level.html

    A Security Analysis of the Direct Rendering Infrastructure
    http://dri.sourceforge.net/doc/security_low_level.html