Oleg Nesterov 41ccba029e uprobes: Shift ->readpage check from __copy_insn() to uprobe_register() ... copy_insn() fails with -EIO if ->readpage == NULL, but this error is not propagated unless uprobe_register() path finds ->mm which already mmaps this file. In this case (say) "perf record" does not actually install the probe, but the user can't know about this. Move this check into uprobe_register() so that this problem can be detected earlier and reported to user. Note: this is still not perfect, - copy_insn() and arch_uprobe_analyze_insn() should be called by uprobe_register() but this is not simple, we need vm_file for read_mapping_page() (although perhaps we can pass NULL), and we need ->mm for is_64bit_mm() (although this logic is broken anyway). - uprobe_register() should be called by create_trace_uprobe(), not by probe_event_enable(), so that an error can be detected at "perf probe -x" time. This also needs more changes in the core uprobe code, uprobe register/unregister interface was poorly designed from the very beginning. Reported-by: Denys Vlasenko <dvlasenk@redhat.com> Signed-off-by: Oleg Nesterov <oleg@redhat.com> Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com> Signed-off-by: Peter Zijlstra <peterz@infradead.org> Cc: Hugh Dickins <hughd@google.com> Cc: Arnaldo Carvalho de Melo <acme@kernel.org> Cc: Linus Torvalds <torvalds@linux-foundation.org> Link: http://lkml.kernel.org/r/20140519184054.GA6750@redhat.com Signed-off-by: Ingo Molnar <mingo@kernel.org>		2014-06-05 12:30:07 +02:00
..
callchain.c	perf: Roll back callchain buffer refcount under the callchain mutex	2013-08-16 17:55:50 +02:00
core.c	perf: Disable sampled events if no PMU interrupt	2014-06-05 12:29:55 +02:00
hw_breakpoint.c	hw_breakpoint: Introduce "struct bp_cpuinfo"	2013-06-20 17:58:57 +02:00
internal.h	perf: Fix arch_perf_out_copy_user default	2013-11-06 12:34:25 +01:00
Makefile	uprobes: Move to kernel/events/	2012-02-22 11:08:00 +01:00
ring_buffer.c	perf: Optimize ring-buffer write by depending on control dependencies	2013-12-11 15:53:22 +01:00
uprobes.c	uprobes: Shift ->readpage check from __copy_insn() to uprobe_register()	2014-06-05 12:30:07 +02:00