Jan Kara c872674da7 dax: fix ENOMEM handling in grab_mapping_entry() ... [ Upstream commit 1a14e3779dd58c16b30e56558146e5cc850ba8b0 ] grab_mapping_entry() has a bug in handling of ENOMEM condition. Suppose we have a PMD entry at index i which we are downgrading to a PTE entry. grab_mapping_entry() will set pmd_downgrade to true, lock the entry, clear the entry in xarray, and decrement mapping->nrpages. The it will call: entry = dax_make_entry(pfn_to_pfn_t(0), flags); dax_lock_entry(xas, entry); which inserts new PTE entry into xarray. However this may fail allocating the new node. We handle this by: if (xas_nomem(xas, mapping_gfp_mask(mapping) & ~__GFP_HIGHMEM)) goto retry; however pmd_downgrade stays set to true even though 'entry' returned from get_unlocked_entry() will be NULL now. And we will go again through the downgrade branch. This is mostly harmless except that mapping->nrpages is decremented again and we temporarily have an invalid entry stored in xarray. Fix the problem by setting pmd_downgrade to false each time we lookup the entry we work with so that it matches the entry we found. Link: https://lkml.kernel.org/r/20210622160015.18004-1-jack@suse.cz Fixes: b15cd80068 ("dax: Convert page fault handlers to XArray") Signed-off-by: Jan Kara <jack@suse.cz> Reviewed-by: Dan Williams <dan.j.williams@intel.com> Cc: Matthew Wilcox <willy@infradead.org> Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2021-07-14 16:56:13 +02:00
..
9p
adfs
affs	fs/affs: release old buffer head on error path	2021-03-04 11:38:37 +01:00
afs	afs: Fix an IS_ERR() vs NULL check	2021-06-23 14:42:40 +02:00
autofs
befs
bfs
btrfs	btrfs: clear log tree recovering status if starting transaction fails	2021-07-14 16:56:09 +02:00
cachefiles	fs/cachefiles: Remove wait_bit_key layout dependency	2021-03-30 14:32:07 +02:00
ceph	netfs: fix test for whether we can skip read when writing beyond EOF	2021-06-30 08:47:29 -04:00
cifs	cifs: fix missing spinlock around update to ses->status	2021-07-14 16:56:01 +02:00
coda
configfs	configfs: fix a use-after-free in __configfs_open_file	2021-03-17 17:06:34 +01:00
cramfs
crypto
debugfs	debugfs: Make debugfs_allow RO after init	2021-05-19 10:13:19 +02:00
devpts
dlm	fs: dlm: fix memory leak when fenced	2021-07-14 16:55:59 +02:00
ecryptfs	Revert "ecryptfs: replace BUG_ON with error handling code"	2021-05-26 12:06:55 +02:00
efivarfs
efs
erofs	erofs: add unsupported inode i_format check	2021-05-11 14:47:13 +02:00
exfat	exfat: fix erroneous discard when clear cluster bit	2021-05-11 14:47:36 +02:00
exportfs
ext2
ext4	ext4: use ext4_grp_locked_error in mb_find_extent	2021-07-14 16:55:41 +02:00
f2fs	f2fs: Prevent swap file in LFS mode	2021-07-14 16:55:43 +02:00
fat
freevxfs
fscache
fuse	fuse: reject internal errno	2021-07-14 16:55:47 +02:00
gfs2	gfs2: Fix error handling in init_statfs	2021-07-14 16:55:38 +02:00
hfs
hfsplus	hfsplus: prevent corruption in shrinking truncate	2021-05-19 10:13:10 +02:00
hostfs	hostfs: fix memory handling in follow_link()	2021-04-14 08:42:06 +02:00
hpfs
hugetlbfs	mm/hugetlb: fix F_SEAL_FUTURE_WRITE	2021-05-19 10:13:11 +02:00
iomap	iomap: Fix negative assignment to unsigned sis->pages in iomap_swapfile_activate	2021-04-07 15:00:04 +02:00
isofs	isofs: release buffer head before return	2021-03-04 11:38:00 +01:00
jbd2	ext4: fix debug format string warning	2021-05-19 10:13:19 +02:00
jffs2	jffs2: check the validity of dstlen in jffs2_zlib_compress()	2021-05-11 14:47:36 +02:00
jfs	JFS: more checks for invalid superblock	2021-03-07 12:34:04 +01:00
kernfs	kernfs: wire up ->splice_read and ->splice_write	2021-01-27 11:55:29 +01:00
lockd
minix
nfs	NFSv4: nfs4_proc_set_acl needs to restore NFS_CAP_UIDGID_NOMAP on error.	2021-06-16 12:01:47 +02:00
nfs_common
nfsd	nfsd: ensure new clients break delegations	2021-05-19 10:13:03 +02:00
nilfs2	nilfs2: fix memory leak in nilfs_sysfs_delete_device_group	2021-06-30 08:47:24 -04:00
nls
notify	fanotify: fix copy_event_to_user() fid error clean up	2021-06-23 14:42:41 +02:00
ntfs	ntfs: fix validity check for file name attribute	2021-07-14 16:55:38 +02:00
ocfs2	ocfs2: fix snprintf() checking	2021-07-14 16:56:13 +02:00
omfs
openpromfs
orangefs
overlayfs	ovl: invalidate readdir cache on changes to dir with origin	2021-05-14 09:50:35 +02:00
proc	proc: only require mm_struct for writing	2021-06-16 12:01:47 +02:00
pstore	mark pstore-blk as broken	2021-07-14 16:56:12 +02:00
qnx4
qnx6
quota	quota: Fix memory leak when handling corrupted quota file	2021-03-04 11:37:53 +01:00
ramfs
reiserfs	reiserfs: update reiserfs_xattrs_initialized() condition	2021-04-07 15:00:10 +02:00
romfs
squashfs	squashfs: fix divide error in calculate_skip()	2021-05-19 10:13:10 +02:00
sysfs
sysv
tracefs
ubifs	ubifs: Only check replay with inode type to judge if inode linked	2021-05-11 14:47:33 +02:00
udf	udf: fix silent AED tagLocation corruption	2021-03-17 17:06:23 +01:00
ufs
unicode
vboxsf
verity
xfs	xfs: fix return of uninitialized value in variable error	2021-05-14 09:50:34 +02:00
zonefs	zonefs: fix to update .i_wr_refcnt correctly in zonefs_open_zone()	2021-03-25 09:04:05 +01:00
aio.c
anon_inodes.c
attr.c
bad_inode.c
binfmt_aout.c
binfmt_elf_fdpic.c
binfmt_elf.c
binfmt_em86.c
binfmt_flat.c
binfmt_misc.c	binfmt_misc: fix possible deadlock in bm_register_write	2021-03-17 17:06:35 +01:00
binfmt_script.c
block_dev.c	block: fix a race between del_gendisk and BLKRRPART	2021-06-03 09:00:45 +02:00
buffer.c
char_dev.c
compat_binfmt_elf.c
coredump.c
d_path.c
dax.c	dax: fix ENOMEM handling in grab_mapping_entry()	2021-07-14 16:56:13 +02:00
dcache.c
dcookies.c
direct-io.c	fs: direct-io: fix missing sdio->boundary	2021-04-14 08:41:58 +02:00
drop_caches.c
eventfd.c
eventpoll.c	fs/epoll: restore waking from ep_done_scan()	2021-05-11 14:47:12 +02:00
exec.c	Add a reference to ucounts for each cred	2021-07-14 16:55:48 +02:00
fcntl.c
fhandle.c
file_table.c
file.c	kernel/io_uring: cancel io_uring before task works	2021-01-30 13:55:18 +01:00
filesystems.c
fs_context.c
fs_parser.c
fs_pin.c
fs_struct.c
fs_types.c
fs-writeback.c	writeback, cgroup: increment isw_nr_in_flight before grabbing an inode	2021-07-14 16:56:02 +02:00
fsopen.c
init.c
inode.c
internal.h
io_uring.c	io_uring: use better types for cflags	2021-06-10 13:39:23 +02:00
io-wq.c	io_uring: always batch cancel in *cancel_files()	2021-02-13 13:54:56 +01:00
io-wq.h	io_uring: always batch cancel in *cancel_files()	2021-02-13 13:54:56 +01:00
ioctl.c
Kconfig	tmpfs: disallow CONFIG_TMPFS_INODE64 on alpha	2021-02-17 11:02:21 +01:00
Kconfig.binfmt
kernel_read_file.c
libfs.c
locks.c	Revert "nfsd4: a client's own opens needn't prevent delegations"	2021-03-20 10:43:44 +01:00
Makefile
mbcache.c
mount.h
mpage.c
namei.c	LOOKUP_MOUNTPOINT: we are cleaning "jumped" flag too late	2021-04-14 08:41:58 +02:00
namespace.c	umount(2): move the flag validity checks first	2021-01-19 18:27:32 +01:00
no-block.c
nsfs.c
open.c	open: don't silently ignore unknown O-flags in openat2()	2021-07-14 16:55:59 +02:00
pipe.c	fs/pipe: allow sendfile() to pipe again	2021-01-27 11:55:29 +01:00
pnode.c
pnode.h	mount: fix mounting of detached mounts onto targets that reside on shared mounts	2021-03-17 17:06:13 +01:00
posix_acl.c
proc_namespace.c
read_write.c
readdir.c	readdir: make sure to verify directory entry for legacy interfaces too	2021-04-21 13:00:54 +02:00
remap_range.c
select.c	kernel, fs: Introduce and use set_restart_fn() and arch_set_restart_data()	2021-03-25 09:04:16 +01:00
seq_file.c
signalfd.c
splice.c
stack.c
stat.c	fs: fix reporting supported extra file attributes for statx()	2021-05-11 14:47:33 +02:00
statfs.c
super.c
sync.c
timerfd.c
userfaultfd.c
utimes.c
xattr.c