mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-16 00:56:49 +07:00
0ad83caa21
If you try to enable NOHZ_FULL on a guest today, you'll get the following error when the guest tries to deactivate the scheduler tick: WARNING: CPU: 3 PID: 2182 at kernel/time/tick-sched.c:192 can_stop_full_tick+0xb9/0x290() NO_HZ FULL will not work with unstable sched clock CPU: 3 PID: 2182 Comm: kworker/3:1 Not tainted 4.0.0-10545-gb9bb6fb #204 Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011 Workqueue: events flush_to_ldisc ffffffff8162a0c7 ffff88011f583e88 ffffffff814e6ba0 0000000000000002 ffff88011f583ed8 ffff88011f583ec8 ffffffff8104d095 ffff88011f583eb8 0000000000000000 0000000000000003 0000000000000001 0000000000000001 Call Trace: <IRQ> [<ffffffff814e6ba0>] dump_stack+0x4f/0x7b [<ffffffff8104d095>] warn_slowpath_common+0x85/0xc0 [<ffffffff8104d146>] warn_slowpath_fmt+0x46/0x50 [<ffffffff810bd2a9>] can_stop_full_tick+0xb9/0x290 [<ffffffff810bd9ed>] tick_nohz_irq_exit+0x8d/0xb0 [<ffffffff810511c5>] irq_exit+0xc5/0x130 [<ffffffff814f180a>] smp_apic_timer_interrupt+0x4a/0x60 [<ffffffff814eff5e>] apic_timer_interrupt+0x6e/0x80 <EOI> [<ffffffff814ee5d1>] ? _raw_spin_unlock_irqrestore+0x31/0x60 [<ffffffff8108bbc8>] __wake_up+0x48/0x60 [<ffffffff8134836c>] n_tty_receive_buf_common+0x49c/0xba0 [<ffffffff8134a6bf>] ? tty_ldisc_ref+0x1f/0x70 [<ffffffff81348a84>] n_tty_receive_buf2+0x14/0x20 [<ffffffff8134b390>] flush_to_ldisc+0xe0/0x120 [<ffffffff81064d05>] process_one_work+0x1d5/0x540 [<ffffffff81064c81>] ? process_one_work+0x151/0x540 [<ffffffff81065191>] worker_thread+0x121/0x470 [<ffffffff81065070>] ? process_one_work+0x540/0x540 [<ffffffff8106b4df>] kthread+0xef/0x110 [<ffffffff8106b3f0>] ? __kthread_parkme+0xa0/0xa0 [<ffffffff814ef4f2>] ret_from_fork+0x42/0x70 [<ffffffff8106b3f0>] ? __kthread_parkme+0xa0/0xa0 ---[ end trace 06e3507544a38866 ]--- However, it turns out that kvmclock does provide a stable sched_clock callback. So, let the scheduler know this which in turn makes NOHZ_FULL work in the guest. Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
315 lines
7.6 KiB
C
315 lines
7.6 KiB
C
/* KVM paravirtual clock driver. A clocksource implementation
|
|
Copyright (C) 2008 Glauber de Oliveira Costa, Red Hat Inc.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
|
|
*/
|
|
|
|
#include <linux/clocksource.h>
|
|
#include <linux/kvm_para.h>
|
|
#include <asm/pvclock.h>
|
|
#include <asm/msr.h>
|
|
#include <asm/apic.h>
|
|
#include <linux/percpu.h>
|
|
#include <linux/hardirq.h>
|
|
#include <linux/memblock.h>
|
|
#include <linux/sched.h>
|
|
|
|
#include <asm/x86_init.h>
|
|
#include <asm/reboot.h>
|
|
|
|
static int kvmclock = 1;
|
|
static int msr_kvm_system_time = MSR_KVM_SYSTEM_TIME;
|
|
static int msr_kvm_wall_clock = MSR_KVM_WALL_CLOCK;
|
|
|
|
static int parse_no_kvmclock(char *arg)
|
|
{
|
|
kvmclock = 0;
|
|
return 0;
|
|
}
|
|
early_param("no-kvmclock", parse_no_kvmclock);
|
|
|
|
/* The hypervisor will put information about time periodically here */
|
|
static struct pvclock_vsyscall_time_info *hv_clock;
|
|
static struct pvclock_wall_clock wall_clock;
|
|
|
|
/*
|
|
* The wallclock is the time of day when we booted. Since then, some time may
|
|
* have elapsed since the hypervisor wrote the data. So we try to account for
|
|
* that with system time
|
|
*/
|
|
static void kvm_get_wallclock(struct timespec *now)
|
|
{
|
|
struct pvclock_vcpu_time_info *vcpu_time;
|
|
int low, high;
|
|
int cpu;
|
|
|
|
low = (int)__pa_symbol(&wall_clock);
|
|
high = ((u64)__pa_symbol(&wall_clock) >> 32);
|
|
|
|
native_write_msr(msr_kvm_wall_clock, low, high);
|
|
|
|
cpu = get_cpu();
|
|
|
|
vcpu_time = &hv_clock[cpu].pvti;
|
|
pvclock_read_wallclock(&wall_clock, vcpu_time, now);
|
|
|
|
put_cpu();
|
|
}
|
|
|
|
static int kvm_set_wallclock(const struct timespec *now)
|
|
{
|
|
return -1;
|
|
}
|
|
|
|
static cycle_t kvm_clock_read(void)
|
|
{
|
|
struct pvclock_vcpu_time_info *src;
|
|
cycle_t ret;
|
|
int cpu;
|
|
|
|
preempt_disable_notrace();
|
|
cpu = smp_processor_id();
|
|
src = &hv_clock[cpu].pvti;
|
|
ret = pvclock_clocksource_read(src);
|
|
preempt_enable_notrace();
|
|
return ret;
|
|
}
|
|
|
|
static cycle_t kvm_clock_get_cycles(struct clocksource *cs)
|
|
{
|
|
return kvm_clock_read();
|
|
}
|
|
|
|
/*
|
|
* If we don't do that, there is the possibility that the guest
|
|
* will calibrate under heavy load - thus, getting a lower lpj -
|
|
* and execute the delays themselves without load. This is wrong,
|
|
* because no delay loop can finish beforehand.
|
|
* Any heuristics is subject to fail, because ultimately, a large
|
|
* poll of guests can be running and trouble each other. So we preset
|
|
* lpj here
|
|
*/
|
|
static unsigned long kvm_get_tsc_khz(void)
|
|
{
|
|
struct pvclock_vcpu_time_info *src;
|
|
int cpu;
|
|
unsigned long tsc_khz;
|
|
|
|
cpu = get_cpu();
|
|
src = &hv_clock[cpu].pvti;
|
|
tsc_khz = pvclock_tsc_khz(src);
|
|
put_cpu();
|
|
return tsc_khz;
|
|
}
|
|
|
|
static void kvm_get_preset_lpj(void)
|
|
{
|
|
unsigned long khz;
|
|
u64 lpj;
|
|
|
|
khz = kvm_get_tsc_khz();
|
|
|
|
lpj = ((u64)khz * 1000);
|
|
do_div(lpj, HZ);
|
|
preset_lpj = lpj;
|
|
}
|
|
|
|
bool kvm_check_and_clear_guest_paused(void)
|
|
{
|
|
bool ret = false;
|
|
struct pvclock_vcpu_time_info *src;
|
|
int cpu = smp_processor_id();
|
|
|
|
if (!hv_clock)
|
|
return ret;
|
|
|
|
src = &hv_clock[cpu].pvti;
|
|
if ((src->flags & PVCLOCK_GUEST_STOPPED) != 0) {
|
|
src->flags &= ~PVCLOCK_GUEST_STOPPED;
|
|
pvclock_touch_watchdogs();
|
|
ret = true;
|
|
}
|
|
|
|
return ret;
|
|
}
|
|
|
|
static struct clocksource kvm_clock = {
|
|
.name = "kvm-clock",
|
|
.read = kvm_clock_get_cycles,
|
|
.rating = 400,
|
|
.mask = CLOCKSOURCE_MASK(64),
|
|
.flags = CLOCK_SOURCE_IS_CONTINUOUS,
|
|
};
|
|
|
|
int kvm_register_clock(char *txt)
|
|
{
|
|
int cpu = smp_processor_id();
|
|
int low, high, ret;
|
|
struct pvclock_vcpu_time_info *src;
|
|
|
|
if (!hv_clock)
|
|
return 0;
|
|
|
|
src = &hv_clock[cpu].pvti;
|
|
low = (int)slow_virt_to_phys(src) | 1;
|
|
high = ((u64)slow_virt_to_phys(src) >> 32);
|
|
ret = native_write_msr_safe(msr_kvm_system_time, low, high);
|
|
printk(KERN_INFO "kvm-clock: cpu %d, msr %x:%x, %s\n",
|
|
cpu, high, low, txt);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static void kvm_save_sched_clock_state(void)
|
|
{
|
|
}
|
|
|
|
static void kvm_restore_sched_clock_state(void)
|
|
{
|
|
kvm_register_clock("primary cpu clock, resume");
|
|
}
|
|
|
|
#ifdef CONFIG_X86_LOCAL_APIC
|
|
static void kvm_setup_secondary_clock(void)
|
|
{
|
|
/*
|
|
* Now that the first cpu already had this clocksource initialized,
|
|
* we shouldn't fail.
|
|
*/
|
|
WARN_ON(kvm_register_clock("secondary cpu clock"));
|
|
}
|
|
#endif
|
|
|
|
/*
|
|
* After the clock is registered, the host will keep writing to the
|
|
* registered memory location. If the guest happens to shutdown, this memory
|
|
* won't be valid. In cases like kexec, in which you install a new kernel, this
|
|
* means a random memory location will be kept being written. So before any
|
|
* kind of shutdown from our side, we unregister the clock by writting anything
|
|
* that does not have the 'enable' bit set in the msr
|
|
*/
|
|
#ifdef CONFIG_KEXEC
|
|
static void kvm_crash_shutdown(struct pt_regs *regs)
|
|
{
|
|
native_write_msr(msr_kvm_system_time, 0, 0);
|
|
kvm_disable_steal_time();
|
|
native_machine_crash_shutdown(regs);
|
|
}
|
|
#endif
|
|
|
|
static void kvm_shutdown(void)
|
|
{
|
|
native_write_msr(msr_kvm_system_time, 0, 0);
|
|
kvm_disable_steal_time();
|
|
native_machine_shutdown();
|
|
}
|
|
|
|
void __init kvmclock_init(void)
|
|
{
|
|
struct pvclock_vcpu_time_info *vcpu_time;
|
|
unsigned long mem;
|
|
int size, cpu;
|
|
u8 flags;
|
|
|
|
size = PAGE_ALIGN(sizeof(struct pvclock_vsyscall_time_info)*NR_CPUS);
|
|
|
|
if (!kvm_para_available())
|
|
return;
|
|
|
|
if (kvmclock && kvm_para_has_feature(KVM_FEATURE_CLOCKSOURCE2)) {
|
|
msr_kvm_system_time = MSR_KVM_SYSTEM_TIME_NEW;
|
|
msr_kvm_wall_clock = MSR_KVM_WALL_CLOCK_NEW;
|
|
} else if (!(kvmclock && kvm_para_has_feature(KVM_FEATURE_CLOCKSOURCE)))
|
|
return;
|
|
|
|
printk(KERN_INFO "kvm-clock: Using msrs %x and %x",
|
|
msr_kvm_system_time, msr_kvm_wall_clock);
|
|
|
|
mem = memblock_alloc(size, PAGE_SIZE);
|
|
if (!mem)
|
|
return;
|
|
hv_clock = __va(mem);
|
|
memset(hv_clock, 0, size);
|
|
|
|
if (kvm_register_clock("primary cpu clock")) {
|
|
hv_clock = NULL;
|
|
memblock_free(mem, size);
|
|
return;
|
|
}
|
|
pv_time_ops.sched_clock = kvm_clock_read;
|
|
x86_platform.calibrate_tsc = kvm_get_tsc_khz;
|
|
x86_platform.get_wallclock = kvm_get_wallclock;
|
|
x86_platform.set_wallclock = kvm_set_wallclock;
|
|
#ifdef CONFIG_X86_LOCAL_APIC
|
|
x86_cpuinit.early_percpu_clock_init =
|
|
kvm_setup_secondary_clock;
|
|
#endif
|
|
x86_platform.save_sched_clock_state = kvm_save_sched_clock_state;
|
|
x86_platform.restore_sched_clock_state = kvm_restore_sched_clock_state;
|
|
machine_ops.shutdown = kvm_shutdown;
|
|
#ifdef CONFIG_KEXEC
|
|
machine_ops.crash_shutdown = kvm_crash_shutdown;
|
|
#endif
|
|
kvm_get_preset_lpj();
|
|
clocksource_register_hz(&kvm_clock, NSEC_PER_SEC);
|
|
pv_info.name = "KVM";
|
|
|
|
if (kvm_para_has_feature(KVM_FEATURE_CLOCKSOURCE_STABLE_BIT))
|
|
pvclock_set_flags(~0);
|
|
|
|
cpu = get_cpu();
|
|
vcpu_time = &hv_clock[cpu].pvti;
|
|
flags = pvclock_read_flags(vcpu_time);
|
|
if (flags & PVCLOCK_COUNTS_FROM_ZERO)
|
|
set_sched_clock_stable();
|
|
put_cpu();
|
|
}
|
|
|
|
int __init kvm_setup_vsyscall_timeinfo(void)
|
|
{
|
|
#ifdef CONFIG_X86_64
|
|
int cpu;
|
|
int ret;
|
|
u8 flags;
|
|
struct pvclock_vcpu_time_info *vcpu_time;
|
|
unsigned int size;
|
|
|
|
if (!hv_clock)
|
|
return 0;
|
|
|
|
size = PAGE_ALIGN(sizeof(struct pvclock_vsyscall_time_info)*NR_CPUS);
|
|
|
|
cpu = get_cpu();
|
|
|
|
vcpu_time = &hv_clock[cpu].pvti;
|
|
flags = pvclock_read_flags(vcpu_time);
|
|
|
|
if (!(flags & PVCLOCK_TSC_STABLE_BIT)) {
|
|
put_cpu();
|
|
return 1;
|
|
}
|
|
|
|
if ((ret = pvclock_init_vsyscall(hv_clock, size))) {
|
|
put_cpu();
|
|
return ret;
|
|
}
|
|
|
|
put_cpu();
|
|
|
|
kvm_clock.archdata.vclock_mode = VCLOCK_PVCLOCK;
|
|
#endif
|
|
return 0;
|
|
}
|