mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-15 20:26:48 +07:00
7652ac9201
The pinning of sensitive CR0 and CR4 bits caused a boot crash when loading the kvm_intel module on a kernel compiled with CONFIG_PARAVIRT=n. The reason is that the static key which controls the pinning is marked RO after init. The kvm_intel module contains a CR4 write which requires to update the static key entry list. That obviously does not work when the key is in a RO section. With CONFIG_PARAVIRT enabled this does not happen because the CR4 write uses the paravirt indirection and the actual write function is built in. As the key is intended to be immutable after init, move native_write_cr0/4() out of line. While at it consolidate the update of the cr4 shadow variable and store the value right away when the pinning is initialized on a booting CPU. No point in reading it back 20 instructions later. This allows to confine the static key and the pinning variable to cpu/common and allows to mark them static. Fixes:8dbec27a24
("x86/asm: Pin sensitive CR0 bits") Fixes:873d50d58f
("x86/asm: Pin sensitive CR4 bits") Reported-by: Linus Torvalds <torvalds@linux-foundation.org> Reported-by: Xi Ruoyao <xry111@mengyan1223.wang> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Tested-by: Xi Ruoyao <xry111@mengyan1223.wang> Acked-by: Kees Cook <keescook@chromium.org> Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org> Link: https://lkml.kernel.org/r/alpine.DEB.2.21.1907102140340.1758@nanos.tec.linutronix.de
255 lines
5.1 KiB
C
255 lines
5.1 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef _ASM_X86_SPECIAL_INSNS_H
|
|
#define _ASM_X86_SPECIAL_INSNS_H
|
|
|
|
|
|
#ifdef __KERNEL__
|
|
|
|
#include <asm/nops.h>
|
|
#include <asm/processor-flags.h>
|
|
#include <linux/jump_label.h>
|
|
|
|
/*
|
|
* Volatile isn't enough to prevent the compiler from reordering the
|
|
* read/write functions for the control registers and messing everything up.
|
|
* A memory clobber would solve the problem, but would prevent reordering of
|
|
* all loads stores around it, which can hurt performance. Solution is to
|
|
* use a variable and mimic reads and writes to it to enforce serialization
|
|
*/
|
|
extern unsigned long __force_order;
|
|
|
|
void native_write_cr0(unsigned long val);
|
|
|
|
static inline unsigned long native_read_cr0(void)
|
|
{
|
|
unsigned long val;
|
|
asm volatile("mov %%cr0,%0\n\t" : "=r" (val), "=m" (__force_order));
|
|
return val;
|
|
}
|
|
|
|
static inline unsigned long native_read_cr2(void)
|
|
{
|
|
unsigned long val;
|
|
asm volatile("mov %%cr2,%0\n\t" : "=r" (val), "=m" (__force_order));
|
|
return val;
|
|
}
|
|
|
|
static inline void native_write_cr2(unsigned long val)
|
|
{
|
|
asm volatile("mov %0,%%cr2": : "r" (val), "m" (__force_order));
|
|
}
|
|
|
|
static inline unsigned long __native_read_cr3(void)
|
|
{
|
|
unsigned long val;
|
|
asm volatile("mov %%cr3,%0\n\t" : "=r" (val), "=m" (__force_order));
|
|
return val;
|
|
}
|
|
|
|
static inline void native_write_cr3(unsigned long val)
|
|
{
|
|
asm volatile("mov %0,%%cr3": : "r" (val), "m" (__force_order));
|
|
}
|
|
|
|
static inline unsigned long native_read_cr4(void)
|
|
{
|
|
unsigned long val;
|
|
#ifdef CONFIG_X86_32
|
|
/*
|
|
* This could fault if CR4 does not exist. Non-existent CR4
|
|
* is functionally equivalent to CR4 == 0. Keep it simple and pretend
|
|
* that CR4 == 0 on CPUs that don't have CR4.
|
|
*/
|
|
asm volatile("1: mov %%cr4, %0\n"
|
|
"2:\n"
|
|
_ASM_EXTABLE(1b, 2b)
|
|
: "=r" (val), "=m" (__force_order) : "0" (0));
|
|
#else
|
|
/* CR4 always exists on x86_64. */
|
|
asm volatile("mov %%cr4,%0\n\t" : "=r" (val), "=m" (__force_order));
|
|
#endif
|
|
return val;
|
|
}
|
|
|
|
void native_write_cr4(unsigned long val);
|
|
|
|
#ifdef CONFIG_X86_64
|
|
static inline unsigned long native_read_cr8(void)
|
|
{
|
|
unsigned long cr8;
|
|
asm volatile("movq %%cr8,%0" : "=r" (cr8));
|
|
return cr8;
|
|
}
|
|
|
|
static inline void native_write_cr8(unsigned long val)
|
|
{
|
|
asm volatile("movq %0,%%cr8" :: "r" (val) : "memory");
|
|
}
|
|
#endif
|
|
|
|
#ifdef CONFIG_X86_INTEL_MEMORY_PROTECTION_KEYS
|
|
static inline u32 rdpkru(void)
|
|
{
|
|
u32 ecx = 0;
|
|
u32 edx, pkru;
|
|
|
|
/*
|
|
* "rdpkru" instruction. Places PKRU contents in to EAX,
|
|
* clears EDX and requires that ecx=0.
|
|
*/
|
|
asm volatile(".byte 0x0f,0x01,0xee\n\t"
|
|
: "=a" (pkru), "=d" (edx)
|
|
: "c" (ecx));
|
|
return pkru;
|
|
}
|
|
|
|
static inline void wrpkru(u32 pkru)
|
|
{
|
|
u32 ecx = 0, edx = 0;
|
|
|
|
/*
|
|
* "wrpkru" instruction. Loads contents in EAX to PKRU,
|
|
* requires that ecx = edx = 0.
|
|
*/
|
|
asm volatile(".byte 0x0f,0x01,0xef\n\t"
|
|
: : "a" (pkru), "c"(ecx), "d"(edx));
|
|
}
|
|
|
|
static inline void __write_pkru(u32 pkru)
|
|
{
|
|
/*
|
|
* WRPKRU is relatively expensive compared to RDPKRU.
|
|
* Avoid WRPKRU when it would not change the value.
|
|
*/
|
|
if (pkru == rdpkru())
|
|
return;
|
|
|
|
wrpkru(pkru);
|
|
}
|
|
|
|
#else
|
|
static inline u32 rdpkru(void)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline void __write_pkru(u32 pkru)
|
|
{
|
|
}
|
|
#endif
|
|
|
|
static inline void native_wbinvd(void)
|
|
{
|
|
asm volatile("wbinvd": : :"memory");
|
|
}
|
|
|
|
extern asmlinkage void native_load_gs_index(unsigned);
|
|
|
|
static inline unsigned long __read_cr4(void)
|
|
{
|
|
return native_read_cr4();
|
|
}
|
|
|
|
#ifdef CONFIG_PARAVIRT_XXL
|
|
#include <asm/paravirt.h>
|
|
#else
|
|
|
|
static inline unsigned long read_cr0(void)
|
|
{
|
|
return native_read_cr0();
|
|
}
|
|
|
|
static inline void write_cr0(unsigned long x)
|
|
{
|
|
native_write_cr0(x);
|
|
}
|
|
|
|
static inline unsigned long read_cr2(void)
|
|
{
|
|
return native_read_cr2();
|
|
}
|
|
|
|
static inline void write_cr2(unsigned long x)
|
|
{
|
|
native_write_cr2(x);
|
|
}
|
|
|
|
/*
|
|
* Careful! CR3 contains more than just an address. You probably want
|
|
* read_cr3_pa() instead.
|
|
*/
|
|
static inline unsigned long __read_cr3(void)
|
|
{
|
|
return __native_read_cr3();
|
|
}
|
|
|
|
static inline void write_cr3(unsigned long x)
|
|
{
|
|
native_write_cr3(x);
|
|
}
|
|
|
|
static inline void __write_cr4(unsigned long x)
|
|
{
|
|
native_write_cr4(x);
|
|
}
|
|
|
|
static inline void wbinvd(void)
|
|
{
|
|
native_wbinvd();
|
|
}
|
|
|
|
#ifdef CONFIG_X86_64
|
|
|
|
static inline unsigned long read_cr8(void)
|
|
{
|
|
return native_read_cr8();
|
|
}
|
|
|
|
static inline void write_cr8(unsigned long x)
|
|
{
|
|
native_write_cr8(x);
|
|
}
|
|
|
|
static inline void load_gs_index(unsigned selector)
|
|
{
|
|
native_load_gs_index(selector);
|
|
}
|
|
|
|
#endif
|
|
|
|
#endif /* CONFIG_PARAVIRT_XXL */
|
|
|
|
static inline void clflush(volatile void *__p)
|
|
{
|
|
asm volatile("clflush %0" : "+m" (*(volatile char __force *)__p));
|
|
}
|
|
|
|
static inline void clflushopt(volatile void *__p)
|
|
{
|
|
alternative_io(".byte " __stringify(NOP_DS_PREFIX) "; clflush %P0",
|
|
".byte 0x66; clflush %P0",
|
|
X86_FEATURE_CLFLUSHOPT,
|
|
"+m" (*(volatile char __force *)__p));
|
|
}
|
|
|
|
static inline void clwb(volatile void *__p)
|
|
{
|
|
volatile struct { char x[64]; } *p = __p;
|
|
|
|
asm volatile(ALTERNATIVE_2(
|
|
".byte " __stringify(NOP_DS_PREFIX) "; clflush (%[pax])",
|
|
".byte 0x66; clflush (%[pax])", /* clflushopt (%%rax) */
|
|
X86_FEATURE_CLFLUSHOPT,
|
|
".byte 0x66, 0x0f, 0xae, 0x30", /* clwb (%%rax) */
|
|
X86_FEATURE_CLWB)
|
|
: [p] "+m" (*p)
|
|
: [pax] "a" (p));
|
|
}
|
|
|
|
#define nop() asm volatile ("nop")
|
|
|
|
|
|
#endif /* __KERNEL__ */
|
|
|
|
#endif /* _ASM_X86_SPECIAL_INSNS_H */
|