Mikulas Patocka 1e1110c43b target: fix memory leak on XCOPY ... On each processed XCOPY command, two "kmalloc-512" memory objects are leaked. These represent two allocations of struct xcopy_pt_cmd in target_core_xcopy.c. The reason for the memory leak is that the cmd_kref field is not initialized (thus, it is zero because the allocations were done with kzalloc). When we decrement zero kref in target_put_sess_cmd, the result is not zero, thus target_release_cmd_kref is not called. This patch fixes the bug by moving kref initialization from target_get_sess_cmd to transport_init_se_cmd (this function is called from target_core_xcopy.c, so it will correctly initialize cmd_kref). It can be easily verified that all code that calls target_get_sess_cmd also calls transport_init_se_cmd earlier, thus moving kref_init shouldn't introduce any new problems. Signed-off-by: Mikulas Patocka <mpatocka@redhat.com> Cc: stable@vger.kernel.org # 3.12+ Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>		2014-05-17 15:49:40 -07:00
..
iscsi	iscsi-target: Disable Immediate + Unsolicited Data with ISER Protection	2014-05-15 17:09:12 -07:00
loopback
sbp
tcm_fc	tcm_fc: Fix free-after-use regression in ft_free_cmd	2014-05-15 17:09:12 -07:00
Kconfig
Makefile
target_core_alua.c
target_core_alua.h
target_core_configfs.c
target_core_device.c	target: Don't allow setting WC emulation if device doesn't support	2014-05-15 17:09:17 -07:00
target_core_fabric_configfs.c
target_core_fabric_lib.c
target_core_file.c
target_core_file.h
target_core_hba.c
target_core_iblock.c
target_core_iblock.h
target_core_internal.h
target_core_pr.c
target_core_pr.h
target_core_pscsi.c
target_core_pscsi.h
target_core_rd.c
target_core_rd.h
target_core_sbc.c
target_core_spc.c
target_core_stat.c
target_core_tmr.c
target_core_tpg.c
target_core_transport.c	target: fix memory leak on XCOPY	2014-05-17 15:49:40 -07:00
target_core_ua.c
target_core_ua.h
target_core_xcopy.c
target_core_xcopy.h