mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-17 03:48:11 +07:00
b997e3edca
At least on cherrytrail, the update bit will never go low when the
enabled bit is not set.
This causes the backlight on my cube iwork8 air tablet to never turn on
again after being turned off because in the pwm_lpss_apply enable path
pwm_lpss_update will fail causing an error exit and the enable-bit to
never get set. Any following pwm_lpss_apply calls will fail the
pwm_lpss_is_updating check.
Since the docs say that the update bit should be set before the
enable-bit, split pwm_lpss_update into setting the update-bit and
pwm_lpss_wait_for_update, and move the pwm_lpss_wait_for_update call
in the enable path to after setting the enable-bit.
Fixes: 10d56a4 ("pwm: lpss: Avoid reconfiguring while UPDATE bit...")
Cc: Ilkka Koskinen <ilkka.koskinen@intel.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Tested-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
98 lines
2.3 KiB
C
98 lines
2.3 KiB
C
/*
|
|
* Intel Low Power Subsystem PWM controller driver
|
|
*
|
|
* Copyright (C) 2014, Intel Corporation
|
|
*
|
|
* Derived from the original pwm-lpss.c
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
* published by the Free Software Foundation.
|
|
*/
|
|
|
|
#include <linux/acpi.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/pm_runtime.h>
|
|
|
|
#include "pwm-lpss.h"
|
|
|
|
/* BayTrail */
|
|
static const struct pwm_lpss_boardinfo pwm_lpss_byt_info = {
|
|
.clk_rate = 25000000,
|
|
.npwm = 1,
|
|
.base_unit_bits = 16,
|
|
};
|
|
|
|
/* Braswell */
|
|
static const struct pwm_lpss_boardinfo pwm_lpss_bsw_info = {
|
|
.clk_rate = 19200000,
|
|
.npwm = 1,
|
|
.base_unit_bits = 16,
|
|
};
|
|
|
|
/* Broxton */
|
|
static const struct pwm_lpss_boardinfo pwm_lpss_bxt_info = {
|
|
.clk_rate = 19200000,
|
|
.npwm = 4,
|
|
.base_unit_bits = 22,
|
|
.bypass = true,
|
|
};
|
|
|
|
static int pwm_lpss_probe_platform(struct platform_device *pdev)
|
|
{
|
|
const struct pwm_lpss_boardinfo *info;
|
|
const struct acpi_device_id *id;
|
|
struct pwm_lpss_chip *lpwm;
|
|
struct resource *r;
|
|
|
|
id = acpi_match_device(pdev->dev.driver->acpi_match_table, &pdev->dev);
|
|
if (!id)
|
|
return -ENODEV;
|
|
|
|
info = (const struct pwm_lpss_boardinfo *)id->driver_data;
|
|
r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
|
|
|
|
lpwm = pwm_lpss_probe(&pdev->dev, r, info);
|
|
if (IS_ERR(lpwm))
|
|
return PTR_ERR(lpwm);
|
|
|
|
platform_set_drvdata(pdev, lpwm);
|
|
|
|
pm_runtime_set_active(&pdev->dev);
|
|
pm_runtime_enable(&pdev->dev);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int pwm_lpss_remove_platform(struct platform_device *pdev)
|
|
{
|
|
struct pwm_lpss_chip *lpwm = platform_get_drvdata(pdev);
|
|
|
|
pm_runtime_disable(&pdev->dev);
|
|
return pwm_lpss_remove(lpwm);
|
|
}
|
|
|
|
static const struct acpi_device_id pwm_lpss_acpi_match[] = {
|
|
{ "80860F09", (unsigned long)&pwm_lpss_byt_info },
|
|
{ "80862288", (unsigned long)&pwm_lpss_bsw_info },
|
|
{ "80865AC8", (unsigned long)&pwm_lpss_bxt_info },
|
|
{ },
|
|
};
|
|
MODULE_DEVICE_TABLE(acpi, pwm_lpss_acpi_match);
|
|
|
|
static struct platform_driver pwm_lpss_driver_platform = {
|
|
.driver = {
|
|
.name = "pwm-lpss",
|
|
.acpi_match_table = pwm_lpss_acpi_match,
|
|
},
|
|
.probe = pwm_lpss_probe_platform,
|
|
.remove = pwm_lpss_remove_platform,
|
|
};
|
|
module_platform_driver(pwm_lpss_driver_platform);
|
|
|
|
MODULE_DESCRIPTION("PWM platform driver for Intel LPSS");
|
|
MODULE_LICENSE("GPL v2");
|
|
MODULE_ALIAS("platform:pwm-lpss");
|