Brian Foster 39775431f8 xfs: free uncommitted transactions during log recovery ... Log recovery allocates in-core transaction and member item data structures on-demand as it processes the on-disk log. Transactions are allocated on first encounter on-disk and stored in a hash table structure where they are easily accessible for subsequent lookups. Transaction items are also allocated on demand and are attached to the associated transactions. When a commit record is encountered in the log, the transaction is committed to the fs and the in-core structures are freed. If a filesystem crashes or shuts down before all in-core log buffers are flushed to the log, however, not all transactions may have commit records in the log. As expected, the modifications in such an incomplete transaction are not replayed to the fs. The in-core data structures for the partial transaction are never freed, however, resulting in a memory leak. Update xlog_do_recovery_pass() to first correctly initialize the hash table array so empty lists can be distinguished from populated lists on function exit. Update xlog_recover_free_trans() to always remove the transaction from the list prior to freeing the associated memory. Finally, walk the hash table of transaction lists as the last step before it goes out of scope and free any transactions that may remain on the lists. This prevents a memory leak of partial transactions in the log. Signed-off-by: Brian Foster <bfoster@redhat.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>		2017-06-24 10:11:41 -07:00
..
libxfs	xfs: pass along transaction context when reading xattr block buffers	2017-06-20 10:45:22 -07:00
Kconfig	xfs: define fatal assert build time tunable	2017-06-19 08:59:10 -07:00
kmem.c	mm, vmalloc: use __GFP_HIGHMEM implicitly	2017-05-08 17:15:13 -07:00
kmem.h	mm: introduce memalloc_nofs_{save,restore} API	2017-05-03 15:52:09 -07:00
Makefile	xfs: implement the GETFSMAP ioctl	2017-04-03 15:18:17 -07:00
mrlock.h
uuid.c
uuid.h
xfs_acl.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 20:16:43 -07:00
xfs_acl.h	xfs: Change how listxattr generates synthetic attributes	2015-12-06 21:34:16 -05:00
xfs_aops.c	xfs: don't allow bmap on rt files	2017-06-20 10:45:22 -07:00
xfs_aops.h	xfs: use iomap_dio_rw	2016-11-30 14:37:15 +11:00
xfs_attr_inactive.c	xfs: make several functions static	2016-06-01 17:38:15 +10:00
xfs_attr_list.c	xfs: pass along transaction context when reading xattr block buffers	2017-06-20 10:45:22 -07:00
xfs_attr.h	xfs: pass along transaction context when reading xattr block buffers	2017-06-20 10:45:22 -07:00
xfs_bmap_item.c	xfs: try to avoid blowing out the transaction reservation when bunmaping a shared extent	2017-06-19 08:59:10 -07:00
xfs_bmap_item.h	xfs: log bmap intent items	2016-10-04 11:05:44 -07:00
xfs_bmap_util.c	xfs: refactor the ifork block counting function	2017-06-20 10:45:21 -07:00
xfs_bmap_util.h	xfs: refactor the ifork block counting function	2017-06-20 10:45:21 -07:00
xfs_buf_item.c	xfs: remove bli from AIL before release on transaction abort	2017-06-19 08:59:10 -07:00
xfs_buf_item.h	xfs: fix non-debug build warnings	2015-08-25 10:05:13 +10:00
xfs_buf.c	xfs: remove double-underscore integer types	2017-06-19 14:11:33 -07:00
xfs_buf.h	xfs: push buffer of flush locked dquot to avoid quotacheck deadlock	2017-06-19 08:59:10 -07:00
xfs_dir2_readdir.c	xfs: pass along transaction context when reading directory block buffers	2017-06-20 10:45:22 -07:00
xfs_discard.c	xfs: remove double-underscore integer types	2017-06-19 14:11:33 -07:00
xfs_discard.h	xfs: don't block the log commit handler for discards	2017-02-09 11:36:40 -08:00
xfs_dquot_item.c	xfs: allocate log vector buffers outside CIL context lock	2016-07-22 09:52:35 +10:00
xfs_dquot_item.h	xfs: remove the quotaoff log format from the quotaoff log item	2013-12-13 11:34:08 +11:00
xfs_dquot.c	xfs: remove double-underscore integer types	2017-06-19 14:11:33 -07:00
xfs_dquot.h	xfs: fix implicit bool to int conversion	2015-01-09 10:48:58 +11:00
xfs_error.c	Merge branch 'xfs-4.8-misc-fixes-3' into for-next	2016-07-20 11:51:08 +10:00
xfs_error.h	xfs: simulate per-AG reservations being critically low	2016-10-05 16:26:31 -07:00
xfs_export.c	xfs: abstract block export operations from nfsd layouts	2016-07-15 15:31:29 -04:00
xfs_export.h
xfs_extent_busy.c	xfs: fix len comparison in xfs_extent_busy_trim	2017-02-16 17:20:12 -08:00
xfs_extent_busy.h	xfs: improve handling of busy extents in the low-level allocator	2017-02-09 10:50:25 -08:00
xfs_extfree_item.c	xfs: better log intent item refcount checking	2017-04-25 09:40:42 -07:00
xfs_extfree_item.h	xfs: refactor redo intent item processing	2016-08-03 11:23:49 +10:00
xfs_file.c	xfs: pass along transaction context when reading directory block buffers	2017-06-20 10:45:22 -07:00
xfs_filestream.c	Merge branch 'xfs-4.9-log-recovery-fixes' into for-next	2016-10-03 09:56:28 +11:00
xfs_filestream.h	xfs: add filestream allocator tracepoints	2014-04-23 07:11:52 +10:00
xfs_fsmap.c	xfs: only return detailed fsmap info if the caller has CAP_SYS_ADMIN	2017-05-16 12:26:16 -07:00
xfs_fsmap.h	xfs: implement the GETFSMAP ioctl	2017-04-03 15:18:17 -07:00
xfs_fsops.c	xfs: remove double-underscore integer types	2017-06-19 14:11:33 -07:00
xfs_fsops.h	xfs: remove double-underscore integer types	2017-06-19 14:11:33 -07:00
xfs_globals.c	xfs: define fatal assert build time tunable	2017-06-19 08:59:10 -07:00
xfs_icache.c	xfs: check if an inode is cached and allocated	2017-06-19 14:11:34 -07:00
xfs_icache.h	xfs: check if an inode is cached and allocated	2017-06-19 14:11:34 -07:00
xfs_icreate_item.c	fs: xfs: xfs_icreate_item: constify xfs_item_ops structure	2016-11-28 14:57:42 +11:00
xfs_icreate_item.h	xfs: separate icreate log format definitions from xfs_icreate_item.h	2013-08-12 16:10:35 -05:00
xfs_inode_item.c	xfs: remove xfs_trans_ail_delete_bulk	2017-04-25 09:40:42 -07:00
xfs_inode_item.h	xfs: remove timestamps from incore inode	2016-02-09 16:54:58 +11:00
xfs_inode.c	xfs: remove double-underscore integer types	2017-06-19 14:11:33 -07:00
xfs_inode.h	xfs: remove double-underscore integer types	2017-06-19 14:11:33 -07:00
xfs_ioctl32.c	xfs: implement the GETFSMAP ioctl	2017-04-03 15:18:17 -07:00
xfs_ioctl32.h	xfs: remove double-underscore integer types	2017-06-19 14:11:33 -07:00
xfs_ioctl.c	xfs: remove double-underscore integer types	2017-06-19 14:11:33 -07:00
xfs_ioctl.h	xfs: remove double-underscore integer types	2017-06-19 14:11:33 -07:00
xfs_iomap.c	dax, xfs, ext4: compile out iomap-dax paths in the FS_DAX=n case	2017-05-13 17:52:16 -07:00
xfs_iomap.h	xfs: introduce xfs_aligned_fsb_count	2017-02-06 17:47:46 -08:00
xfs_iops.c	xfs: report crtime and attribute flags to statx	2017-04-03 01:05:59 -04:00
xfs_iops.h	xfs: Propagate dentry down to inode_change_ok()	2016-09-22 10:56:19 +02:00
xfs_itable.c	xfs: export various function for the online scrubber	2017-06-19 14:11:34 -07:00
xfs_itable.h	xfs: export various function for the online scrubber	2017-06-19 14:11:34 -07:00
xfs_linux.h	xfs: remove double-underscore integer types	2017-06-19 14:11:33 -07:00
xfs_log_cil.c	xfs: remove lsn relevant fields from xfs_trans structure and its users	2017-06-19 08:59:10 -07:00
xfs_log_priv.h	xfs: remove double-underscore integer types	2017-06-19 14:11:33 -07:00
xfs_log_recover.c	xfs: free uncommitted transactions during log recovery	2017-06-24 10:11:41 -07:00
xfs_log.c	xfs: remove double-underscore integer types	2017-06-19 14:11:33 -07:00
xfs_log.h	xfs: remove double-underscore integer types	2017-06-19 14:11:33 -07:00
xfs_message.c	xfs: define bug_on_assert debug mode sysfs tunable	2017-06-19 08:59:10 -07:00
xfs_message.h
xfs_mount.c	xfs: remove double-underscore integer types	2017-06-19 14:11:33 -07:00
xfs_mount.h	xfs: remove double-underscore integer types	2017-06-19 14:11:33 -07:00
xfs_mru_cache.c	xfs: xfs_mru_cache_insert() should use GFP_NOFS	2015-03-25 14:57:53 +11:00
xfs_mru_cache.h	xfs: embedd mru_elem into parent structure	2014-04-23 07:11:51 +10:00
xfs_ondisk.h	xfs: define the on-disk refcount btree format	2016-10-03 09:11:18 -07:00
xfs_pnfs.c	xfs: remove i_iolock and use i_rwsem in the VFS inode instead	2016-11-30 14:33:25 +11:00
xfs_pnfs.h	xfs: remove i_iolock and use i_rwsem in the VFS inode instead	2016-11-30 14:33:25 +11:00
xfs_qm_bhv.c	xfs: remove double-underscore integer types	2017-06-19 14:11:33 -07:00
xfs_qm_syscalls.c	xfs: wait on new inodes during quotaoff dquot release	2017-04-28 08:11:08 -07:00
xfs_qm.c	xfs: push buffer of flush locked dquot to avoid quotacheck deadlock	2017-06-19 08:59:10 -07:00
xfs_qm.h	xfs: Split default quota limits by quota type	2016-02-08 11:27:55 +11:00
xfs_quota.h	xfs: fix quota block reservation leak when tp allocates and frees blocks	2015-06-01 07:15:37 +10:00
xfs_quotaops.c	xfs: wire up Q_XGETNEXTQUOTA / get_nextdqblk	2016-02-08 11:27:38 +11:00
xfs_refcount_item.c	xfs: better log intent item refcount checking	2017-04-25 09:40:42 -07:00
xfs_refcount_item.h	xfs: log refcount intent items	2016-10-03 09:11:21 -07:00
xfs_reflink.c	xfs: separate function to check if inode shares extents	2017-06-19 14:11:35 -07:00
xfs_reflink.h	xfs: separate function to check if inode shares extents	2017-06-19 14:11:35 -07:00
xfs_rmap_item.c	xfs: better log intent item refcount checking	2017-04-25 09:40:42 -07:00
xfs_rmap_item.h	xfs: convert RUI log formats to use variable length arrays	2016-09-19 10:24:27 +10:00
xfs_rtalloc.c	xfs: remove double-underscore integer types	2017-06-19 14:11:33 -07:00
xfs_rtalloc.h	xfs: export various function for the online scrubber	2017-06-19 14:11:34 -07:00
xfs_stats.c	xfs: remove double-underscore integer types	2017-06-19 14:11:33 -07:00
xfs_stats.h	xfs: remove double-underscore integer types	2017-06-19 14:11:33 -07:00
xfs_super.c	xfs: remove double-underscore integer types	2017-06-19 14:11:33 -07:00
xfs_super.h	xfs: don't block the log commit handler for discards	2017-02-09 11:36:40 -08:00
xfs_symlink.c	xfs: allow reading of already-locked remote symbolic link	2017-06-20 10:45:22 -07:00
xfs_symlink.h	xfs: allow reading of already-locked remote symbolic link	2017-06-20 10:45:22 -07:00
xfs_sysctl.c	xfs: garbage collect old cowextsz reservations	2016-10-05 16:26:28 -07:00
xfs_sysctl.h	xfs: define bug_on_assert debug mode sysfs tunable	2017-06-19 08:59:10 -07:00
xfs_sysfs.c	xfs: define bug_on_assert debug mode sysfs tunable	2017-06-19 08:59:10 -07:00
xfs_sysfs.h	xfs: configurable error behavior via sysfs	2016-05-18 10:58:51 +10:00
xfs_trace.c	xfs: implement the GETFSMAP ioctl	2017-04-03 15:18:17 -07:00
xfs_trace.h	xfs: remove double-underscore integer types	2017-06-19 14:11:33 -07:00
xfs_trans_ail.c	xfs: remove xfs_trans_ail_delete_bulk	2017-04-25 09:40:42 -07:00
xfs_trans_bmap.c	xfs: try to avoid blowing out the transaction reservation when bunmaping a shared extent	2017-06-19 08:59:10 -07:00
xfs_trans_buf.c	xfs: release bli from transaction properly on fs shutdown	2017-06-19 08:59:10 -07:00
xfs_trans_dquot.c	xfs: Split default quota limits by quota type	2016-02-08 11:27:55 +11:00
xfs_trans_extfree.c	xfs: set up per-AG free space reservations	2016-09-19 10:30:52 +10:00
xfs_trans_inode.c	fs: Replace current_fs_time() with current_time()	2016-09-27 21:06:22 -04:00
xfs_trans_priv.h	xfs: remove xfs_trans_ail_delete_bulk	2017-04-25 09:40:42 -07:00
xfs_trans_refcount.c	xfs: connect refcount adjust functions to upper layers	2016-10-03 09:11:22 -07:00
xfs_trans_rmap.c	xfs: remove double-underscore integer types	2017-06-19 14:11:33 -07:00
xfs_trans.c	Changes for 4.12:	2017-05-06 11:46:16 -07:00
xfs_trans.h	xfs: remove double-underscore integer types	2017-06-19 14:11:33 -07:00
xfs_xattr.c	xfs: several xattr functions can be void	2016-12-05 12:32:14 +11:00
xfs.h	xfs: define fatal assert build time tunable	2017-06-19 08:59:10 -07:00