NeilBrown 6d183de407 md/raid5: fix newly-broken locking in get_active_stripe. ... commit 566c09c534 raid5: relieve lock contention in get_active_stripe() modified the locking in get_active_stripe() reducing the range protected by the (highly contended) device_lock. Unfortunately it reduced the range too much opening up some races. One race can occur if get_priority_stripe runs between the test on sh->count and device_lock being taken. This will mean that sh->lru is not empty while get_active_stripe thinks ->count is zero resulting in a 'BUG' firing. Another race happens if __release_stripe is called immediately after sh->count is tested and found to be non-zero. If STRIPE_HANDLE is not set, get_active_stripe should increment ->active_stripes when it increments ->count from 0, but as it didn't think it was 0, it doesn't. Extending device_lock to cover the test on sh->count close these races. While we are here, fix the two BUG tests: -If count is zero, then lru really must not be empty, or we've lock the stripe_head somehow - no other tests are relevant. -STRIPE_ON_RELEASE_LIST is completely independent of ->lru so testing it is pointless. Reported-and-tested-by: Brassow Jonathan <jbrassow@redhat.com> Reviewed-by: Shaohua Li <shli@kernel.org> Fixes: 566c09c534 Signed-off-by: NeilBrown <neilb@suse.de>		2013-11-28 11:00:15 +11:00
..
bcache	bcache: defensively handle format strings	2013-11-10 21:56:43 -08:00
persistent-data	dm space map disk: optimise sm_disk_dec_block	2013-11-09 18:20:24 -05:00
bitmap.c
bitmap.h
dm-bio-prison.c
dm-bio-prison.h
dm-bio-record.h
dm-bufio.c
dm-bufio.h
dm-cache-block-types.h
dm-cache-metadata.c	dm cache metadata: check the metadata version when reading the superblock	2013-11-11 11:37:49 -05:00
dm-cache-metadata.h	dm cache: add passthrough mode	2013-11-11 11:37:49 -05:00
dm-cache-policy-cleaner.c
dm-cache-policy-internal.h	dm cache: add remove_cblock method to policy interface	2013-11-11 11:37:50 -05:00
dm-cache-policy-mq.c	dm cache: resolve small nits and improve Documentation	2013-11-12 13:11:09 -05:00
dm-cache-policy.c	dm cache: return -EINVAL if the user specifies unknown cache policy	2013-11-09 18:20:18 -05:00
dm-cache-policy.h	dm cache: add remove_cblock method to policy interface	2013-11-11 11:37:50 -05:00
dm-cache-target.c	dm cache: resolve small nits and improve Documentation	2013-11-12 13:11:09 -05:00
dm-crypt.c	tree-wide: use reinit_completion instead of INIT_COMPLETION	2013-11-15 09:32:21 +09:00
dm-delay.c
dm-exception-store.c
dm-exception-store.h
dm-flakey.c
dm-io.c
dm-ioctl.c	dm: allow remove to be deferred	2013-11-09 18:20:22 -05:00
dm-kcopyd.c
dm-linear.c
dm-log-userspace-base.c
dm-log-userspace-transfer.c
dm-log-userspace-transfer.h
dm-log.c
dm-mpath.c
dm-mpath.h
dm-path-selector.c
dm-path-selector.h
dm-queue-length.c
dm-raid1.c
dm-raid.c
dm-region-hash.c
dm-round-robin.c
dm-service-time.c
dm-snap-persistent.c
dm-snap-transient.c
dm-snap.c
dm-stats.c
dm-stats.h
dm-stripe.c
dm-switch.c
dm-sysfs.c
dm-table.c	dm table: print error on preresume failure	2013-11-09 18:20:21 -05:00
dm-target.c
dm-thin-metadata.c
dm-thin-metadata.h
dm-thin.c
dm-uevent.c
dm-uevent.h
dm-verity.c
dm-zero.c
dm.c	dm: allow remove to be deferred	2013-11-09 18:20:22 -05:00
dm.h	dm: allow remove to be deferred	2013-11-09 18:20:22 -05:00
faulty.c
Kconfig	dm: fix Kconfig menu indentation	2013-11-09 18:20:22 -05:00
linear.c
linear.h
Makefile
md.c	md: test mddev->flags more safely in md_check_recovery.	2013-11-28 11:00:08 +11:00
md.h	Merge branch 'for-3.13/core' of git://git.kernel.dk/linux-block	2013-11-14 12:08:14 +09:00
multipath.c
multipath.h
raid0.c
raid0.h
raid1.c	md update for 3.13.	2013-11-20 13:05:25 -08:00
raid1.h	raid1: Rewrite the implementation of iobarrier.	2013-11-19 15:19:18 +11:00
raid5.c	md/raid5: fix newly-broken locking in get_active_stripe.	2013-11-28 11:00:15 +11:00
raid5.h	md update for 3.13.	2013-11-20 13:05:25 -08:00
raid10.c	md update for 3.13.	2013-11-20 13:05:25 -08:00
raid10.h