linux_dsm_epyc7002/drivers/net/wireless
Vladimir Kondratiev 382afc3d05 wil6210: move Rx reorder buffer allocation out of spinlock
This fixes issue reported by Dan Carpenter:
The patch 3277213feb: "wil6210: ADDBA/DELBA flows" from Dec 23,
2014, leads to the following static checker warning:

        drivers/net/wireless/ath/wil6210/rx_reorder.c:205 wil_tid_ampdu_rx_alloc()
        error: scheduling with locks held: 'spin_lock:tid_rx_lock'

drivers/net/wireless/ath/wil6210/rx_reorder.c
   202  struct wil_tid_ampdu_rx *wil_tid_ampdu_rx_alloc(struct wil6210_priv *wil,
   203                                                  int size, u16 ssn)
   204  {
   205          struct wil_tid_ampdu_rx *r = kzalloc(sizeof(*r), GFP_KERNEL);
                                                                 ^^^^^^^^^^
   206
   207          if (!r)
   208                  return NULL;
   209
   210          r->reorder_buf =
   211                  kcalloc(size, sizeof(struct sk_buff *), GFP_KERNEL);
                                                                ^^^^^^^^^^^
   212          r->reorder_time =
   213                  kcalloc(size, sizeof(unsigned long), GFP_KERNEL);
                                                             ^^^^^^^^^^^
   214          if (!r->reorder_buf || !r->reorder_time) {
   215                  kfree(r->reorder_buf);
   216                  kfree(r->reorder_time);
   217                  kfree(r);
   218                  return NULL;
   219          }
   220

[ snip ]

   331          spin_lock_bh(&sta->tid_rx_lock);
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spin lock held.

   332
   333          wil_tid_ampdu_rx_free(wil, sta->tid_rx[tid]);
   334          sta->tid_rx[tid] = wil_tid_ampdu_rx_alloc(wil, agg_wsize, ssn);
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
function called with the lock held.

   335
   336          spin_unlock_bh(&sta->tid_rx_lock);

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
2015-01-29 09:55:27 +02:00
..
ath wil6210: move Rx reorder buffer allocation out of spinlock 2015-01-29 09:55:27 +02:00
b43 b43: stop leds during suspend 2015-01-23 19:40:40 +02:00
b43legacy b43legacy: Remove unused b43legacy_radio_set_tx_iq() 2015-01-15 15:35:46 +02:00
brcm80211 brcmfmac: Use put_unaligned_le32 2015-01-23 21:12:52 +02:00
cw1200 Merge commit 'c1e140bf79d817d4a7aa9932eb98b0359c87af33' from mac80211-next 2015-01-22 14:49:44 +02:00
hostap hostap_cs: fix misspelling of current function in string 2014-12-15 13:46:19 -05:00
ipw2x00 ipw2200: select CFG80211_WEXT 2014-12-24 15:15:25 +02:00
iwlegacy iwl3945: Use setup_timer 2015-01-07 10:45:08 +02:00
iwlwifi iwlwifi: mvm: fix rx chains configuration in phy ctxt cmd 2015-01-22 22:17:22 +02:00
libertas cfg80211: remove enum station_info_flags 2015-01-08 15:28:10 +01:00
libertas_tf
mwifiex mwifiex: selectively choose ext_scan support 2015-01-27 20:18:20 +02:00
orinoco orinoco/hermes: select CFG80211_WEXT 2015-01-15 15:04:10 +02:00
p54 p54pci: add handling of signal case 2015-01-23 21:37:04 +02:00
prism54
rsi rsi: fix memory leak in rsi_load_ta_instructions() 2014-12-24 17:26:08 +02:00
rt2x00 Merge commit 'c1e140bf79d817d4a7aa9932eb98b0359c87af33' from mac80211-next 2015-01-22 14:49:44 +02:00
rtl818x rtl818x_pci: fix response rate may be incorrect. 2014-10-07 14:48:37 -04:00
rtlwifi rtlwifi: rtl8192cu: Set fw_ready flag 2015-01-27 20:20:09 +02:00
ti wlcore: unlock on error in wl1271_op_suspend() 2015-01-23 19:37:42 +02:00
zd1211rw zd1211rw: fix misspelling of current function in string 2014-12-15 13:46:19 -05:00
adm8211.c adm8211: fix error return code 2015-01-15 14:44:42 +02:00
adm8211.h
airo_cs.c
airo.c
airo.h
at76c50x-usb.c
at76c50x-usb.h
atmel_cs.c
atmel_pci.c
atmel.c atmel: Remove open-coded and wrong strcasecmp 2015-01-23 21:38:54 +02:00
atmel.h
Kconfig
mac80211_hwsim.c Merge commit 'c1e140bf79d817d4a7aa9932eb98b0359c87af33' from mac80211-next 2015-01-22 14:49:44 +02:00
mac80211_hwsim.h mac80211-hwsim: Add HWSIM_CMD_GET_RADIO command 2014-11-19 18:59:32 +01:00
Makefile
mwl8k.c cfg80211: remove "channel" from survey names 2015-01-08 15:27:52 +01:00
ray_cs.c
ray_cs.h
rayctl.h
rndis_wlan.c cfg80211: remove enum station_info_flags 2015-01-08 15:28:10 +01:00
wl3501_cs.c
wl3501.h
zd1201.c
zd1201.h