mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-26 04:05:18 +07:00
8526ad9646
nsim_dev_take_snapshot_write() uses nsim_dev and nsim_dev->dummy_region.
So, during this function, these data shouldn't be removed.
But there is no protecting stuff in this function.
There are two similar cases.
1. reload case
reload could be called during nsim_dev_take_snapshot_write().
When reload is being executed, nsim_dev_reload_down() is called and it
calls nsim_dev_reload_destroy(). nsim_dev_reload_destroy() calls
devlink_region_destroy() to destroy nsim_dev->dummy_region.
So, during nsim_dev_take_snapshot_write(), nsim_dev->dummy_region()
would be removed.
At this point, snapshot_write() would access freed pointer.
In order to fix this case, take_snapshot file will be removed before
devlink_region_destroy().
The take_snapshot file will be re-created by ->reload_up().
2. del_device_store case
del_device_store() also could call nsim_dev_reload_destroy()
during nsim_dev_take_snapshot_write(). If so, panic would occur.
This problem is actually the same problem with the first case.
So, this problem will be fixed by the first case's solution.
Test commands:
modprobe netdevsim
while :
do
echo 1 > /sys/bus/netdevsim/new_device &
echo 1 > /sys/bus/netdevsim/del_device &
devlink dev reload netdevsim/netdevsim1 &
echo 1 > /sys/kernel/debug/netdevsim/netdevsim1/take_snapshot &
done
Splat looks like:
[ 45.564513][ T975] general protection fault, probably for non-canonical address 0xdffffc000000003a: 0000 [#1] SMP DEI
[ 45.566131][ T975] KASAN: null-ptr-deref in range [0x00000000000001d0-0x00000000000001d7]
[ 45.566135][ T975] CPU: 1 PID: 975 Comm: bash Not tainted 5.5.0+ #322
[ 45.569020][ T975] Hardware name: innotek GmbH VirtualBox/VirtualBox, BIOS VirtualBox 12/01/2006
[ 45.569026][ T975] RIP: 0010:__mutex_lock+0x10a/0x14b0
[ 45.570518][ T975] Code: 08 84 d2 0f 85 7f 12 00 00 44 8b 0d 10 23 65 02 45 85 c9 75 29 49 8d 7f 68 48 b8 00 00 00 0f
[ 45.570522][ T975] RSP: 0018:ffff888046ccfbf0 EFLAGS: 00010206
[ 45.572305][ T975] RAX: dffffc0000000000 RBX: 0000000000000000 RCX: 0000000000000000
[ 45.572308][ T975] RDX: 000000000000003a RSI: ffffffffac926440 RDI: 00000000000001d0
[ 45.576843][ T975] RBP: ffff888046ccfd70 R08: ffffffffab610645 R09: 0000000000000000
[ 45.576847][ T975] R10: ffff888046ccfd90 R11: ffffed100d6360ad R12: 0000000000000000
[ 45.578471][ T975] R13: dffffc0000000000 R14: ffffffffae1976c0 R15: 0000000000000168
[ 45.578475][ T975] FS: 00007f614d6e7740(0000) GS:ffff88806c400000(0000) knlGS:0000000000000000
[ 45.581492][ T975] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 45.582942][ T975] CR2: 00005618677d1cf0 CR3: 000000005fb9c002 CR4: 00000000000606e0
[ 45.584543][ T975] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 45.586633][ T975] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[ 45.589889][ T975] Call Trace:
[ 45.591445][ T975] ? devlink_region_snapshot_create+0x55/0x4a0
[ 45.601250][ T975] ? mutex_lock_io_nested+0x1380/0x1380
[ 45.602817][ T975] ? mutex_lock_io_nested+0x1380/0x1380
[ 45.603875][ T975] ? mark_held_locks+0xa5/0xe0
[ 45.604769][ T975] ? _raw_spin_unlock_irqrestore+0x2d/0x50
[ 45.606147][ T975] ? __mutex_unlock_slowpath+0xd0/0x670
[ 45.607723][ T975] ? crng_backtrack_protect+0x80/0x80
[ 45.613530][ T975] ? wait_for_completion+0x390/0x390
[ 45.615152][ T975] ? devlink_region_snapshot_create+0x55/0x4a0
[ 45.616834][ T975] devlink_region_snapshot_create+0x55/0x4a0
[ ... ]
Fixes: 4418f862d6
("netdevsim: implement support for devlink region and snapshots")
Signed-off-by: Taehee Yoo <ap420073@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
251 lines
6.1 KiB
C
251 lines
6.1 KiB
C
/*
|
|
* Copyright (C) 2017 Netronome Systems, Inc.
|
|
*
|
|
* This software is licensed under the GNU General License Version 2,
|
|
* June 1991 as shown in the file COPYING in the top-level directory of this
|
|
* source tree.
|
|
*
|
|
* THE COPYRIGHT HOLDERS AND/OR OTHER PARTIES PROVIDE THE PROGRAM "AS IS"
|
|
* WITHOUT WARRANTY OF ANY KIND, EITHER EXPRESSED OR IMPLIED, INCLUDING,
|
|
* BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
|
|
* FOR A PARTICULAR PURPOSE. THE ENTIRE RISK AS TO THE QUALITY AND PERFORMANCE
|
|
* OF THE PROGRAM IS WITH YOU. SHOULD THE PROGRAM PROVE DEFECTIVE, YOU ASSUME
|
|
* THE COST OF ALL NECESSARY SERVICING, REPAIR OR CORRECTION.
|
|
*/
|
|
|
|
#include <linux/device.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/list.h>
|
|
#include <linux/netdevice.h>
|
|
#include <linux/u64_stats_sync.h>
|
|
#include <net/devlink.h>
|
|
#include <net/xdp.h>
|
|
|
|
#define DRV_NAME "netdevsim"
|
|
|
|
#define NSIM_XDP_MAX_MTU 4000
|
|
|
|
#define NSIM_EA(extack, msg) NL_SET_ERR_MSG_MOD((extack), msg)
|
|
|
|
#define NSIM_IPSEC_MAX_SA_COUNT 33
|
|
#define NSIM_IPSEC_VALID BIT(31)
|
|
|
|
struct nsim_sa {
|
|
struct xfrm_state *xs;
|
|
__be32 ipaddr[4];
|
|
u32 key[4];
|
|
u32 salt;
|
|
bool used;
|
|
bool crypt;
|
|
bool rx;
|
|
};
|
|
|
|
struct nsim_ipsec {
|
|
struct nsim_sa sa[NSIM_IPSEC_MAX_SA_COUNT];
|
|
struct dentry *pfile;
|
|
u32 count;
|
|
u32 tx;
|
|
u32 ok;
|
|
};
|
|
|
|
struct netdevsim {
|
|
struct net_device *netdev;
|
|
struct nsim_dev *nsim_dev;
|
|
struct nsim_dev_port *nsim_dev_port;
|
|
|
|
u64 tx_packets;
|
|
u64 tx_bytes;
|
|
struct u64_stats_sync syncp;
|
|
|
|
struct nsim_bus_dev *nsim_bus_dev;
|
|
|
|
struct bpf_prog *bpf_offloaded;
|
|
u32 bpf_offloaded_id;
|
|
|
|
struct xdp_attachment_info xdp;
|
|
struct xdp_attachment_info xdp_hw;
|
|
|
|
bool bpf_tc_accept;
|
|
bool bpf_tc_non_bound_accept;
|
|
bool bpf_xdpdrv_accept;
|
|
bool bpf_xdpoffload_accept;
|
|
|
|
bool bpf_map_accept;
|
|
struct nsim_ipsec ipsec;
|
|
};
|
|
|
|
struct netdevsim *
|
|
nsim_create(struct nsim_dev *nsim_dev, struct nsim_dev_port *nsim_dev_port);
|
|
void nsim_destroy(struct netdevsim *ns);
|
|
|
|
#ifdef CONFIG_BPF_SYSCALL
|
|
int nsim_bpf_dev_init(struct nsim_dev *nsim_dev);
|
|
void nsim_bpf_dev_exit(struct nsim_dev *nsim_dev);
|
|
int nsim_bpf_init(struct netdevsim *ns);
|
|
void nsim_bpf_uninit(struct netdevsim *ns);
|
|
int nsim_bpf(struct net_device *dev, struct netdev_bpf *bpf);
|
|
int nsim_bpf_disable_tc(struct netdevsim *ns);
|
|
int nsim_bpf_setup_tc_block_cb(enum tc_setup_type type,
|
|
void *type_data, void *cb_priv);
|
|
#else
|
|
|
|
static inline int nsim_bpf_dev_init(struct nsim_dev *nsim_dev)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline void nsim_bpf_dev_exit(struct nsim_dev *nsim_dev)
|
|
{
|
|
}
|
|
static inline int nsim_bpf_init(struct netdevsim *ns)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline void nsim_bpf_uninit(struct netdevsim *ns)
|
|
{
|
|
}
|
|
|
|
static inline int nsim_bpf(struct net_device *dev, struct netdev_bpf *bpf)
|
|
{
|
|
return bpf->command == XDP_QUERY_PROG ? 0 : -EOPNOTSUPP;
|
|
}
|
|
|
|
static inline int nsim_bpf_disable_tc(struct netdevsim *ns)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline int
|
|
nsim_bpf_setup_tc_block_cb(enum tc_setup_type type, void *type_data,
|
|
void *cb_priv)
|
|
{
|
|
return -EOPNOTSUPP;
|
|
}
|
|
#endif
|
|
|
|
enum nsim_resource_id {
|
|
NSIM_RESOURCE_NONE, /* DEVLINK_RESOURCE_ID_PARENT_TOP */
|
|
NSIM_RESOURCE_IPV4,
|
|
NSIM_RESOURCE_IPV4_FIB,
|
|
NSIM_RESOURCE_IPV4_FIB_RULES,
|
|
NSIM_RESOURCE_IPV6,
|
|
NSIM_RESOURCE_IPV6_FIB,
|
|
NSIM_RESOURCE_IPV6_FIB_RULES,
|
|
};
|
|
|
|
struct nsim_dev_health {
|
|
struct devlink_health_reporter *empty_reporter;
|
|
struct devlink_health_reporter *dummy_reporter;
|
|
struct dentry *ddir;
|
|
char *recovered_break_msg;
|
|
u32 binary_len;
|
|
bool fail_recover;
|
|
};
|
|
|
|
int nsim_dev_health_init(struct nsim_dev *nsim_dev, struct devlink *devlink);
|
|
void nsim_dev_health_exit(struct nsim_dev *nsim_dev);
|
|
|
|
struct nsim_dev_port {
|
|
struct list_head list;
|
|
struct devlink_port devlink_port;
|
|
unsigned int port_index;
|
|
struct dentry *ddir;
|
|
struct netdevsim *ns;
|
|
};
|
|
|
|
struct nsim_dev {
|
|
struct nsim_bus_dev *nsim_bus_dev;
|
|
struct nsim_fib_data *fib_data;
|
|
struct nsim_trap_data *trap_data;
|
|
struct dentry *ddir;
|
|
struct dentry *ports_ddir;
|
|
struct dentry *take_snapshot;
|
|
struct bpf_offload_dev *bpf_dev;
|
|
bool bpf_bind_accept;
|
|
u32 bpf_bind_verifier_delay;
|
|
struct dentry *ddir_bpf_bound_progs;
|
|
u32 prog_id_gen;
|
|
struct list_head bpf_bound_progs;
|
|
struct list_head bpf_bound_maps;
|
|
struct netdev_phys_item_id switch_id;
|
|
struct list_head port_list;
|
|
struct mutex port_list_lock; /* protects port list */
|
|
bool fw_update_status;
|
|
u32 max_macs;
|
|
bool test1;
|
|
bool dont_allow_reload;
|
|
bool fail_reload;
|
|
struct devlink_region *dummy_region;
|
|
struct nsim_dev_health health;
|
|
};
|
|
|
|
static inline struct net *nsim_dev_net(struct nsim_dev *nsim_dev)
|
|
{
|
|
return devlink_net(priv_to_devlink(nsim_dev));
|
|
}
|
|
|
|
int nsim_dev_init(void);
|
|
void nsim_dev_exit(void);
|
|
int nsim_dev_probe(struct nsim_bus_dev *nsim_bus_dev);
|
|
void nsim_dev_remove(struct nsim_bus_dev *nsim_bus_dev);
|
|
int nsim_dev_port_add(struct nsim_bus_dev *nsim_bus_dev,
|
|
unsigned int port_index);
|
|
int nsim_dev_port_del(struct nsim_bus_dev *nsim_bus_dev,
|
|
unsigned int port_index);
|
|
|
|
struct nsim_fib_data *nsim_fib_create(struct devlink *devlink,
|
|
struct netlink_ext_ack *extack);
|
|
void nsim_fib_destroy(struct devlink *devlink, struct nsim_fib_data *fib_data);
|
|
u64 nsim_fib_get_val(struct nsim_fib_data *fib_data,
|
|
enum nsim_resource_id res_id, bool max);
|
|
|
|
#if IS_ENABLED(CONFIG_XFRM_OFFLOAD)
|
|
void nsim_ipsec_init(struct netdevsim *ns);
|
|
void nsim_ipsec_teardown(struct netdevsim *ns);
|
|
bool nsim_ipsec_tx(struct netdevsim *ns, struct sk_buff *skb);
|
|
#else
|
|
static inline void nsim_ipsec_init(struct netdevsim *ns)
|
|
{
|
|
}
|
|
|
|
static inline void nsim_ipsec_teardown(struct netdevsim *ns)
|
|
{
|
|
}
|
|
|
|
static inline bool nsim_ipsec_tx(struct netdevsim *ns, struct sk_buff *skb)
|
|
{
|
|
return true;
|
|
}
|
|
#endif
|
|
|
|
struct nsim_vf_config {
|
|
int link_state;
|
|
u16 min_tx_rate;
|
|
u16 max_tx_rate;
|
|
u16 vlan;
|
|
__be16 vlan_proto;
|
|
u16 qos;
|
|
u8 vf_mac[ETH_ALEN];
|
|
bool spoofchk_enabled;
|
|
bool trusted;
|
|
bool rss_query_enabled;
|
|
};
|
|
|
|
struct nsim_bus_dev {
|
|
struct device dev;
|
|
struct list_head list;
|
|
unsigned int port_count;
|
|
struct net *initial_net; /* Purpose of this is to carry net pointer
|
|
* during the probe time only.
|
|
*/
|
|
unsigned int num_vfs;
|
|
struct nsim_vf_config *vfconfigs;
|
|
/* Lock for devlink->reload_enabled in netdevsim module */
|
|
struct mutex nsim_bus_reload_lock;
|
|
bool init;
|
|
};
|
|
|
|
int nsim_bus_init(void);
|
|
void nsim_bus_exit(void);
|