Pravin B Shelar 03db5068df net: Fix zero-copy head len calculation. ... [ Upstream commit a17ad0961706244dce48ec941f7e476a38c0e727 ] In some cases skb head could be locked and entire header data is pulled from skb. When skb_zerocopy() called in such cases, following BUG is triggered. This patch fixes it by copying entire skb in such cases. This could be optimized incase this is performance bottleneck. ---8<--- kernel BUG at net/core/skbuff.c:2961! invalid opcode: 0000 [#1] SMP PTI CPU: 2 PID: 0 Comm: swapper/2 Tainted: G OE 5.4.0-77-generic #86-Ubuntu Hardware name: OpenStack Foundation OpenStack Nova, BIOS 1.13.0-1ubuntu1.1 04/01/2014 RIP: 0010:skb_zerocopy+0x37a/0x3a0 RSP: 0018:ffffbcc70013ca38 EFLAGS: 00010246 Call Trace: <IRQ> queue_userspace_packet+0x2af/0x5e0 [openvswitch] ovs_dp_upcall+0x3d/0x60 [openvswitch] ovs_dp_process_packet+0x125/0x150 [openvswitch] ovs_vport_receive+0x77/0xd0 [openvswitch] netdev_port_receive+0x87/0x130 [openvswitch] netdev_frame_hook+0x4b/0x60 [openvswitch] __netif_receive_skb_core+0x2b4/0xc90 __netif_receive_skb_one_core+0x3f/0xa0 __netif_receive_skb+0x18/0x60 process_backlog+0xa9/0x160 net_rx_action+0x142/0x390 __do_softirq+0xe1/0x2d6 irq_exit+0xae/0xb0 do_IRQ+0x5a/0xf0 common_interrupt+0xf/0xf Code that triggered BUG: int skb_zerocopy(struct sk_buff *to, struct sk_buff *from, int len, int hlen) { int i, j = 0; int plen = 0; /* length of skb->head fragment */ int ret; struct page *page; unsigned int offset; BUG_ON(!from->head_frag && !hlen); Signed-off-by: Pravin B Shelar <pshelar@ovn.org> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-07-05 18:07:38 +02:00
..
bpf_sk_storage.c
datagram.c	udp: fix skb_copy_and_csum_datagram with odd segment sizes	2021-02-17 11:02:28 +01:00
datagram.h
dev_addr_lists.c
dev_ioctl.c	net: fix dev_ifsioc_locked() race condition	2021-03-07 12:34:07 +01:00
dev.c	init: add dsm gpl source	2024-07-05 18:00:04 +02:00
devlink.c	devlink: Correct VIRTUAL port to not have phys_port attributes	2021-06-10 13:39:16 +02:00
drop_monitor.c	drop_monitor: Perform cleanup upon probe registration failure	2021-03-30 14:31:57 +02:00
dst_cache.c
dst.c	net, bpf: Fix ip6ip6 crash with collect_md populated skbs	2021-03-30 14:32:05 +02:00
failover.c
fib_notifier.c
fib_rules.c	fib: Return the correct errno code	2021-06-18 10:00:06 +02:00
filter.c	bpf: Do not change gso_size during bpf_skb_change_proto()	2021-07-14 16:56:27 +02:00
flow_dissector.c	flow_dissector: Fix out-of-bounds warning in __skb_flow_bpf_to_target()	2021-05-19 10:12:57 +02:00
flow_offload.c
gen_estimator.c	net_sched: gen_estimator: support large ewma log	2021-01-27 11:55:23 +01:00
gen_stats.c
gro_cells.c
hwbm.c
link_watch.c
lwt_bpf.c
lwtunnel.c
Makefile
neighbour.c	neighbour: allow NUD_NOARP entries to be forced GCed	2021-06-10 13:39:29 +02:00
net_namespace.c	net: make get_net_ns return error if NET_NS is disabled	2021-06-23 14:42:44 +02:00
net-procfs.c
net-sysfs.c	init: add dsm gpl source	2024-07-05 18:00:04 +02:00
net-sysfs.h
net-traces.c
netclassid_cgroup.c
netevent.c
netpoll.c
netprio_cgroup.c
page_pool.c	mm: fix struct page layout on 32-bit systems	2021-05-19 10:13:17 +02:00
pktgen.c	pktgen: fix misuse of BUG_ON() in pktgen_thread_worker()	2021-03-07 12:34:09 +01:00
ptp_classifier.c
request_sock.c
rtnetlink.c	rtnetlink: Fix regression in bridge VLAN configuration	2021-06-23 14:42:42 +02:00
scm.c
secure_seq.c
skbuff.c	net: Fix zero-copy head len calculation.	2024-07-05 18:07:38 +02:00
skmsg.c	skmsg: Make sk_psock_destroy() static	2024-07-05 18:05:02 +02:00
sock_diag.c
sock_map.c
sock_reuseport.c	udp: Prevent reuseport_select_sock from reading uninitialized socks	2021-01-23 16:03:59 +01:00
sock.c	init: add dsm gpl source	2024-07-05 18:00:04 +02:00
stream.c
sysctl_net_core.c
timestamping.c
tso.c
utils.c
xdp.c	xdp: fix xdp_return_frame() kernel BUG throw for page_pool memory model	2021-04-14 08:42:09 +02:00