Sergei Trofimovich 3387206f26 btrfs: properly handle overlapping areas in memmove_extent_buffer ... Fix data corruption caused by memcpy() usage on overlapping data. I've observed it first when found out usermode linux crash on btrfs. ?all chain is the following: ------------[ cut here ]------------ WARNING: at /home/slyfox/linux-2.6/fs/btrfs/extent_io.c:3900 memcpy_extent_buffer+0x1a5/0x219() Call Trace: 6fa39a58: [<601b495e>] _raw_spin_unlock_irqrestore+0x18/0x1c 6fa39a68: [<60029ad9>] warn_slowpath_common+0x59/0x70 6fa39aa8: [<60029b05>] warn_slowpath_null+0x15/0x17 6fa39ab8: [<600efc97>] memcpy_extent_buffer+0x1a5/0x219 6fa39b48: [<600efd9f>] memmove_extent_buffer+0x94/0x208 6fa39bc8: [<600becbf>] btrfs_del_items+0x214/0x473 6fa39c78: [<600ce1b0>] btrfs_delete_one_dir_name+0x7c/0xda 6fa39cc8: [<600dad6b>] __btrfs_unlink_inode+0xad/0x25d 6fa39d08: [<600d7864>] btrfs_start_transaction+0xe/0x10 6fa39d48: [<600dc9ff>] btrfs_unlink_inode+0x1b/0x3b 6fa39d78: [<600e04bc>] btrfs_unlink+0x70/0xef 6fa39dc8: [<6007f0d0>] vfs_unlink+0x58/0xa3 6fa39df8: [<60080278>] do_unlinkat+0xd4/0x162 6fa39e48: [<600517db>] call_rcu_sched+0xe/0x10 6fa39e58: [<600452a8>] __put_cred+0x58/0x5a 6fa39e78: [<6007446c>] sys_faccessat+0x154/0x166 6fa39ed8: [<60080317>] sys_unlink+0x11/0x13 6fa39ee8: [<60016b80>] handle_syscall+0x58/0x70 6fa39f08: [<60021377>] userspace+0x2d4/0x381 6fa39fc8: [<60014507>] fork_handler+0x62/0x69 ---[ end trace 70b0ca2ef0266b93 ]--- http://www.mail-archive.com/linux-btrfs@vger.kernel.org/msg09302.html Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org> Reviewed-by: Josef Bacik <josef@redhat.com> Signed-off-by: Chris Mason <chris.mason@oracle.com>		2011-04-11 20:25:06 -04:00
..
acl.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/mason/btrfs-unstable	2011-02-07 14:06:18 -08:00
async-thread.c	Btrfs: don't walk around with task->state != TASK_RUNNING	2010-05-25 10:34:58 -04:00
async-thread.h	Btrfs: fix deadlock on async thread startup	2009-10-05 09:44:45 -04:00
btrfs_inode.h	Btrfs: change reserved_extents to an atomic_t	2011-03-17 14:21:18 -04:00
compat.h	Btrfs: drop remaining LINUX_KERNEL_VERSION checks and compat code	2009-01-06 09:38:55 -05:00
compression.c	Btrfs: check return value of btrfs_alloc_path()	2011-03-28 05:37:54 -04:00
compression.h	btrfs: Extract duplicate decompress code	2010-12-22 23:15:50 +08:00
ctree.c	Btrfs: check return value of read_tree_block()	2011-03-28 05:37:37 -04:00
ctree.h	Btrfs: Fix uninitialized root flags for subvolumes	2011-04-05 01:20:24 -04:00
delayed-ref.c	Btrfs: add initial tracepoint support for btrfs	2011-03-28 05:37:33 -04:00
delayed-ref.h	Btrfs: Integrate metadata reservation with start_transaction	2010-05-25 10:34:50 -04:00
dir-item.c	Btrfs: check return value of btrfs_alloc_path()	2011-03-28 05:37:54 -04:00
disk-io.c	Btrfs: Fix uninitialized root flags for subvolumes	2011-04-05 01:20:24 -04:00
disk-io.h	Btrfs: forced readonly mounts on errors	2011-01-17 15:13:08 -05:00
export.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/mason/btrfs-unstable	2011-02-07 14:06:18 -08:00
export.h	NFS support for btrfs - v3	2008-09-25 11:04:06 -04:00
extent_io.c	btrfs: properly handle overlapping areas in memmove_extent_buffer	2011-04-11 20:25:06 -04:00
extent_io.h	Btrfs: check items for correctness as we search	2011-03-17 14:21:37 -04:00
extent_map.c	Btrfs: check return value of alloc_extent_map()	2011-02-14 16:21:37 -05:00
extent_map.h	btrfs: Allow to add new compression algorithm	2010-12-22 23:15:45 +08:00
extent-tree.c	Btrfs: fix OOPS of empty filesystem after balance	2011-03-28 05:37:53 -04:00
file-item.c	Btrfs: check return value of btrfs_alloc_path()	2011-03-28 05:37:54 -04:00
file.c	Btrfs: fix compiler warning in file.c	2011-04-05 01:19:41 -04:00
free-space-cache.c	Btrfs: fix free space cache when there are pinned extents and clusters V2	2011-04-05 01:20:24 -04:00
free-space-cache.h	Btrfs: add btrfs_trim_fs() to handle FITRIM	2011-03-28 05:37:47 -04:00
hash.h	Btrfs: remove crc32c.h and use libcrc32c directly.	2009-06-10 11:29:53 -04:00
inode-item.c	Btrfs: Integrate metadata reservation with start_transaction	2010-05-25 10:34:50 -04:00
inode-map.c	Btrfs: cleanup some BUG_ON()	2011-03-28 05:37:35 -04:00
inode.c	Btrfs: fix memory leaks in btrfs_new_inode()	2011-04-11 20:25:06 -04:00
ioctl.c	Btrfs: Fix uninitialized root flags for subvolumes	2011-04-05 01:20:24 -04:00
ioctl.h	Merge branch 'lzo-support' of git://repo.or.cz/linux-btrfs-devel into btrfs-38	2011-01-16 11:25:54 -05:00
Kconfig	btrfs: Add lzo compression support	2010-12-22 23:15:47 +08:00
locking.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	2010-03-30 22:02:32 +09:00
locking.h	Btrfs: fix spinlock assertions on UP systems	2009-03-09 11:45:38 -04:00
lzo.c	Btrfs: Avoid accessing unmapped kernel address	2011-02-16 15:37:58 -05:00
Makefile	btrfs: Add lzo compression support	2010-12-22 23:15:47 +08:00
ordered-data.c	Btrfs: add initial tracepoint support for btrfs	2011-03-28 05:37:33 -04:00
ordered-data.h	btrfs: Allow to add new compression algorithm	2010-12-22 23:15:45 +08:00
orphan.c	Btrfs: fixup return code for btrfs_del_orphan_item	2010-12-09 13:57:15 -05:00
print-tree.c	btrfs: fix missing break in switch phrase	2011-01-28 16:40:37 -05:00
print-tree.h	Btrfs: Create extent_buffer interface for large blocksizes	2008-09-25 11:03:56 -04:00
ref-cache.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	2010-03-30 22:02:32 +09:00
ref-cache.h	Btrfs: use RB_ROOT to intialize rb_trees instead of setting rb_node to NULL	2010-03-08 16:26:50 -05:00
relocation.c	Btrfs: check return value of read_tree_block()	2011-03-28 05:37:37 -04:00
root-tree.c	Btrfs: Fix uninitialized root flags for subvolumes	2011-04-05 01:20:24 -04:00
struct-funcs.c	Btrfs: Fix checkpatch.pl warnings	2009-01-05 21:25:51 -05:00
super.c	Btrfs: fix /proc/mounts info.	2011-04-05 01:19:41 -04:00
sysfs.c	Driver core: Constify struct sysfs_ops in struct kobj_type	2010-03-07 17:04:49 -08:00
transaction.c	Btrfs: Fix uninitialized root flags for subvolumes	2011-04-05 01:20:24 -04:00
transaction.h	Btrfs: Add readonly snapshots support	2010-12-23 08:49:17 +08:00
tree-defrag.c	Btrfs: cleanup warnings from gcc 4.6 (nonbugs)	2010-10-29 15:14:37 -04:00
tree-log.c	btrfs: make inode ref log recovery faster	2011-03-28 05:37:48 -04:00
tree-log.h	Btrfs: Metadata ENOSPC handling for tree log	2010-05-25 10:34:53 -04:00
version.h	Update Btrfs files for in-kernel usage	2008-09-25 15:41:59 -04:00
version.sh	Btrfs: Fixes for 2.6.28-rc API changes	2008-11-19 21:17:22 -05:00
volumes.c	Btrfs: fix __btrfs_map_block on 32 bit machines	2011-03-28 05:37:59 -04:00
volumes.h	Btrfs: make btrfs_map_block() return entire free extent for each device of RAID0/1/10/DUP	2011-03-28 05:37:45 -04:00
xattr.c	Btrfs: add checks to verify dir items are correct	2011-03-17 14:21:41 -04:00
xattr.h	btrfs: constify xattr_handler	2010-05-21 18:31:18 -04:00
zlib.c	btrfs: Extract duplicate decompress code	2010-12-22 23:15:50 +08:00