Lingutla Chandrasekhar c52232a49e timers: Forward timer base before migrating timers ... On CPU hotunplug the enqueued timers of the unplugged CPU are migrated to a live CPU. This happens from the control thread which initiated the unplug. If the CPU on which the control thread runs came out from a longer idle period then the base clock of that CPU might be stale because the control thread runs prior to any event which forwards the clock. In such a case the timers from the unplugged CPU are queued on the live CPU based on the stale clock which can cause large delays due to increased granularity of the outer timer wheels which are far away from base:;clock. But there is a worse problem than that. The following sequence of events illustrates it: - CPU0 timer1 is queued expires = 59969 and base->clk = 59131. The timer is queued at wheel level 2, with resulting expiry time = 60032 (due to level granularity). - CPU1 enters idle @60007, with next timer expiry @60020. - CPU0 is hotplugged at @60009 - CPU1 exits idle and runs the control thread which migrates the timers from CPU0 timer1 is now queued in level 0 for immediate handling in the next softirq because the requested expiry time 59969 is before CPU1 base->clk 60007 - CPU1 runs code which forwards the base clock which succeeds because the next expiring timer. which was collected at idle entry time is still set to 60020. So it forwards beyond 60007 and therefore misses to expire the migrated timer1. That timer gets expired when the wheel wraps around again, which takes between 63 and 630ms depending on the HZ setting. Address both problems by invoking forward_timer_base() for the control CPUs timer base. All other places, which might run into a similar problem (mod_timer()/add_timer_on()) already invoke forward_timer_base() to avoid that. [ tglx: Massaged comment and changelog ] Fixes: a683f390b9 ("timers: Forward the wheel clock whenever possible") Co-developed-by: Neeraj Upadhyay <neeraju@codeaurora.org> Signed-off-by: Neeraj Upadhyay <neeraju@codeaurora.org> Signed-off-by: Lingutla Chandrasekhar <clingutla@codeaurora.org> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Anna-Maria Gleixner <anna-maria@linutronix.de> Cc: linux-arm-msm@vger.kernel.org Cc: stable@vger.kernel.org Link: https://lkml.kernel.org/r/20180118115022.6368-1-clingutla@codeaurora.org		2018-02-28 23:34:33 +01:00
..
alarmtimer.c
clockevents.c
clocksource.c	treewide: setup_timer() -> timer_setup()	2017-11-21 15:57:07 -08:00
hrtimer.c	hrtimer: remove unneeded kallsyms include	2018-02-06 18:32:47 -08:00
itimer.c
jiffies.c
Kconfig	sched/isolation: Make CONFIG_NO_HZ_FULL select CONFIG_CPU_ISOLATION	2017-12-18 13:46:42 +01:00
Makefile
ntp_internal.h
ntp.c
posix-clock.c	vfs: do bulk POLL* -> EPOLL* replacement	2018-02-11 14:34:03 -08:00
posix-cpu-timers.c	Merge branch 'sched-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2018-01-30 11:55:56 -08:00
posix-stubs.c
posix-timers.c	signal: Replace memset(info,...) with clear_siginfo for clarity	2018-01-22 19:07:08 -06:00
posix-timers.h
sched_clock.c
test_udelay.c
tick-broadcast-hrtimer.c
tick-broadcast.c
tick-common.c
tick-internal.h	hrtimer: Unify remote enqueue handling	2018-01-16 02:53:58 +01:00
tick-oneshot.c
tick-sched.c	hrtimer: Optimize the hrtimer code by using static keys for migration_enable/nohz_active	2018-01-16 02:35:44 +01:00
tick-sched.h
time.c
timeconst.bc
timeconv.c
timecounter.c
timekeeping_debug.c
timekeeping_internal.h
timekeeping.c	timekeeping: Remove CONFIG_GENERIC_TIME_VSYSCALL_OLD	2017-11-14 11:20:25 +01:00
timekeeping.h
timer_list.c
timer.c	timers: Forward timer base before migrating timers	2018-02-28 23:34:33 +01:00