Vlad Buslov 4a5da47d5c net: sched: take reference to psample group in flow_action infra ... With recent patch set that removed rtnl lock dependency from cls hardware offload API rtnl lock is only taken when reading action data and can be released after action-specific data is parsed into intermediate representation. However, sample action psample group is passed by pointer without obtaining reference to it first, which makes it possible to concurrently overwrite the action and deallocate object pointed by psample_group pointer after rtnl lock is released but before driver finished using the pointer. To prevent such race condition, obtain reference to psample group while it is used by flow_action infra. Extend psample API with function psample_group_take() that increments psample group reference counter. Extend struct tc_action_ops with new get_psample_group() API. Implement the API for action sample using psample_group_take() and already existing psample_group_put() as a destructor. Use it in tc_setup_flow_action() to take reference to psample group pointed to by entry->sample.psample_group and release it in tc_cleanup_flow_action(). Disable bh when taking psample_groups_lock. The lock is now taken while holding action tcf_lock that is used by data path and requires bh to be disabled, so doing the same for psample_groups_lock is necessary to preserve SOFTIRQ-irq-safety. Fixes: 918190f50e ("net: sched: flower: don't take rtnl lock for cls hw offloads API") Signed-off-by: Vlad Buslov <vladbu@mellanox.com> Acked-by: Jiri Pirko <jiri@mellanox.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2019-09-16 09:18:03 +02:00
..
tc_bpf.h
tc_connmark.h
tc_csum.h
tc_ct.h
tc_ctinfo.h
tc_defact.h
tc_gact.h
tc_ife.h
tc_ipt.h
tc_mirred.h
tc_mpls.h
tc_nat.h
tc_pedit.h
tc_police.h
tc_sample.h
tc_skbedit.h
tc_skbmod.h
tc_tunnel_key.h
tc_vlan.h