Florian Fainelli d6af21a4fb net: dsa: Use prepare/commit phase in dsa_slave_vlan_rx_add_vid() ... We were skipping the prepare phase which causes some problems with at least a couple of drivers: - mv88e6xxx chooses to skip programming VID = 0 with -EOPNOTSUPP in the prepare phase, but we would still try to force this VID since we would only call the commit phase and so we would get the driver to return -EINVAL instead - qca8k does not currently have a port_vlan_add() callback implemented, yet we would try to call that unconditionally leading to a NPD Fix both issues by conforming to the current model doing a prepare/commit phase, this makes us consistent throughout the code and assumptions. Reported-by: Heiner Kallweit <hkallweit1@gmail.com> Reported-by: Michal Vokáč <michal.vokac@ysoft.com> Fixes: 061f6a505a ("net: dsa: Add ndo_vlan_rx_{add, kill}_vid implementation") Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2019-03-03 20:45:52 -08:00
..
dsa2.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-03-02 12:54:35 -08:00
dsa_priv.h	net: dsa: add KSZ9893 switch tagging support	2019-03-03 13:48:49 -08:00
dsa.c	net: dsa: add KSZ9893 switch tagging support	2019-03-03 13:48:49 -08:00
Kconfig	net: devlink: turn devlink into a built-in	2019-02-26 08:49:05 -08:00
legacy.c
Makefile
master.c
port.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-03-02 12:54:35 -08:00
slave.c	net: dsa: Use prepare/commit phase in dsa_slave_vlan_rx_add_vid()	2019-03-03 20:45:52 -08:00
switch.c	net: dsa: Add ndo_vlan_rx_{add, kill}_vid implementation	2019-02-22 11:53:32 -08:00
tag_brcm.c
tag_dsa.c	net: dsa: Implement flow_dissect callback for tag_dsa.	2019-02-18 16:35:41 -08:00
tag_edsa.c	net: dsa: Implement flow_dissect callback for tag_dsa.	2019-02-18 16:35:41 -08:00
tag_gswip.c
tag_ksz.c	net: dsa: add KSZ9893 switch tagging support	2019-03-03 13:48:49 -08:00
tag_lan9303.c
tag_mtk.c
tag_qca.c
tag_trailer.c