mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-21 20:47:12 +07:00
936b9df7a5
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:
struct foo {
int stuff;
struct boo array[];
};
By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by
this change:
"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]
sizeof(flexible-array-member) triggers a warning because flexible array
members have incomplete type[1]. There are some instances of code in
which the sizeof operator is being incorrectly/erroneously applied to
zero-length arrays and the result is zero. Such instances may be hiding
some bugs. So, this work (flexible-array member conversions) will also
help to get completely rid of those sorts of issues.
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit
|
||
|---|---|---|
| .. | ||
| bxt-sst.c | ||
| cnl-sst-dsp.c | ||
| cnl-sst-dsp.h | ||
| cnl-sst.c | ||
| Makefile | ||
| skl-debug.c | ||
| skl-i2s.h | ||
| skl-messages.c | ||
| skl-nhlt.c | ||
| skl-pcm.c | ||
| skl-ssp-clk.c | ||
| skl-ssp-clk.h | ||
| skl-sst-cldma.c | ||
| skl-sst-cldma.h | ||
| skl-sst-dsp.c | ||
| skl-sst-dsp.h | ||
| skl-sst-ipc.c | ||
| skl-sst-ipc.h | ||
| skl-sst-utils.c | ||
| skl-sst.c | ||
| skl-topology.c | ||
| skl-topology.h | ||
| skl.c | ||
| skl.h | ||