Cong Wang 6efb971ba8 net_sched: let qdisc_put() accept NULL pointer ... When tcf_block_get() fails in sfb_init(), q->qdisc is still a NULL pointer which leads to a crash in sfb_destroy(). Similar for sch_dsmark. Instead of fixing each separately, Linus suggested to just accept NULL pointer in qdisc_put(), which would make callers easier. (For sch_dsmark, the bug probably exists long before commit 6529eaba33f0.) Fixes: 6529eaba33 ("net: sched: introduce tcf block infractructure") Reported-by: syzbot+d5870a903591faaca4ae@syzkaller.appspotmail.com Suggested-by: Linus Torvalds <torvalds@linux-foundation.org> Cc: Jamal Hadi Salim <jhs@mojatatu.com> Cc: Jiri Pirko <jiri@resnulli.us> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> Acked-by: Jiri Pirko <jiri@mellanox.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2019-09-15 20:54:14 +02:00
..
act_api.c	idr: fix overflow case for idr_for_each_entry_ul()	2019-07-01 19:15:46 -07:00
act_bpf.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_connmark.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_csum.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_ct.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_ctinfo.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_gact.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_ife.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_ipt.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_meta_mark.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
act_meta_skbprio.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
act_meta_skbtcindex.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
act_mirred.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_mpls.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_nat.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_pedit.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_police.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_sample.c	net: sched: act_sample: fix psample group handling on overwrite	2019-08-28 15:53:51 -07:00
act_simple.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_skbedit.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_skbmod.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_tunnel_key.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_vlan.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
cls_api.c	net: sched: verify that q!=NULL before setting q->flags	2019-07-21 11:49:53 -07:00
cls_basic.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
cls_bpf.c	net: flow_offload: rename tc_setup_cb_t to flow_setup_cb_t	2019-07-19 21:27:45 -07:00
cls_cgroup.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
cls_flow.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
cls_flower.c	net: flow_offload: rename tc_setup_cb_t to flow_setup_cb_t	2019-07-19 21:27:45 -07:00
cls_fw.c	net: sched: remove NET_CLS_IND config option	2019-06-15 14:06:13 -07:00
cls_matchall.c	net: flow_offload: rename tc_setup_cb_t to flow_setup_cb_t	2019-07-19 21:27:45 -07:00
cls_route.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
cls_rsvp6.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
cls_rsvp.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
cls_rsvp.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
cls_tcindex.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
cls_u32.c	net: flow_offload: rename tc_setup_cb_t to flow_setup_cb_t	2019-07-19 21:27:45 -07:00
em_canid.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 11	2019-05-21 11:28:45 +02:00
em_cmp.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
em_ipset.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
em_ipt.c	net: sched: em_ipt: add support for addrtype matching	2019-06-29 11:15:12 -07:00
em_meta.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
em_nbyte.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
em_text.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
em_u32.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
ematch.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
Kconfig	net/sched: Make NET_ACT_CT depends on NF_NAT	2019-07-17 12:02:43 -07:00
Makefile	net/sched: Introduce action ct	2019-07-09 12:11:59 -07:00
sch_api.c	net_sched: check cops->tcf_block in tc_bind_tclass()	2019-09-10 18:28:56 +01:00
sch_atm.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
sch_blackhole.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_cake.c	netlink: make validation more configurable for future strictness	2019-04-27 17:07:21 -04:00
sch_cbq.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_cbs.c	net/sched: cbs: Set default link speed to 10 Mbps in cbs_set_port_rate	2019-08-31 18:45:35 -07:00
sch_choke.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
sch_codel.c	net: sched: Fix a possible null-pointer dereference in dequeue_func()	2019-07-29 09:46:58 -07:00
sch_drr.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
sch_dsmark.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
sch_etf.c	etf: Add skip_sock_check	2019-06-28 14:45:33 -07:00
sch_fifo.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_fq_codel.c	net_sched: unset TCQ_F_CAN_BYPASS when adding filters	2019-07-17 13:34:09 -07:00
sch_fq.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_generic.c	net_sched: let qdisc_put() accept NULL pointer	2019-09-15 20:54:14 +02:00
sch_gred.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_hfsc.c	netlink: make validation more configurable for future strictness	2019-04-27 17:07:21 -04:00
sch_hhf.c	sch_hhf: ensure quantum and hhf_non_hh_weight are non-zero	2019-09-10 18:31:00 +01:00
sch_htb.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_ingress.c	net: flow_offload: rename TCF_BLOCK_BINDER_TYPE_* to FLOW_BLOCK_BINDER_TYPE_*	2019-07-09 14:38:50 -07:00
sch_mq.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
sch_mqprio.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
sch_multiq.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 201	2019-05-30 11:29:52 -07:00
sch_netem.c	net: netem: fix use after free and double free with packet corruption	2019-06-18 21:30:38 -04:00
sch_pie.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 235	2019-06-19 17:09:07 +02:00
sch_plug.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_prio.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_qfq.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
sch_red.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_sfb.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
sch_sfq.c	net_sched: unset TCQ_F_CAN_BYPASS when adding filters	2019-07-17 13:34:09 -07:00
sch_skbprio.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_taprio.c	taprio: Set default link speed to 10 Mbps in taprio_set_picos_per_byte	2019-08-31 18:45:34 -07:00
sch_tbf.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_teql.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00