Shuah Khan 283ac6d5fb selftests: Fix test errors related to lib.mk khdr target ... Commit b2d35fa5fc ("selftests: add headers_install to lib.mk") added khdr target to run headers_install target from the main Makefile. The logic uses KSFT_KHDR_INSTALL and top_srcdir as controls to initialize variables and include files to run headers_install from the top level Makefile. There are a few problems with this logic. 1. Exposes top_srcdir to all tests 2. Common logic impacts all tests 3. Uses KSFT_KHDR_INSTALL, top_srcdir, and khdr in an adhoc way. Tests add "khdr" dependency in their Makefiles to TEST_PROGS_EXTENDED in some cases, and STATIC_LIBS in other cases. This makes this framework confusing to use. The common logic that runs for all tests even when KSFT_KHDR_INSTALL isn't defined by the test. top_srcdir is initialized to a default value when test doesn't initialize it. It works for all tests without a sub-dir structure and tests with sub-dir structure fail to build. e.g: make -C sparc64/drivers/ or make -C drivers/dma-buf ../../lib.mk:20: ../../../../scripts/subarch.include: No such file or directory make: *** No rule to make target '../../../../scripts/subarch.include'. Stop. There is no reason to require all tests to define top_srcdir and there is no need to require tests to add khdr dependency using adhoc changes to TEST_* and other variables. Fix it with a consistent use of KSFT_KHDR_INSTALL and top_srcdir from tests that have the dependency on headers_install. Change common logic to include khdr target define and "all" target with dependency on khdr when KSFT_KHDR_INSTALL is defined. Only tests that have dependency on headers_install have to define just the KSFT_KHDR_INSTALL, and top_srcdir variables and there is no need to specify khdr dependency in the test Makefiles. Fixes: b2d35fa5fc ("selftests: add headers_install to lib.mk") Cc: stable@vger.kernel.org Signed-off-by: Shuah Khan <shuah@kernel.org> Reviewed-by: Khalid Aziz <khalid.aziz@oracle.com> Reviewed-by: Anders Roxell <anders.roxell@linaro.org> Signed-off-by: Shuah Khan <shuah@kernel.org>		2018-12-17 09:17:55 -07:00
..
accounting	delayacct: track delays from thrashing cache pages	2018-10-26 16:26:32 -07:00
arch	tools headers: Sync the various kvm.h header copies	2018-10-31 09:57:53 -03:00
bpf	tools: bpftool: fix completion for "bpftool map update"	2018-10-21 20:45:14 +02:00
build
cgroup
crypto
firewire
gpio
hv
iio
include	Merge branch 'perf-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2018-11-03 18:13:43 -07:00
kvm/kvm_stat
laptop
leds
lib	Merge branch 'perf-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2018-11-03 18:13:43 -07:00
memory-model
nfsd
objtool	Merge branch 'core/urgent' into x86/urgent, to pick up objtool fix	2018-11-03 23:42:16 +01:00
pci
pcmcia
perf	Merge branch 'perf-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2018-11-03 18:13:43 -07:00
power	Merge branch 'x86-cpu-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2018-10-23 16:16:40 +01:00
scripts
spi
testing	selftests: Fix test errors related to lib.mk khdr target	2018-12-17 09:17:55 -07:00
thermal/tmon
time
usb	usbip: tools: fix atoi() on non-null terminated string	2018-10-18 19:44:39 +02:00
virtio
vm
wmi
Makefile