linux_dsm_epyc7002/drivers/media
Gustavo A. R. Silva 281643a2ad media: s5k5baf: remove unnecessary static in s5k5baf_get_selection()
Remove unnecessary static on local variable rtype. Such variable
is initialized before being used, on every execution path throughout
the function. The static has no benefit and, removing it reduces
the code size.

This issue was detected using Coccinelle and the following semantic patch:

@bad exists@
position p;
identifier x;
type T;
@@

static T x@p;
...
x = <+...x...+>

@@
identifier x;
expression e;
type T;
position p != bad.p;
@@

-static
 T x@p;
 ... when != x
     when strict
?x = e;

In the following log you can see the difference in the code size. Also,
there is a significant difference in the bss segment. This log is the
output of the size command, before and after the code change:

before:
   text    data     bss     dec     hex filename
  27765    5656     320   33741    83cd drivers/media/i2c/s5k5baf.o

after:
   text    data     bss     dec     hex filename
  27733    5600     256   33589    8335 drivers/media/i2c/s5k5baf.o

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2017-07-26 08:37:30 -04:00
..
cec media: cec: drop senseless message 2017-07-18 13:00:26 -03:00
common media: saa7146: constify i2c_algorithm structure 2017-07-20 14:55:14 -04:00
dvb-core media: dvb-core/demux.h: fix kernel-doc warning 2017-07-21 08:01:08 -04:00
dvb-frontends media: dvb-frontends: mb86a16: remove useless variables in signal_det() 2017-07-20 16:29:11 -04:00
firewire [media] firewire: don't break long lines 2016-10-21 10:06:00 -02:00
i2c media: s5k5baf: remove unnecessary static in s5k5baf_get_selection() 2017-07-26 08:37:30 -04:00
mmc
pci media: cx25821: get rid of CX25821_VERSION_CODE 2017-07-20 16:21:38 -04:00
platform media: s5p-jpeg: Add stream error handling for Exynos5420 2017-07-26 08:36:50 -04:00
radio Linux v4.13-rc1 2017-07-17 11:17:36 -03:00
rc [media] rc-core: cleanup rc_register_device pt2 2017-06-13 13:55:01 -03:00
spi [media] gs1662: drop kfree for memory allocated with devm_kzalloc 2016-10-24 17:59:08 -02:00
tuners media: fc001[23]: make const gain table arrays static 2017-07-19 15:12:39 -04:00
usb media: Added support for the TerraTec T1 DVB-T USB tuner [IT9135 chipset] 2017-07-20 16:46:49 -04:00
v4l2-core media: v4l2-fwnode: make v4l2_fwnode_endpoint_parse_csi1_bus static 2017-07-20 16:27:27 -04:00
Kconfig media: cec-pin: add low-level pin hardware support 2017-07-18 12:57:18 -03:00
Makefile [media] cec: select CEC_CORE instead of depend on it 2017-06-04 15:23:33 -03:00
media-device.c media: devnode: Rename mdev argument as devnode 2017-07-20 15:11:40 -04:00
media-devnode.c media: utilize new cdev_device_add helper function 2017-03-21 06:44:33 +01:00
media-entity.c media: Make parameter of media_entity_remote_pad() const 2017-07-20 16:54:04 -04:00