Hans de Goede 2a2e911469 platform/x86: hp-wmi: Disable tablet-mode reporting by default ... [ Upstream commit 67fbe02a5cebc3c653610f12e3c0424e58450153 ] Recently userspace has started making more use of SW_TABLET_MODE (when an input-dev reports this). Specifically recent GNOME3 versions will: 1. When SW_TABLET_MODE is reported and is reporting 0: 1.1 Disable accelerometer-based screen auto-rotation 1.2 Disable automatically showing the on-screen keyboard when a text-input field is focussed 2. When SW_TABLET_MODE is reported and is reporting 1: 2.1 Ignore input-events from the builtin keyboard and touchpad (this is for 360° hinges style 2-in-1s where the keyboard and touchpads are accessible on the back of the tablet when folded into tablet-mode) This means that claiming to support SW_TABLET_MODE when it does not actually work / reports correct values has bad side-effects. The check in the hp-wmi code which is used to decide if the input-dev should claim SW_TABLET_MODE support, only checks if the HPWMI_HARDWARE_QUERY is supported. It does *not* check if the hardware actually is capable of reporting SW_TABLET_MODE. This leads to the hp-wmi input-dev claiming SW_TABLET_MODE support, while in reality it will always report 0 as SW_TABLET_MODE value. This has been seen on a "HP ENVY x360 Convertible 15-cp0xxx" and this likely is the case on a whole lot of other HP models. This problem causes both auto-rotation and on-screen keyboard support to not work on affected x360 models. There is no easy fix for this, but since userspace expects SW_TABLET_MODE reporting to be reliable when advertised it is better to not claim/report SW_TABLET_MODE support at all, then to claim to support it while it does not work. To avoid the mentioned problems, add a new enable_tablet_mode_sw module-parameter which defaults to false. Note I've made this an int using the standard -1=auto, 0=off, 1=on triplett, with the hope that in the future we can come up with a better way to detect SW_TABLET_MODE support. ATM the default auto option just does the same as off. BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1918255 Cc: Stefan Brüns <stefan.bruens@rwth-aachen.de> Signed-off-by: Hans de Goede <hdegoede@redhat.com> Acked-by: Mark Gross <mgross@linux.intel.com> Link: https://lore.kernel.org/r/20210120124941.73409-1-hdegoede@redhat.com Signed-off-by: Sasha Levin <sashal@kernel.org>		2021-02-17 11:02:22 +01:00
..
intel_speed_select_if
acer-wireless.c
acer-wmi.c
acerhdf.c
alienware-wmi.c
amilo-rfkill.c
apple-gmux.c
asus-laptop.c
asus-nb-wmi.c
asus-wireless.c
asus-wmi.c
asus-wmi.h
classmate-laptop.c
compal-laptop.c
dcdbas.c
dcdbas.h
dell_rbu.c
dell-laptop.c
dell-rbtn.c
dell-rbtn.h
dell-smbios-base.c
dell-smbios-smm.c
dell-smbios-wmi.c
dell-smbios.h
dell-smo8800.c
dell-wmi-aio.c
dell-wmi-descriptor.c
dell-wmi-descriptor.h
dell-wmi-led.c
dell-wmi.c
eeepc-laptop.c
eeepc-wmi.c
fujitsu-laptop.c
fujitsu-tablet.c
gpd-pocket-fan.c
hdaps.c
hp_accel.c
hp-wireless.c
hp-wmi.c	platform/x86: hp-wmi: Disable tablet-mode reporting by default	2021-02-17 11:02:22 +01:00
huawei-wmi.c
i2c-multi-instantiate.c
ibm_rtl.c
ideapad-laptop.c
intel_atomisp2_led.c
intel_atomisp2_pm.c
intel_bxtwc_tmu.c
intel_cht_int33fe_common.c
intel_cht_int33fe_common.h
intel_cht_int33fe_microb.c
intel_cht_int33fe_typec.c
intel_chtdc_ti_pwrbtn.c
intel_int0002_vgpio.c
intel_ips.c
intel_ips.h
intel_menlow.c
intel_mid_powerbtn.c
intel_mid_thermal.c
intel_mrfld_pwrbtn.c
intel_oaktrail.c
intel_pmc_core_pltdrv.c
intel_pmc_core.c
intel_pmc_core.h
intel_punit_ipc.c
intel_scu_ipc.c
intel_scu_ipcutil.c
intel_scu_pcidrv.c
intel_scu_pltdrv.c
intel_telemetry_core.c
intel_telemetry_debugfs.c
intel_telemetry_pltdrv.c
intel_turbo_max_3.c
intel-hid.c
intel-rst.c
intel-smartconnect.c
intel-uncore-frequency.c
intel-vbtn.c	platform/x86: intel-vbtn: Support for tablet mode on Dell Inspiron 7352	2021-02-07 15:37:13 +01:00
intel-wmi-sbl-fw-update.c
intel-wmi-thunderbolt.c
Kconfig
lg-laptop.c
Makefile
mlx-platform.c
msi-laptop.c
msi-wmi.c
mxm-wmi.c
panasonic-laptop.c
pcengines-apuv2.c
peaq-wmi.c
pmc_atom.c
samsung-laptop.c
samsung-q10.c
sony-laptop.c
surface3_button.c
surface3_power.c
surface3-wmi.c
surfacepro3_button.c
system76_acpi.c
tc1100-wmi.c
thinkpad_acpi.c	platform/x86: thinkpad_acpi: Add P53/73 firmware to fan_quirk_table for dual fan control	2021-02-07 15:37:16 +01:00
topstar-laptop.c
toshiba_acpi.c
toshiba_bluetooth.c
toshiba_haps.c
toshiba-wmi.c
touchscreen_dmi.c	platform/x86: touchscreen_dmi: Add swap-x-y quirk for Goodix touchscreen on Estar Beauty HD tablet	2021-02-07 15:37:13 +01:00
wmi-bmof.c
wmi.c
xiaomi-wmi.c
xo1-rfkill.c
xo15-ebook.c