Sebastian Siewior 2786aae7fc net/ti davinci_mdio: don't hold a spin lock while calling pm_runtime ... was playing with suspend and run into this: |BUG: sleeping function called from invalid context at drivers/base/power/runtime.c:891 |in_atomic(): 1, irqs_disabled(): 0, pid: 1963, name: bash |6 locks held by bash/1963: |CPU: 0 PID: 1963 Comm: bash Not tainted 3.10.0-rc4+ #50 |[<c0014fdc>] (unwind_backtrace+0x0/0xf8) from [<c0011da4>] (show_stack+0x10/0x14) |[<c0011da4>] (show_stack+0x10/0x14) from [<c02e8680>] (__pm_runtime_idle+0xa4/0xac) |[<c02e8680>] (__pm_runtime_idle+0xa4/0xac) from [<c0341158>] (davinci_mdio_suspend+0x6c/0x9c) |[<c0341158>] (davinci_mdio_suspend+0x6c/0x9c) from [<c02e0628>] (platform_pm_suspend+0x2c/0x54) |[<c02e0628>] (platform_pm_suspend+0x2c/0x54) from [<c02e52bc>] (dpm_run_callback.isra.3+0x2c/0x64) |[<c02e52bc>] (dpm_run_callback.isra.3+0x2c/0x64) from [<c02e57e4>] (__device_suspend+0x100/0x22c) |[<c02e57e4>] (__device_suspend+0x100/0x22c) from [<c02e67e8>] (dpm_suspend+0x68/0x230) |[<c02e67e8>] (dpm_suspend+0x68/0x230) from [<c0072a20>] (suspend_devices_and_enter+0x68/0x350) |[<c0072a20>] (suspend_devices_and_enter+0x68/0x350) from [<c0072f18>] (pm_suspend+0x210/0x24c) |[<c0072f18>] (pm_suspend+0x210/0x24c) from [<c0071c74>] (state_store+0x6c/0xbc) |[<c0071c74>] (state_store+0x6c/0xbc) from [<c02714dc>] (kobj_attr_store+0x14/0x20) |[<c02714dc>] (kobj_attr_store+0x14/0x20) from [<c01341a0>] (sysfs_write_file+0x16c/0x19c) |[<c01341a0>] (sysfs_write_file+0x16c/0x19c) from [<c00ddfe4>] (vfs_write+0xb4/0x190) |[<c00ddfe4>] (vfs_write+0xb4/0x190) from [<c00de3a4>] (SyS_write+0x3c/0x70) |[<c00de3a4>] (SyS_write+0x3c/0x70) from [<c000e2c0>] (ret_fast_syscall+0x0/0x48) I don't see a reason why the pm_runtime call must be under the lock. Further I don't understand why this is a spinlock and not mutex. Cc: Mugunthan V N <mugunthanvnm@ti.com> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Acked-by: Mugunthan V N <mugunthanvnm@ti.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2013-06-11 02:26:01 -07:00
..
appletalk
arcnet
bonding	bonding: fix multiple 3ad mode sysfs race conditions	2013-05-19 23:25:49 -07:00
caif	caif: CAIF_VIRTIO should depend on HAS_DMA	2013-05-11 16:28:24 -07:00
can	net: can: peak_usb: Do not do dma on the stack	2013-06-03 14:05:32 +02:00
cris
dsa
ethernet	net/ti davinci_mdio: don't hold a spin lock while calling pm_runtime	2013-06-11 02:26:01 -07:00
fddi
hamradio	drivers/net: rename random32() to prandom_u32()	2013-05-07 18:38:27 -07:00
hippi
hyperv	hyperv: Fix vlan_proto setting in netvsc_recv_callback()	2013-05-31 17:33:40 -07:00
ieee802154
irda	net/irda: fix error return code in bfin_sir_open()	2013-05-08 13:13:29 -07:00
phy	net: phy: fix a bug when verify the EEE support	2013-05-27 23:30:09 -07:00
plip
ppp	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2013-05-01 14:08:52 -07:00
slip
team	team: fix port list dump for big number of ports	2013-05-31 17:31:52 -07:00
usb	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2013-05-24 08:27:32 -07:00
vmxnet3
wan
wimax
wireless	ath9k: use correct OTP register offsets for AR9550	2013-05-28 13:43:10 -04:00
xen-netback	xen-netback: better names for thresholds	2013-05-02 16:50:08 -04:00
dummy.c
eql.c
ifb.c
Kconfig
LICENSE.SRC
loopback.c
macvlan.c	macvlan: fix passthru mode race between dev removal and rx path	2013-05-11 16:25:00 -07:00
macvtap.c
Makefile
mdio.c
mii.c
netconsole.c
ntb_netdev.c	ntb_netdev: remove from list on exit	2013-05-15 10:58:14 -07:00
rionet.c
sb1000.c
Space.c
sungem_phy.c
tun.c	tuntap: fix a possible race between queue selection and changing queues	2013-06-10 14:32:47 -07:00
veth.c
virtio_net.c	virtio_net: enable napi for all possible queues during open	2013-05-23 00:10:59 -07:00
vxlan.c	vxlan: Update vxlan fdb 'used' field after each usage	2013-05-18 12:53:39 -07:00
xen-netfront.c